All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>
Cc: "Song, Jike" <jike.song@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"Tian, Kevin" <kevin.tian@intel.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"cjia@nvidia.com" <cjia@nvidia.com>,
	"kraxel@redhat.com" <kraxel@redhat.com>,
	Laine Stump <laine@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"bjsdjshi@linux.vnet.ibm.com" <bjsdjshi@linux.vnet.ibm.com>
Subject: Re: [PATCH v8 4/6] docs: Add Documentation for Mediated devices
Date: Thu, 13 Oct 2016 22:22:26 -0600	[thread overview]
Message-ID: <20161013222226.0bdbcdf3@t450s.home> (raw)
In-Reply-To: <df840ea8-5931-1100-c6e0-e656ae2f8e11@nvidia.com>

On Fri, 14 Oct 2016 09:01:01 +0530
Kirti Wankhede <kwankhede@nvidia.com> wrote:

> On 10/13/2016 8:06 PM, Alex Williamson wrote:
> > On Thu, 13 Oct 2016 14:52:09 +0530
> > Kirti Wankhede <kwankhede@nvidia.com> wrote:
> >   
> >> On 10/13/2016 3:14 AM, Alex Williamson wrote:  
> >>> Under the device we have "mtty2", shouldn't that be
> >>> "mdev_supported_type", which then links to mtty2?  Otherwise a user
> >>> needs to decode from the link what this attribute is.
> >>>     
> >>
> >> I thought it should show type, so that by looking at 'ls' output user
> >> should be able to find type_id.  
> > 
> > The type_id should be shown by actually reading the link, not by the
> > link name itself, the same way that the iommu_group link for a device
> > isn't the group number, it links to the group number but uses a
> > standard link name.
> >   
> 
> Ok. I'll rename the link name to 'mdev_supported_type'

Hmm, if we have a device, then clearly it's a supported type, we can
probably reduce this to 'mdev_type'.  Sorry for not catching that.

BTW, please include the linux-kernel <linux-kernel@vger.kernel.org>
mailing list on the CC in your next posting.  Thanks,

Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alex Williamson <alex.williamson@redhat.com>
To: Kirti Wankhede <kwankhede@nvidia.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	"Daniel P. Berrange" <berrange@redhat.com>,
	"pbonzini@redhat.com" <pbonzini@redhat.com>,
	"kraxel@redhat.com" <kraxel@redhat.com>,
	"cjia@nvidia.com" <cjia@nvidia.com>,
	"Song, Jike" <jike.song@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"bjsdjshi@linux.vnet.ibm.com" <bjsdjshi@linux.vnet.ibm.com>,
	Laine Stump <laine@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v8 4/6] docs: Add Documentation for Mediated devices
Date: Thu, 13 Oct 2016 22:22:26 -0600	[thread overview]
Message-ID: <20161013222226.0bdbcdf3@t450s.home> (raw)
In-Reply-To: <df840ea8-5931-1100-c6e0-e656ae2f8e11@nvidia.com>

On Fri, 14 Oct 2016 09:01:01 +0530
Kirti Wankhede <kwankhede@nvidia.com> wrote:

> On 10/13/2016 8:06 PM, Alex Williamson wrote:
> > On Thu, 13 Oct 2016 14:52:09 +0530
> > Kirti Wankhede <kwankhede@nvidia.com> wrote:
> >   
> >> On 10/13/2016 3:14 AM, Alex Williamson wrote:  
> >>> Under the device we have "mtty2", shouldn't that be
> >>> "mdev_supported_type", which then links to mtty2?  Otherwise a user
> >>> needs to decode from the link what this attribute is.
> >>>     
> >>
> >> I thought it should show type, so that by looking at 'ls' output user
> >> should be able to find type_id.  
> > 
> > The type_id should be shown by actually reading the link, not by the
> > link name itself, the same way that the iommu_group link for a device
> > isn't the group number, it links to the group number but uses a
> > standard link name.
> >   
> 
> Ok. I'll rename the link name to 'mdev_supported_type'

Hmm, if we have a device, then clearly it's a supported type, we can
probably reduce this to 'mdev_type'.  Sorry for not catching that.

BTW, please include the linux-kernel <linux-kernel@vger.kernel.org>
mailing list on the CC in your next posting.  Thanks,

Alex

  reply	other threads:[~2016-10-14  4:22 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-10 20:28 [PATCH v8 0/6] Add Mediated device support Kirti Wankhede
2016-10-10 20:28 ` [Qemu-devel] " Kirti Wankhede
2016-10-10 20:28 ` [PATCH v8 1/6] vfio: Mediated device Core driver Kirti Wankhede
2016-10-10 20:28   ` [Qemu-devel] " Kirti Wankhede
2016-10-10 21:00   ` Eric Blake
2016-10-10 21:00     ` Eric Blake
2016-10-11  3:51   ` Alex Williamson
2016-10-11  3:51     ` [Qemu-devel] " Alex Williamson
2016-10-11 20:13     ` Kirti Wankhede
2016-10-11 20:13       ` [Qemu-devel] " Kirti Wankhede
2016-10-12  8:39   ` Tian, Kevin
2016-10-12  8:39     ` [Qemu-devel] " Tian, Kevin
2016-10-10 20:28 ` [PATCH v8 2/6] vfio: VFIO based driver for Mediated devices Kirti Wankhede
2016-10-10 20:28   ` [Qemu-devel] " Kirti Wankhede
2016-10-11  3:55   ` Alex Williamson
2016-10-11  3:55     ` [Qemu-devel] " Alex Williamson
2016-10-11 20:24     ` Kirti Wankhede
2016-10-11 20:24       ` [Qemu-devel] " Kirti Wankhede
2016-10-10 20:28 ` [PATCH v8 3/6] vfio iommu: Add support for mediated devices Kirti Wankhede
2016-10-10 20:28   ` [Qemu-devel] " Kirti Wankhede
2016-10-11 22:06   ` Alex Williamson
2016-10-11 22:06     ` [Qemu-devel] " Alex Williamson
2016-10-12 10:38     ` Tian, Kevin
2016-10-12 10:38       ` [Qemu-devel] " Tian, Kevin
2016-10-13 14:34     ` Kirti Wankhede
2016-10-13 14:34       ` [Qemu-devel] " Kirti Wankhede
2016-10-13 17:12       ` Alex Williamson
2016-10-13 17:12         ` [Qemu-devel] " Alex Williamson
2016-10-12 10:31   ` Tian, Kevin
2016-10-12 10:31     ` [Qemu-devel] " Tian, Kevin
2016-10-14 11:35     ` Kirti Wankhede
2016-10-14 11:35       ` [Qemu-devel] " Kirti Wankhede
2016-10-14 12:29       ` Tian, Kevin
2016-10-14 12:29         ` [Qemu-devel] " Tian, Kevin
2016-10-10 20:28 ` [PATCH v8 4/6] docs: Add Documentation for Mediated devices Kirti Wankhede
2016-10-10 20:28   ` [Qemu-devel] " Kirti Wankhede
2016-10-11 14:14   ` Daniel P. Berrange
2016-10-11 20:44     ` Kirti Wankhede
2016-10-11 20:44       ` Kirti Wankhede
2016-10-12  1:52       ` Tian, Kevin
2016-10-12  1:52         ` [Qemu-devel] " Tian, Kevin
2016-10-12 15:13         ` Kirti Wankhede
2016-10-12 15:13           ` [Qemu-devel] " Kirti Wankhede
2016-10-12 15:59           ` Alex Williamson
2016-10-12 15:59             ` [Qemu-devel] " Alex Williamson
2016-10-12 19:02             ` Kirti Wankhede
2016-10-12 19:02               ` [Qemu-devel] " Kirti Wankhede
2016-10-12 21:44               ` Alex Williamson
2016-10-13  9:22                 ` Kirti Wankhede
2016-10-13 14:36                   ` Alex Williamson
2016-10-13 14:36                     ` [Qemu-devel] " Alex Williamson
2016-10-13 16:00                     ` Paolo Bonzini
2016-10-13 16:00                       ` [Qemu-devel] " Paolo Bonzini
2016-10-13 16:30                       ` Alex Williamson
2016-10-14  3:31                     ` Kirti Wankhede
2016-10-14  4:22                       ` Alex Williamson [this message]
2016-10-14  4:22                         ` Alex Williamson
2016-10-13  3:27               ` Tian, Kevin
2016-10-13  3:27                 ` [Qemu-devel] " Tian, Kevin
2016-10-14  2:22   ` Jike Song
2016-10-14  2:22     ` [Qemu-devel] " Jike Song
2016-10-14  3:15     ` Kirti Wankhede
2016-10-14  3:15       ` [Qemu-devel] " Kirti Wankhede
2016-10-10 20:28 ` [PATCH v8 5/6] Add simple sample driver for mediated device framework Kirti Wankhede
2016-10-10 20:28   ` [Qemu-devel] " Kirti Wankhede
2016-10-10 20:28 ` [PATCH v8 6/6] Add common functions for SET_IRQS and GET_REGION_INFO ioctls Kirti Wankhede
2016-10-10 20:28   ` [Qemu-devel] " Kirti Wankhede
2016-10-11 23:18   ` Alex Williamson
2016-10-11 23:18     ` [Qemu-devel] " Alex Williamson
2016-10-12 19:37     ` Kirti Wankhede
2016-10-12 19:37       ` [Qemu-devel] " Kirti Wankhede
2016-10-11  2:23 ` [PATCH v8 0/6] Add Mediated device support Jike Song
2016-10-11  2:23   ` [Qemu-devel] " Jike Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161013222226.0bdbcdf3@t450s.home \
    --to=alex.williamson@redhat.com \
    --cc=bjsdjshi@linux.vnet.ibm.com \
    --cc=cjia@nvidia.com \
    --cc=jike.song@intel.com \
    --cc=kevin.tian@intel.com \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwankhede@nvidia.com \
    --cc=laine@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.