[PATCH] staging: dgnc: Add const qualifier to struct declaration.

[PATCH] staging: dgnc: Add const qualifier to struct declaration.

[Elise Lennion]

Const qualifier added to struct declaration to make the code more
efficient.

Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
---
 drivers/staging/dgnc/dgnc_driver.c | 2 +-
 drivers/staging/dgnc/dgnc_tty.c    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index fd372d3..6576674 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -93,7 +93,7 @@ struct board_id {
 	unsigned int is_pci_express;
 };
 
-static struct board_id dgnc_ids[] = {
+static const struct board_id dgnc_ids[] = {
 	{	PCI_DEVICE_CLASSIC_4_PCI_NAME,		4,	0	},
 	{	PCI_DEVICE_CLASSIC_4_422_PCI_NAME,	4,	0	},
 	{	PCI_DEVICE_CLASSIC_8_PCI_NAME,		8,	0	},
diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
index ef9a45b..cf8aefd 100644
--- a/drivers/staging/dgnc/dgnc_tty.c
+++ b/drivers/staging/dgnc/dgnc_tty.c
@@ -50,7 +50,7 @@ static unsigned char		*dgnc_TmpWriteBuf;
 /*
  * Default transparent print information.
  */
-static struct digi_t dgnc_digi_init = {
+static const struct digi_t dgnc_digi_init = {
 	.digi_flags =	DIGI_COOK,	/* Flags			*/
 	.digi_maxcps =	100,		/* Max CPS			*/
 	.digi_maxchar =	50,		/* Max chars in print queue	*/
-- 
2.7.4

Re: [Outreachy kernel] [PATCH] staging: dgnc: Add const qualifier to struct declaration.

[Julia Lawall]

On Thu, 13 Oct 2016, Elise Lennion wrote:

> Const qualifier added to struct declaration to make the code more
> efficient.

It's not an efficiency issue.  The goal is to protect the data from being
overwritten at runtime.

julia

>
> Signed-off-by: Elise Lennion <elise.lennion@gmail.com>
> ---
>  drivers/staging/dgnc/dgnc_driver.c | 2 +-
>  drivers/staging/dgnc/dgnc_tty.c    | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
> index fd372d3..6576674 100644
> --- a/drivers/staging/dgnc/dgnc_driver.c
> +++ b/drivers/staging/dgnc/dgnc_driver.c
> @@ -93,7 +93,7 @@ struct board_id {
>  	unsigned int is_pci_express;
>  };
>
> -static struct board_id dgnc_ids[] = {
> +static const struct board_id dgnc_ids[] = {
>  	{	PCI_DEVICE_CLASSIC_4_PCI_NAME,		4,	0	},
>  	{	PCI_DEVICE_CLASSIC_4_422_PCI_NAME,	4,	0	},
>  	{	PCI_DEVICE_CLASSIC_8_PCI_NAME,		8,	0	},
> diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c
> index ef9a45b..cf8aefd 100644
> --- a/drivers/staging/dgnc/dgnc_tty.c
> +++ b/drivers/staging/dgnc/dgnc_tty.c
> @@ -50,7 +50,7 @@ static unsigned char		*dgnc_TmpWriteBuf;
>  /*
>   * Default transparent print information.
>   */
> -static struct digi_t dgnc_digi_init = {
> +static const struct digi_t dgnc_digi_init = {
>  	.digi_flags =	DIGI_COOK,	/* Flags			*/
>  	.digi_maxcps =	100,		/* Max CPS			*/
>  	.digi_maxchar =	50,		/* Max chars in print queue	*/
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20161014022116.GA5477%40lennorien.com.
> For more options, visit https://groups.google.com/d/optout.
>