From: Al Viro <viro@ZenIV.linux.org.uk>
To: Andreas Gruenbacher <agruenba@redhat.com>
Cc: Vivek Goyal <vgoyal@redhat.com>,
Miklos Szeredi <mszeredi@redhat.com>,
CAI Qian <caiqian@redhat.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] overlayfs: Fix setting IOP_XATTR flag
Date: Fri, 14 Oct 2016 03:49:05 +0100 [thread overview]
Message-ID: <20161014024905.GY19539@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1476407016-4993-1-git-send-email-agruenba@redhat.com>
On Fri, Oct 14, 2016 at 03:03:36AM +0200, Andreas Gruenbacher wrote:
> From: Vivek Goyal <vgoyal@redhat.com>
>
> ovl_fill_super calls ovl_new_inode to create a root inode for the new
> superblock before initializing sb->s_xattr. This wrongly causes
> IOP_XATTR to be cleared in i_opflags of the new inode, causing SELinux
> to log the following message:
>
> SELinux: (dev overlay, type overlay) has no xattr support
>
> Fix this by initializing sb->s_xattr and similar fields before calling
> ovl_new_inode.
Applied.
prev parent reply other threads:[~2016-10-14 3:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 1:03 [PATCH] overlayfs: Fix setting IOP_XATTR flag Andreas Gruenbacher
2016-10-14 2:49 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014024905.GY19539@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=agruenba@redhat.com \
--cc=caiqian@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mszeredi@redhat.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.