From: Andrew Lunn <andrew@lunn.ch>
To: Timur Tabi <timur@codeaurora.org>
Cc: netdev@vger.kernel.org
Subject: Re: Need help with mdiobus_register and phy
Date: Fri, 14 Oct 2016 15:18:52 +0200 [thread overview]
Message-ID: <20161014131852.GM5822@lunn.ch> (raw)
In-Reply-To: <5800D796.1030602@codeaurora.org>
On Fri, Oct 14, 2016 at 08:03:18AM -0500, Timur Tabi wrote:
> Andrew Lunn wrote:
> >Have you tried using the ethernet-phy-id device tree property? It
> >looks like that will allow you to skip get_phy_device and just create
> >the phy device. You can then bring the phy out of sleep in the probe
> >function?
>
> The problem I'm experiencing is with ACPI, so I can't use any of the
> fancy of_ apis like of_get_phy_id(). But I'll look into it.
>
> Is it possible that at803x_suspend() is too aggressive? That's it's
> effectively disabling the phy? While the phy is suspended, should
> it still respond to MII_PHYSID1 and MII_PHYSID2 requests?
That is a basic assumption of the code. If you cannot read the IDs how
are you supposed to know what device it is, and what quirks you need
to work around its broken features...
Does the datasheet say anything about this?
I would say for this device, suspend() is too aggressive.
Andrew
next prev parent reply other threads:[~2016-10-14 13:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 23:15 Need help with mdiobus_register and phy Timur Tabi
2016-10-14 4:06 ` Andrew Lunn
2016-10-14 11:38 ` Timur Tabi
2016-10-14 12:06 ` Andrew Lunn
2016-10-14 12:39 ` Timur Tabi
2016-10-14 12:49 ` Andrew Lunn
2016-10-14 12:49 ` Timur Tabi
2016-10-14 12:57 ` Andrew Lunn
2016-10-14 13:03 ` Timur Tabi
2016-10-14 13:18 ` Andrew Lunn [this message]
2016-10-14 13:28 ` Timur Tabi
2016-10-14 16:57 ` Timur Tabi
2016-10-14 17:25 ` Andrew Lunn
2016-10-14 18:30 ` Timur Tabi
2016-10-15 10:19 ` Florian Fainelli
2016-10-15 14:39 ` Timur Tabi
2016-10-15 18:02 ` Andrew Lunn
2016-10-15 18:28 ` Timur Tabi
2016-10-17 9:05 ` Zefir Kurtisi
2016-10-17 20:53 ` Timur Tabi
2016-10-18 10:31 ` Zefir Kurtisi
2016-10-18 12:40 ` Timur Tabi
2016-10-19 8:55 ` Zefir Kurtisi
2016-10-19 12:16 ` Timur Tabi
2016-10-20 12:55 ` Zefir Kurtisi
2016-10-21 7:44 ` Zefir Kurtisi
2016-10-21 11:19 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014131852.GM5822@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.