From: Timur Tabi <timur@codeaurora.org>
To: Zefir Kurtisi <zefir.kurtisi@neratec.com>, Andrew Lunn <andrew@lunn.ch>
Cc: Florian Fainelli <f.fainelli@gmail.com>, netdev@vger.kernel.org
Subject: Re: Need help with mdiobus_register and phy
Date: Mon, 17 Oct 2016 15:53:07 -0500 [thread overview]
Message-ID: <58053A33.4030108@codeaurora.org> (raw)
In-Reply-To: <7dced72e-c441-06d1-161d-3bccad34f2cd@neratec.com>
Zefir Kurtisi wrote:
> Anyway, since the SGMII reset is required, instead of reverting the patch in full
> I suggest to move the SGMII power down from at803x_suspend() and do a SerDes power
> cycle in at803x_resume(). Could you please test if the patch below fixes the problem?
I have never seen the original problem that you noticed. When I use the
generic phy driver instead of the at803x driver, everything works great
for me. Perhaps the problem that you noticed only occurs with the
Gianfar NIC?
Anyway, I tested the change you suggested, and it fixes the problem for
me. I moved the power-down code to before the power-up code. But like
I said, since I never experienced the original problem, I don't know if
that works for you.
I suggest you make the changes in the driver yourself and test it, and
then I will test whether that patch also works for me.
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, hosted by The Linux Foundation.
next prev parent reply other threads:[~2016-10-17 20:53 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 23:15 Need help with mdiobus_register and phy Timur Tabi
2016-10-14 4:06 ` Andrew Lunn
2016-10-14 11:38 ` Timur Tabi
2016-10-14 12:06 ` Andrew Lunn
2016-10-14 12:39 ` Timur Tabi
2016-10-14 12:49 ` Andrew Lunn
2016-10-14 12:49 ` Timur Tabi
2016-10-14 12:57 ` Andrew Lunn
2016-10-14 13:03 ` Timur Tabi
2016-10-14 13:18 ` Andrew Lunn
2016-10-14 13:28 ` Timur Tabi
2016-10-14 16:57 ` Timur Tabi
2016-10-14 17:25 ` Andrew Lunn
2016-10-14 18:30 ` Timur Tabi
2016-10-15 10:19 ` Florian Fainelli
2016-10-15 14:39 ` Timur Tabi
2016-10-15 18:02 ` Andrew Lunn
2016-10-15 18:28 ` Timur Tabi
2016-10-17 9:05 ` Zefir Kurtisi
2016-10-17 20:53 ` Timur Tabi [this message]
2016-10-18 10:31 ` Zefir Kurtisi
2016-10-18 12:40 ` Timur Tabi
2016-10-19 8:55 ` Zefir Kurtisi
2016-10-19 12:16 ` Timur Tabi
2016-10-20 12:55 ` Zefir Kurtisi
2016-10-21 7:44 ` Zefir Kurtisi
2016-10-21 11:19 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58053A33.4030108@codeaurora.org \
--to=timur@codeaurora.org \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=zefir.kurtisi@neratec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.