From: Michal Hocko <mhocko@kernel.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Ming Ling <ming.ling@spreadtrum.com>,
akpm@linux-foundation.org, mgorman@techsingularity.net,
vbabka@suse.cz, hannes@cmpxchg.org,
baiyaowei@cmss.chinamobile.com, iamjoonsoo.kim@lge.com,
rientjes@google.com, hughd@google.com,
kirill.shutemov@linux.intel.com, riel@redhat.com,
mgorman@suse.de, aquini@redhat.com, corbet@lwn.net,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
orson.zhai@spreadtrum.com, geng.ren@spreadtrum.com,
chunyan.zhang@spreadtrum.com, zhizhou.tian@spreadtrum.com,
yuming.han@spreadtrum.com, xiajing@spreadst.com
Subject: Re: [PATCH v2] mm: exclude isolated non-lru pages from NR_ISOLATED_ANON or NR_ISOLATED_FILE.
Date: Fri, 14 Oct 2016 15:53:34 +0200 [thread overview]
Message-ID: <20161014135334.GF6063@dhcp22.suse.cz> (raw)
In-Reply-To: <20161014134604.GA2179@blaptop>
On Fri 14-10-16 22:46:04, Minchan Kim wrote:
[...]
> > > > Why don't you simply mimic what shrink_inactive_list does? Aka count the
> > > > number of isolated pages and then account them when appropriate?
> > > >
> > > I think i am correcting clearly wrong part. So, there is no need to
> > > describe it too detailed. It's a misunderstanding, and i will add
> > > more comments as you suggest.
> >
> > OK, so could you explain why you prefer to relyon __PageMovable rather
> > than do a trivial counting during the isolation?
>
> I don't get it. Could you elaborate it a bit more?
It is really simple. You can count the number of file and anonymous
pages while they are isolated and then account them to NR_ISOLATED_*
later. Basically the same thing we do during the reclaim. We absolutely
do not have to rely on __PageMovable and make this code more complex
than necessary.
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org>
To: Minchan Kim <minchan@kernel.org>
Cc: Ming Ling <ming.ling@spreadtrum.com>,
akpm@linux-foundation.org, mgorman@techsingularity.net,
vbabka@suse.cz, hannes@cmpxchg.org,
baiyaowei@cmss.chinamobile.com, iamjoonsoo.kim@lge.com,
rientjes@google.com, hughd@google.com,
kirill.shutemov@linux.intel.com, riel@redhat.com,
mgorman@suse.de, aquini@redhat.com, corbet@lwn.net,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
orson.zhai@spreadtrum.com, geng.ren@spreadtrum.com,
chunyan.zhang@spreadtrum.com, zhizhou.tian@spreadtrum.com,
yuming.han@spreadtrum.com, xiajing@spreadst.com
Subject: Re: [PATCH v2] mm: exclude isolated non-lru pages from NR_ISOLATED_ANON or NR_ISOLATED_FILE.
Date: Fri, 14 Oct 2016 15:53:34 +0200 [thread overview]
Message-ID: <20161014135334.GF6063@dhcp22.suse.cz> (raw)
In-Reply-To: <20161014134604.GA2179@blaptop>
On Fri 14-10-16 22:46:04, Minchan Kim wrote:
[...]
> > > > Why don't you simply mimic what shrink_inactive_list does? Aka count the
> > > > number of isolated pages and then account them when appropriate?
> > > >
> > > I think i am correcting clearly wrong part. So, there is no need to
> > > describe it too detailed. It's a misunderstanding, and i will add
> > > more comments as you suggest.
> >
> > OK, so could you explain why you prefer to relyon __PageMovable rather
> > than do a trivial counting during the isolation?
>
> I don't get it. Could you elaborate it a bit more?
It is really simple. You can count the number of file and anonymous
pages while they are isolated and then account them to NR_ISOLATED_*
later. Basically the same thing we do during the reclaim. We absolutely
do not have to rely on __PageMovable and make this code more complex
than necessary.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2016-10-14 13:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 6:39 [PATCH v2] mm: exclude isolated non-lru pages from NR_ISOLATED_ANON or NR_ISOLATED_FILE ming.ling
2016-10-13 6:39 ` ming.ling
2016-10-13 8:09 ` Michal Hocko
2016-10-13 8:09 ` Michal Hocko
2016-10-14 8:32 ` Ming Ling
2016-10-14 8:32 ` Ming Ling
2016-10-14 11:30 ` Michal Hocko
2016-10-14 11:30 ` Michal Hocko
2016-10-14 13:46 ` Minchan Kim
2016-10-14 13:46 ` Minchan Kim
2016-10-14 13:53 ` Michal Hocko [this message]
2016-10-14 13:53 ` Michal Hocko
2016-10-14 14:44 ` Minchan Kim
2016-10-14 14:44 ` Minchan Kim
2016-10-14 15:03 ` Michal Hocko
2016-10-14 15:03 ` Michal Hocko
2016-10-14 15:26 ` Minchan Kim
2016-10-14 15:26 ` Minchan Kim
2016-10-15 7:10 ` Michal Hocko
2016-10-15 7:10 ` Michal Hocko
2016-10-16 23:06 ` Minchan Kim
2016-10-16 23:06 ` Minchan Kim
2016-10-17 8:42 ` Michal Hocko
2016-10-17 8:42 ` Michal Hocko
2016-10-17 11:10 ` Michal Hocko
2016-10-17 11:10 ` Michal Hocko
2016-10-18 6:29 ` Minchan Kim
2016-10-18 6:29 ` Minchan Kim
2016-10-18 12:52 ` Michal Hocko
2016-10-18 12:52 ` Michal Hocko
2016-10-19 2:32 ` Ming Ling
2016-10-19 2:32 ` Ming Ling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161014135334.GF6063@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=baiyaowei@cmss.chinamobile.com \
--cc=chunyan.zhang@spreadtrum.com \
--cc=corbet@lwn.net \
--cc=geng.ren@spreadtrum.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mgorman@techsingularity.net \
--cc=minchan@kernel.org \
--cc=ming.ling@spreadtrum.com \
--cc=orson.zhai@spreadtrum.com \
--cc=riel@redhat.com \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=xiajing@spreadst.com \
--cc=yuming.han@spreadtrum.com \
--cc=zhizhou.tian@spreadtrum.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.