From: Dave Chinner <david@fromorbit.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
akpm@linux-foundation.org
Subject: Re: [PATCH] DAX: enable iostat for read/write
Date: Sat, 15 Oct 2016 18:54:43 +1100 [thread overview]
Message-ID: <20161015075443.GG27872@dastard> (raw)
In-Reply-To: <1476465913-25305-1-git-send-email-toshi.kani@hpe.com>
On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote:
> DAX IO path does not support iostat, but its metadata IO path does.
> Therefore, iostat shows metadata IO statistics only, which has been
> confusing to users.
>
> Add iostat support to the DAX read/write path.
>
> Note, iostat still does not support the DAX mmap path as it allows
> user applications to access directly.
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> fs/dax.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 014defd..3aaaac2 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -144,6 +144,34 @@ static sector_t to_sector(const struct buffer_head *bh,
> return sector;
> }
>
> +static void dax_iostat_start(struct gendisk *disk, struct iov_iter *iter,
> + unsigned long *start)
> +{
> + int rw = iov_iter_rw(iter);
> + int sec = iov_iter_count(iter) >> 9;
> + int cpu = part_stat_lock();
> +
> + *start = jiffies;
> + part_round_stats(cpu, &disk->part0);
> + part_stat_inc(cpu, &disk->part0, ios[rw]);
> + part_stat_add(cpu, &disk->part0, sectors[rw], sec);
> + part_inc_in_flight(&disk->part0, rw);
> + part_stat_unlock();
> +}
Why reimplement generic_start_io_acct() and generic_end_io_acct()?
-Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: akpm@linux-foundation.org, dan.j.williams@intel.com,
viro@zeniv.linux.org.uk, ross.zwisler@linux.intel.com,
linux-nvdimm@lists.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DAX: enable iostat for read/write
Date: Sat, 15 Oct 2016 18:54:43 +1100 [thread overview]
Message-ID: <20161015075443.GG27872@dastard> (raw)
In-Reply-To: <1476465913-25305-1-git-send-email-toshi.kani@hpe.com>
On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote:
> DAX IO path does not support iostat, but its metadata IO path does.
> Therefore, iostat shows metadata IO statistics only, which has been
> confusing to users.
>
> Add iostat support to the DAX read/write path.
>
> Note, iostat still does not support the DAX mmap path as it allows
> user applications to access directly.
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> fs/dax.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 014defd..3aaaac2 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -144,6 +144,34 @@ static sector_t to_sector(const struct buffer_head *bh,
> return sector;
> }
>
> +static void dax_iostat_start(struct gendisk *disk, struct iov_iter *iter,
> + unsigned long *start)
> +{
> + int rw = iov_iter_rw(iter);
> + int sec = iov_iter_count(iter) >> 9;
> + int cpu = part_stat_lock();
> +
> + *start = jiffies;
> + part_round_stats(cpu, &disk->part0);
> + part_stat_inc(cpu, &disk->part0, ios[rw]);
> + part_stat_add(cpu, &disk->part0, sectors[rw], sec);
> + part_inc_in_flight(&disk->part0, rw);
> + part_stat_unlock();
> +}
Why reimplement generic_start_io_acct() and generic_end_io_acct()?
-Dave.
--
Dave Chinner
david@fromorbit.com
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Toshi Kani <toshi.kani@hpe.com>
Cc: akpm@linux-foundation.org, dan.j.williams@intel.com,
viro@zeniv.linux.org.uk, ross.zwisler@linux.intel.com,
linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] DAX: enable iostat for read/write
Date: Sat, 15 Oct 2016 18:54:43 +1100 [thread overview]
Message-ID: <20161015075443.GG27872@dastard> (raw)
In-Reply-To: <1476465913-25305-1-git-send-email-toshi.kani@hpe.com>
On Fri, Oct 14, 2016 at 11:25:13AM -0600, Toshi Kani wrote:
> DAX IO path does not support iostat, but its metadata IO path does.
> Therefore, iostat shows metadata IO statistics only, which has been
> confusing to users.
>
> Add iostat support to the DAX read/write path.
>
> Note, iostat still does not support the DAX mmap path as it allows
> user applications to access directly.
>
> Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Ross Zwisler <ross.zwisler@linux.intel.com>
> ---
> fs/dax.c | 37 +++++++++++++++++++++++++++++++++++++
> 1 file changed, 37 insertions(+)
>
> diff --git a/fs/dax.c b/fs/dax.c
> index 014defd..3aaaac2 100644
> --- a/fs/dax.c
> +++ b/fs/dax.c
> @@ -144,6 +144,34 @@ static sector_t to_sector(const struct buffer_head *bh,
> return sector;
> }
>
> +static void dax_iostat_start(struct gendisk *disk, struct iov_iter *iter,
> + unsigned long *start)
> +{
> + int rw = iov_iter_rw(iter);
> + int sec = iov_iter_count(iter) >> 9;
> + int cpu = part_stat_lock();
> +
> + *start = jiffies;
> + part_round_stats(cpu, &disk->part0);
> + part_stat_inc(cpu, &disk->part0, ios[rw]);
> + part_stat_add(cpu, &disk->part0, sectors[rw], sec);
> + part_inc_in_flight(&disk->part0, rw);
> + part_stat_unlock();
> +}
Why reimplement generic_start_io_acct() and generic_end_io_acct()?
-Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2016-10-15 7:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 17:25 [PATCH] DAX: enable iostat for read/write Toshi Kani
2016-10-14 17:25 ` Toshi Kani
2016-10-14 17:25 ` Toshi Kani
2016-10-14 17:35 ` Dan Williams
2016-10-14 17:35 ` Dan Williams
2016-10-14 17:35 ` Dan Williams
2016-10-14 18:47 ` Kani, Toshimitsu
2016-10-14 18:47 ` Kani, Toshimitsu
2016-10-14 18:47 ` Kani, Toshimitsu
2016-10-15 7:54 ` Dave Chinner [this message]
2016-10-15 7:54 ` Dave Chinner
2016-10-15 7:54 ` Dave Chinner
2016-10-17 17:40 ` Kani, Toshimitsu
2016-10-17 17:40 ` Kani, Toshimitsu
2016-10-17 17:40 ` Kani, Toshimitsu
2016-10-17 18:55 ` Dan Williams
2016-10-17 18:55 ` Dan Williams
2016-10-17 18:55 ` Dan Williams
2016-10-17 19:12 ` Kani, Toshimitsu
2016-10-17 19:12 ` Kani, Toshimitsu
2016-10-17 19:12 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161015075443.GG27872@dastard \
--to=david@fromorbit.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=toshi.kani@hpe.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.