* [PATCH] Staging: greybus: uart: constify tty_port_operations structure
@ 2016-10-15 6:58 Bhumika Goyal
2016-10-15 7:01 ` [Outreachy kernel] " Julia Lawall
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bhumika Goyal @ 2016-10-15 6:58 UTC (permalink / raw)
To: outreachy-kernel, gregkh, dtwlin, johan, elder; +Cc: Bhumika Goyal
Declare tty_port_operations structure as const as it is only stored in
the ops field of a tty_port structure which is a field of a gb_tty
structure. The ops field is of type const struct tty_port_operations *,
so tty_port_operations structures having this property can be
declared as const.
Done using Coccinelle:
@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct tty_port_operations i@p = {...};
@ok1@
identifier r1.i;
position p;
struct gb_tty q;
@@
q.port.ops=&i@p
@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
static
+const
struct tty_port_operations i={...};
@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct tty_port_operations i;
File size before:
text data bss dec hex filename
7646 512 56 8214 2016 drivers/staging/greybus/uart.o
File size after:
text data bss dec hex filename
7710 448 56 8214 2016 drivers/staging/greybus/uart.o
Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
drivers/staging/greybus/uart.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 5ee7954..8162886 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -832,7 +832,7 @@ static void gb_tty_port_shutdown(struct tty_port *port)
.tiocmset = gb_tty_tiocmset,
};
-static struct tty_port_operations gb_port_ops = {
+static const struct tty_port_operations gb_port_ops = {
.dtr_rts = gb_tty_dtr_rts,
.activate = gb_tty_port_activate,
.shutdown = gb_tty_port_shutdown,
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Outreachy kernel] [PATCH] Staging: greybus: uart: constify tty_port_operations structure
2016-10-15 6:58 [PATCH] Staging: greybus: uart: constify tty_port_operations structure Bhumika Goyal
@ 2016-10-15 7:01 ` Julia Lawall
2016-10-15 9:21 ` Johan Hovold
2016-10-15 9:23 ` Johan Hovold
2 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2016-10-15 7:01 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: outreachy-kernel, gregkh, dtwlin, johan, elder
On Sat, 15 Oct 2016, Bhumika Goyal wrote:
> Declare tty_port_operations structure as const as it is only stored in
> the ops field of a tty_port structure which is a field of a gb_tty
> structure. The ops field is of type const struct tty_port_operations *,
> so tty_port_operations structures having this property can be
> declared as const.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct tty_port_operations i@p = {...};
>
> @ok1@
> identifier r1.i;
> position p;
> struct gb_tty q;
> @@
> q.port.ops=&i@p
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct tty_port_operations i={...};
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct tty_port_operations i;
>
> File size before:
> text data bss dec hex filename
> 7646 512 56 8214 2016 drivers/staging/greybus/uart.o
>
> File size after:
> text data bss dec hex filename
> 7710 448 56 8214 2016 drivers/staging/greybus/uart.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> drivers/staging/greybus/uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
> index 5ee7954..8162886 100644
> --- a/drivers/staging/greybus/uart.c
> +++ b/drivers/staging/greybus/uart.c
> @@ -832,7 +832,7 @@ static void gb_tty_port_shutdown(struct tty_port *port)
> .tiocmset = gb_tty_tiocmset,
> };
>
> -static struct tty_port_operations gb_port_ops = {
> +static const struct tty_port_operations gb_port_ops = {
> .dtr_rts = gb_tty_dtr_rts,
> .activate = gb_tty_port_activate,
> .shutdown = gb_tty_port_shutdown,
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1476514681-10619-1-git-send-email-bhumirks%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: greybus: uart: constify tty_port_operations structure
2016-10-15 6:58 [PATCH] Staging: greybus: uart: constify tty_port_operations structure Bhumika Goyal
2016-10-15 7:01 ` [Outreachy kernel] " Julia Lawall
@ 2016-10-15 9:21 ` Johan Hovold
2016-10-15 9:23 ` Johan Hovold
2 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2016-10-15 9:21 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: outreachy-kernel, gregkh, dtwlin, johan, elder
[ +CC: staging list ]
On Sat, Oct 15, 2016 at 12:28:01PM +0530, Bhumika Goyal wrote:
> Declare tty_port_operations structure as const as it is only stored in
> the ops field of a tty_port structure which is a field of a gb_tty
> structure. The ops field is of type const struct tty_port_operations *,
> so tty_port_operations structures having this property can be
> declared as const.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct tty_port_operations i@p = {...};
>
> @ok1@
> identifier r1.i;
> position p;
> struct gb_tty q;
> @@
> q.port.ops=&i@p
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct tty_port_operations i={...};
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct tty_port_operations i;
>
> File size before:
> text data bss dec hex filename
> 7646 512 56 8214 2016 drivers/staging/greybus/uart.o
>
> File size after:
> text data bss dec hex filename
> 7710 448 56 8214 2016 drivers/staging/greybus/uart.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/staging/greybus/uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
> index 5ee7954..8162886 100644
> --- a/drivers/staging/greybus/uart.c
> +++ b/drivers/staging/greybus/uart.c
> @@ -832,7 +832,7 @@ static void gb_tty_port_shutdown(struct tty_port *port)
> .tiocmset = gb_tty_tiocmset,
> };
>
> -static struct tty_port_operations gb_port_ops = {
> +static const struct tty_port_operations gb_port_ops = {
> .dtr_rts = gb_tty_dtr_rts,
> .activate = gb_tty_port_activate,
> .shutdown = gb_tty_port_shutdown,
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: greybus: uart: constify tty_port_operations structure
2016-10-15 6:58 [PATCH] Staging: greybus: uart: constify tty_port_operations structure Bhumika Goyal
2016-10-15 7:01 ` [Outreachy kernel] " Julia Lawall
2016-10-15 9:21 ` Johan Hovold
@ 2016-10-15 9:23 ` Johan Hovold
2 siblings, 0 replies; 4+ messages in thread
From: Johan Hovold @ 2016-10-15 9:23 UTC (permalink / raw)
To: Bhumika Goyal; +Cc: outreachy-kernel, gregkh, dtwlin, johan, elder, devel
[ +CC: staging list (for real this time) ]
On Sat, Oct 15, 2016 at 12:28:01PM +0530, Bhumika Goyal wrote:
> Declare tty_port_operations structure as const as it is only stored in
> the ops field of a tty_port structure which is a field of a gb_tty
> structure. The ops field is of type const struct tty_port_operations *,
> so tty_port_operations structures having this property can be
> declared as const.
> Done using Coccinelle:
>
> @r1 disable optional_qualifier @
> identifier i;
> position p;
> @@
> static struct tty_port_operations i@p = {...};
>
> @ok1@
> identifier r1.i;
> position p;
> struct gb_tty q;
> @@
> q.port.ops=&i@p
>
> @bad@
> position p!={r1.p,ok1.p};
> identifier r1.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> static
> +const
> struct tty_port_operations i={...};
>
> @depends on !bad disable optional_qualifier@
> identifier r1.i;
> @@
> +const
> struct tty_port_operations i;
>
> File size before:
> text data bss dec hex filename
> 7646 512 56 8214 2016 drivers/staging/greybus/uart.o
>
> File size after:
> text data bss dec hex filename
> 7710 448 56 8214 2016 drivers/staging/greybus/uart.o
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Acked-by: Johan Hovold <johan@kernel.org>
> ---
> drivers/staging/greybus/uart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
> index 5ee7954..8162886 100644
> --- a/drivers/staging/greybus/uart.c
> +++ b/drivers/staging/greybus/uart.c
> @@ -832,7 +832,7 @@ static void gb_tty_port_shutdown(struct tty_port *port)
> .tiocmset = gb_tty_tiocmset,
> };
>
> -static struct tty_port_operations gb_port_ops = {
> +static const struct tty_port_operations gb_port_ops = {
> .dtr_rts = gb_tty_dtr_rts,
> .activate = gb_tty_port_activate,
> .shutdown = gb_tty_port_shutdown,
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-15 9:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-15 6:58 [PATCH] Staging: greybus: uart: constify tty_port_operations structure Bhumika Goyal
2016-10-15 7:01 ` [Outreachy kernel] " Julia Lawall
2016-10-15 9:21 ` Johan Hovold
2016-10-15 9:23 ` Johan Hovold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.