All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/4] staging/vchi: Remove dependency on CONFIG_BROKEN.
Date: Sat, 15 Oct 2016 13:27:40 +0200	[thread overview]
Message-ID: <20161015112740.GB11674@kroah.com> (raw)
In-Reply-To: <886598225.386698.0cc5acd0-af27-4ef7-892f-3c2dd86176ba.open-xchange@email.1und1.de>

On Sat, Oct 15, 2016 at 10:35:25AM +0200, Stefan Wahren wrote:
> 
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> hat am 13. Oktober 2016 um
> > 09:05 geschrieben:
> > 
> > 
> > On Mon, Oct 03, 2016 at 11:52:09AM -0700, Eric Anholt wrote:
> > > The driver builds now.
> > > 
> > > Signed-off-by: Eric Anholt <eric@anholt.net>
> > > ---
> > >  drivers/staging/vc04_services/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/vc04_services/Kconfig
> > > b/drivers/staging/vc04_services/Kconfig
> > > index 9676fb29075a..db8e1beb89f9 100644
> > > --- a/drivers/staging/vc04_services/Kconfig
> > > +++ b/drivers/staging/vc04_services/Kconfig
> > > @@ -1,6 +1,6 @@
> > >  config BCM2708_VCHIQ
> > >  	tristate "Videocore VCHIQ"
> > > -	depends on RASPBERRYPI_FIRMWARE && BROKEN
> > > +	depends on RASPBERRYPI_FIRMWARE
> > >  	default y
> > >  	help
> > >  		Kernel to VideoCore communication interface for the
> > 
> > I've dropped this patch from my branch as there are build errors on
> > arm64 systems still, and we don't want regressions like that.
> > 
> > I've forwarded you the error messages, and I'll be glad to add this
> > patch back once these issues are fixed.
> 
> I ask the author of this downstream pull request [1] to send the VHCIQ part as
> indiviual patches.
> He is interested to submit them upstream.
> 
> [1] - https://github.com/raspberrypi/linux/pull/1611

Ok, but what does that mean for us here?  The code should be all now
merged into our "upstream" trees, it just needs to be cleaned up
properly.

confused,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stefan Wahren <stefan.wahren@i2se.com>
Cc: Eric Anholt <eric@anholt.net>,
	linux-kernel@vger.kernel.org,
	bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] staging/vchi: Remove dependency on CONFIG_BROKEN.
Date: Sat, 15 Oct 2016 13:27:40 +0200	[thread overview]
Message-ID: <20161015112740.GB11674@kroah.com> (raw)
In-Reply-To: <886598225.386698.0cc5acd0-af27-4ef7-892f-3c2dd86176ba.open-xchange@email.1und1.de>

On Sat, Oct 15, 2016 at 10:35:25AM +0200, Stefan Wahren wrote:
> 
> > Greg Kroah-Hartman <gregkh@linuxfoundation.org> hat am 13. Oktober 2016 um
> > 09:05 geschrieben:
> > 
> > 
> > On Mon, Oct 03, 2016 at 11:52:09AM -0700, Eric Anholt wrote:
> > > The driver builds now.
> > > 
> > > Signed-off-by: Eric Anholt <eric@anholt.net>
> > > ---
> > >  drivers/staging/vc04_services/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/staging/vc04_services/Kconfig
> > > b/drivers/staging/vc04_services/Kconfig
> > > index 9676fb29075a..db8e1beb89f9 100644
> > > --- a/drivers/staging/vc04_services/Kconfig
> > > +++ b/drivers/staging/vc04_services/Kconfig
> > > @@ -1,6 +1,6 @@
> > >  config BCM2708_VCHIQ
> > >  	tristate "Videocore VCHIQ"
> > > -	depends on RASPBERRYPI_FIRMWARE && BROKEN
> > > +	depends on RASPBERRYPI_FIRMWARE
> > >  	default y
> > >  	help
> > >  		Kernel to VideoCore communication interface for the
> > 
> > I've dropped this patch from my branch as there are build errors on
> > arm64 systems still, and we don't want regressions like that.
> > 
> > I've forwarded you the error messages, and I'll be glad to add this
> > patch back once these issues are fixed.
> 
> I ask the author of this downstream pull request [1] to send the VHCIQ part as
> indiviual patches.
> He is interested to submit them upstream.
> 
> [1] - https://github.com/raspberrypi/linux/pull/1611

Ok, but what does that mean for us here?  The code should be all now
merged into our "upstream" trees, it just needs to be cleaned up
properly.

confused,

greg k-h

  reply	other threads:[~2016-10-15 11:27 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-03 18:52 [PATCH 0/4] staging: Fix build of VCHIQ driver Eric Anholt
2016-10-03 18:52 ` Eric Anholt
2016-10-03 18:52 ` [PATCH 1/4] staging/vchi: Convert to current get_user_pages() arguments Eric Anholt
2016-10-03 18:52   ` Eric Anholt
2016-10-07 14:44   ` Greg Kroah-Hartman
2016-10-07 14:44     ` Greg Kroah-Hartman
2016-10-07 17:36     ` Eric Anholt
2016-10-07 17:36       ` Eric Anholt
2016-10-03 18:52 ` [PATCH 2/4] staging/vchi: Update for rename of page_cache_release() to put_page() Eric Anholt
2016-10-03 18:52   ` Eric Anholt
2016-10-03 18:52 ` [PATCH 3/4] ARM: bcm2835: Add #define for VCHIQ property message Eric Anholt
2016-10-03 18:52   ` Eric Anholt
2016-10-15  7:53   ` Stefan Wahren
2016-10-15  7:53     ` Stefan Wahren
2016-10-15  7:56     ` Stefan Wahren
2016-10-15  7:56       ` Stefan Wahren
2016-10-03 18:52 ` [PATCH 4/4] drivers/vchi: Remove dependency on CONFIG_BROKEN Eric Anholt
2016-10-03 18:52   ` Eric Anholt
2016-10-13  7:05   ` [PATCH 4/4] staging/vchi: " Greg Kroah-Hartman
2016-10-13  7:05     ` Greg Kroah-Hartman
2016-10-15  8:35     ` Stefan Wahren
2016-10-15  8:35       ` Stefan Wahren
2016-10-15 11:27       ` Greg Kroah-Hartman [this message]
2016-10-15 11:27         ` Greg Kroah-Hartman
2016-10-15 12:03         ` Stefan Wahren
2016-10-15 12:03           ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161015112740.GB11674@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.