All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] hwrng: meson: Fix module autoload for OF registration
@ 2016-10-17 19:40 ` Javier Martinez Canillas
  0 siblings, 0 replies; 17+ messages in thread
From: Javier Martinez Canillas @ 2016-10-17 19:40 UTC (permalink / raw)
  To: linus-amlogic

If the driver is built as a module, autoload won't work because the module
alias information is not filled. So user-space can't match the registered
device with the corresponding module.

Export the module alias information using the MODULE_DEVICE_TABLE() macro.

Before this patch:

$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias:          platform:meson-rng

After this patch:

$ modinfo drivers/char/hw_random/meson-rng.ko | grep alias
alias:          platform:meson-rng
alias:          of:N*T*Camlogic,meson-rngC*
alias:          of:N*T*Camlogic,meson-rng

Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---

 drivers/char/hw_random/meson-rng.c | 1 +
 drivers/char/tpm/Kconfig           | 2 +-
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/char/hw_random/meson-rng.c b/drivers/char/hw_random/meson-rng.c
index 58bef39f7286..51864a509be7 100644
--- a/drivers/char/hw_random/meson-rng.c
+++ b/drivers/char/hw_random/meson-rng.c
@@ -110,6 +110,7 @@ static const struct of_device_id meson_rng_of_match[] = {
 	{ .compatible = "amlogic,meson-rng", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, meson_rng_of_match);
 
 static struct platform_driver meson_rng_driver = {
 	.probe	= meson_rng_probe,
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 9faa0b1e7766..982ed2fe927c 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -32,7 +32,7 @@ config TCG_TIS_CORE
 
 config TCG_TIS
 	tristate "TPM Interface Specification 1.2 Interface / TPM 2.0 FIFO Interface"
-	depends on X86
+	depends on X86 || COMPILE_TEST
 	select TCG_TIS_CORE
 	---help---
 	  If you have a TPM security chip that is compliant with the
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2016-10-17 19:53 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-17 19:40 [PATCH] hwrng: meson: Fix module autoload for OF registration Javier Martinez Canillas
2016-10-17 19:40 ` Javier Martinez Canillas
2016-10-17 19:40 ` Javier Martinez Canillas
2016-10-17 19:45 ` Jason Gunthorpe
2016-10-17 19:45   ` Jason Gunthorpe
2016-10-17 19:45   ` Jason Gunthorpe
2016-10-17 19:45   ` Jason Gunthorpe
2016-10-17 19:47   ` Javier Martinez Canillas
2016-10-17 19:47     ` Javier Martinez Canillas
2016-10-17 19:47     ` Javier Martinez Canillas
2016-10-17 19:45 ` Fabio Estevam
2016-10-17 19:45   ` Fabio Estevam
2016-10-17 19:45   ` Fabio Estevam
2016-10-17 19:53   ` Javier Martinez Canillas
2016-10-17 19:53     ` Javier Martinez Canillas
2016-10-17 19:53     ` Javier Martinez Canillas
2016-10-17 19:53     ` Javier Martinez Canillas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.