All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: invtsc + migration + TSC scaling
Date: Mon, 17 Oct 2016 21:58:49 -0200	[thread overview]
Message-ID: <20161017235846.GA22657@amt.cnet> (raw)
In-Reply-To: <20161017211101.GD3275@thinpad.lan.raisama.net>

On Mon, Oct 17, 2016 at 07:11:01PM -0200, Eduardo Habkost wrote:
> On Mon, Oct 17, 2016 at 06:24:38PM +0200, Paolo Bonzini wrote:
> > On 17/10/2016 16:50, Radim Krčmář wrote:
> > > 2016-10-17 07:47-0200, Marcelo Tosatti:
> [...]
> > >> since Linux guests use kvmclock and Windows guests use Hyper-V
> > >> enlightenment, it should be fine to disable 2).
> > 
> > ... and 1 too.
> > 
> > We should also blacklist the TSC deadline timer when invtsc is not
> > available.

Actually, a nicer fix would be to check the different 
frequencies and scale the deadline relative to the difference. 

This would take care of both patched and non-patched guests.

On a related note, what was the goal of Radim's paravirtual deadline
TSC timer?

> You mean on the guest-side? On the host side, it would make
> existing VMs refuse to run.
> 
> -- 
> Eduardo

WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Tosatti <mtosatti@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] invtsc + migration + TSC scaling
Date: Mon, 17 Oct 2016 21:58:49 -0200	[thread overview]
Message-ID: <20161017235846.GA22657@amt.cnet> (raw)
In-Reply-To: <20161017211101.GD3275@thinpad.lan.raisama.net>

On Mon, Oct 17, 2016 at 07:11:01PM -0200, Eduardo Habkost wrote:
> On Mon, Oct 17, 2016 at 06:24:38PM +0200, Paolo Bonzini wrote:
> > On 17/10/2016 16:50, Radim Krčmář wrote:
> > > 2016-10-17 07:47-0200, Marcelo Tosatti:
> [...]
> > >> since Linux guests use kvmclock and Windows guests use Hyper-V
> > >> enlightenment, it should be fine to disable 2).
> > 
> > ... and 1 too.
> > 
> > We should also blacklist the TSC deadline timer when invtsc is not
> > available.

Actually, a nicer fix would be to check the different 
frequencies and scale the deadline relative to the difference. 

This would take care of both patched and non-patched guests.

On a related note, what was the goal of Radim's paravirtual deadline
TSC timer?

> You mean on the guest-side? On the host side, it would make
> existing VMs refuse to run.
> 
> -- 
> Eduardo

  reply	other threads:[~2016-10-17 23:59 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-14 21:20 invtsc + migration + TSC scaling Eduardo Habkost
2016-10-14 21:20 ` [Qemu-devel] " Eduardo Habkost
2016-10-17  9:47 ` Marcelo Tosatti
2016-10-17  9:47   ` [Qemu-devel] " Marcelo Tosatti
2016-10-17 14:50   ` Radim Krčmář
2016-10-17 14:50     ` [Qemu-devel] " Radim Krčmář
2016-10-17 16:24     ` Paolo Bonzini
2016-10-17 16:24       ` [Qemu-devel] " Paolo Bonzini
2016-10-17 21:11       ` Eduardo Habkost
2016-10-17 21:11         ` [Qemu-devel] " Eduardo Habkost
2016-10-17 23:58         ` Marcelo Tosatti [this message]
2016-10-17 23:58           ` Marcelo Tosatti
2016-10-18 13:41           ` Paolo Bonzini
2016-10-18 13:41             ` [Qemu-devel] " Paolo Bonzini
2016-10-18 17:09             ` Marcelo Tosatti
2016-10-18 17:09               ` [Qemu-devel] " Marcelo Tosatti
2016-10-18 20:52               ` Radim Krčmář
2016-10-18 20:52                 ` [Qemu-devel] " Radim Krčmář
2016-10-18 21:05                 ` Eduardo Habkost
2016-10-18 21:05                   ` [Qemu-devel] " Eduardo Habkost
2016-10-19 13:27                   ` Radim Krčmář
2016-10-19 13:27                     ` [Qemu-devel] " Radim Krčmář
2016-10-19 13:55                     ` Eduardo Habkost
2016-10-19 13:55                       ` [Qemu-devel] " Eduardo Habkost
2016-10-19 15:42                       ` Radim Krčmář
2016-10-19 15:42                         ` [Qemu-devel] " Radim Krčmář
2016-10-19 17:42                         ` Eduardo Habkost
2016-10-19 17:42                           ` [Qemu-devel] " Eduardo Habkost
2016-10-18 13:48           ` Radim Krčmář
2016-10-18 13:48             ` [Qemu-devel] " Radim Krčmář
2016-10-18 13:36       ` Radim Krčmář
2016-10-18 13:36         ` [Qemu-devel] " Radim Krčmář
2016-10-18 13:38         ` Radim Krčmář
2016-10-18 13:38           ` [Qemu-devel] " Radim Krčmář
2016-10-17 17:20     ` Marcelo Tosatti
2016-10-17 17:20       ` [Qemu-devel] " Marcelo Tosatti
2016-10-18 13:27       ` Radim Krčmář
2016-10-18 13:27         ` [Qemu-devel] " Radim Krčmář
2016-10-18  9:04     ` Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161017235846.GA22657@amt.cnet \
    --to=mtosatti@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.