From: Christoph Hellwig <hch@lst.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@linux-foundation.org, joelaf@google.com,
jszhang@marvell.com, joaodias@google.com, linux-mm@kvack.org,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] mm: mark all calls into the vmalloc subsystem as potentially sleeping
Date: Tue, 18 Oct 2016 12:38:37 +0200 [thread overview]
Message-ID: <20161018103837.GA8945@lst.de> (raw)
In-Reply-To: <20161018103359.GM29072@nuc-i3427.alporthouse.com>
On Tue, Oct 18, 2016 at 11:33:59AM +0100, Chris Wilson wrote:
> On Tue, Oct 18, 2016 at 08:56:07AM +0200, Christoph Hellwig wrote:
> > This is how everyone seems to already use them, but let's make that
> > explicit.
>
> mm/page_alloc.c: alloc_large_system_hash() is perhaps the exception to
> the rule.
While alloc_large_system_hash passes GFP_ATOMIC it still is called
from context where it can sleep - I think it just abuses GFP_ATOMIC
so that it gets an "early" failure. For which GFP_ATOMIC isn't
exactly a good choice as it dips into additional reserves, GFP_NOWAIT
would have probably been a better choice.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Christoph Hellwig <hch@lst.de>,
akpm@linux-foundation.org, joelaf@google.com,
jszhang@marvell.com, joaodias@google.com, linux-mm@kvack.org,
linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] mm: mark all calls into the vmalloc subsystem as potentially sleeping
Date: Tue, 18 Oct 2016 12:38:37 +0200 [thread overview]
Message-ID: <20161018103837.GA8945@lst.de> (raw)
In-Reply-To: <20161018103359.GM29072@nuc-i3427.alporthouse.com>
On Tue, Oct 18, 2016 at 11:33:59AM +0100, Chris Wilson wrote:
> On Tue, Oct 18, 2016 at 08:56:07AM +0200, Christoph Hellwig wrote:
> > This is how everyone seems to already use them, but let's make that
> > explicit.
>
> mm/page_alloc.c: alloc_large_system_hash() is perhaps the exception to
> the rule.
While alloc_large_system_hash passes GFP_ATOMIC it still is called
from context where it can sleep - I think it just abuses GFP_ATOMIC
so that it gets an "early" failure. For which GFP_ATOMIC isn't
exactly a good choice as it dips into additional reserves, GFP_NOWAIT
would have probably been a better choice.
next prev parent reply other threads:[~2016-10-18 10:38 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 6:56 [RFC] reduce latency in __purge_vmap_area_lazy Christoph Hellwig
2016-10-18 6:56 ` Christoph Hellwig
2016-10-18 6:56 ` [PATCH 1/6] mm: refactor __purge_vmap_area_lazy Christoph Hellwig
2016-10-18 6:56 ` Christoph Hellwig
2016-10-18 6:56 ` [PATCH 2/6] mm: mark all calls into the vmalloc subsystem as potentially sleeping Christoph Hellwig
2016-10-18 6:56 ` Christoph Hellwig
2016-10-18 10:33 ` Chris Wilson
2016-10-18 10:33 ` Chris Wilson
2016-10-18 10:38 ` Christoph Hellwig [this message]
2016-10-18 10:38 ` Christoph Hellwig
2016-10-19 11:15 ` Chris Wilson
2016-10-19 11:15 ` Chris Wilson
2016-10-19 13:05 ` Christoph Hellwig
2016-10-19 13:05 ` Christoph Hellwig
2016-10-19 15:34 ` Andy Lutomirski
2016-10-19 15:34 ` Andy Lutomirski
2016-10-19 16:31 ` Christoph Hellwig
2016-10-19 16:31 ` Christoph Hellwig
2016-10-19 19:43 ` Chris Wilson
2016-10-19 19:43 ` Chris Wilson
2016-10-21 0:32 ` Joel Fernandes
2016-10-21 0:32 ` Joel Fernandes
2016-11-08 13:24 ` Joel Fernandes
2016-11-08 13:24 ` Joel Fernandes
2016-11-08 14:32 ` Andrey Ryabinin
2016-11-08 14:32 ` Andrey Ryabinin
2016-10-18 6:56 ` [PATCH 3/6] mm: remove free_unmap_vmap_area_noflush Christoph Hellwig
2016-10-18 6:56 ` Christoph Hellwig
2016-10-18 6:56 ` [PATCH 4/6] mm: remove free_unmap_vmap_area_addr Christoph Hellwig
2016-10-18 6:56 ` Christoph Hellwig
2016-10-21 0:46 ` Joel Fernandes
2016-10-21 0:46 ` Joel Fernandes
2016-10-21 1:58 ` Nicholas Piggin
2016-10-21 1:58 ` Nicholas Piggin
2016-10-18 6:56 ` [PATCH 5/6] mm: turn vmap_purge_lock into a mutex Christoph Hellwig
2016-10-18 6:56 ` Christoph Hellwig
2016-10-18 6:56 ` [PATCH 6/6] mm: add preempt points into __purge_vmap_area_lazy Christoph Hellwig
2016-10-18 6:56 ` Christoph Hellwig
2016-10-18 20:56 ` Steven Rostedt
2016-10-18 20:56 ` Steven Rostedt
2016-10-18 21:01 ` Steven Rostedt
2016-10-18 21:01 ` Steven Rostedt
2016-10-18 10:40 ` [RFC] reduce latency in __purge_vmap_area_lazy Nicholas Piggin
2016-10-18 10:40 ` Nicholas Piggin
2016-10-18 11:21 ` Jisheng Zhang
2016-10-18 11:21 ` Jisheng Zhang
2016-10-18 11:21 ` Jisheng Zhang
2016-10-21 1:08 ` Joel Fernandes
2016-10-21 1:08 ` Joel Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161018103837.GA8945@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=chris@chris-wilson.co.uk \
--cc=joaodias@google.com \
--cc=joelaf@google.com \
--cc=jszhang@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-users@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.