* [PATCH] virtio-gpu: fix vblank events
@ 2016-10-13 11:55 ` Gerd Hoffmann
0 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2016-10-13 11:55 UTC (permalink / raw)
To: dri-devel
Cc: Marc-André Lureau, David Airlie, daniel.vetter,
Gerd Hoffmann, David Airlie, open list:VIRTIO GPU DRIVER,
open list
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and
because of that it must be called for disabled planes too. Ask
drm_atomic_helper_commit_planes to do that.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index 4e192aa..75ec172 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -338,7 +338,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
drm_atomic_helper_commit_modeset_disables(dev, state);
drm_atomic_helper_commit_modeset_enables(dev, state);
- drm_atomic_helper_commit_planes(dev, state, true);
+ drm_atomic_helper_commit_planes(dev, state, false);
drm_atomic_helper_commit_hw_done(state);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2] virtio-gpu: fix vblank events
2016-10-13 11:55 ` Gerd Hoffmann
(?)
@ 2016-10-18 14:27 ` Gustavo Padovan
2016-10-18 17:31 ` Gustavo Padovan
-1 siblings, 1 reply; 9+ messages in thread
From: Gustavo Padovan @ 2016-10-18 14:27 UTC (permalink / raw)
To: dri-devel; +Cc: Gustavo Padovan, Gerd Hoffmann
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and
because of that it must be called for disabled planes too. Ask
drm_atomic_helper_commit_planes to do that.
v2: update to use new drm_atomic_helper_commit_planes() API.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index 6848651..64facc8 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
drm_atomic_helper_commit_modeset_disables(dev, state);
drm_atomic_helper_commit_modeset_enables(dev, state);
- drm_atomic_helper_commit_planes(dev, state,
- DRM_PLANE_COMMIT_ACTIVE_ONLY);
+ drm_atomic_helper_commit_planes(dev, state, 0);
drm_atomic_helper_commit_hw_done(state);
--
2.5.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v2] virtio-gpu: fix vblank events
2016-10-18 14:27 ` [PATCH v2] " Gustavo Padovan
@ 2016-10-18 17:31 ` Gustavo Padovan
0 siblings, 0 replies; 9+ messages in thread
From: Gustavo Padovan @ 2016-10-18 17:31 UTC (permalink / raw)
To: dri-devel; +Cc: Gustavo Padovan, Gerd Hoffmann
2016-10-18 Gustavo Padovan <gustavo@padovan.org>:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Author info is wrong. It should be Gerd, I'll send another patch.
>
> virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and
> because of that it must be called for disabled planes too. Ask
> drm_atomic_helper_commit_planes to do that.
>
> v2: update to use new drm_atomic_helper_commit_planes() API.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
> drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> index 6848651..64facc8 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> @@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
>
> drm_atomic_helper_commit_modeset_disables(dev, state);
> drm_atomic_helper_commit_modeset_enables(dev, state);
> - drm_atomic_helper_commit_planes(dev, state,
> - DRM_PLANE_COMMIT_ACTIVE_ONLY);
> + drm_atomic_helper_commit_planes(dev, state, 0);
>
> drm_atomic_helper_commit_hw_done(state);
>
> --
> 2.5.5
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] virtio-gpu: fix vblank events
2016-10-13 11:55 ` Gerd Hoffmann
(?)
(?)
@ 2016-10-18 14:28 ` Gustavo Padovan
-1 siblings, 0 replies; 9+ messages in thread
From: Gustavo Padovan @ 2016-10-18 14:28 UTC (permalink / raw)
To: dri-devel; +Cc: Gerd Hoffmann
From: Gerd Hoffmann <kraxel@redhat.com>
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and
because of that it must be called for disabled planes too. Ask
drm_atomic_helper_commit_planes to do that.
v2: update to use new drm_atomic_helper_commit_planes() API.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index 6848651..64facc8 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
drm_atomic_helper_commit_modeset_disables(dev, state);
drm_atomic_helper_commit_modeset_enables(dev, state);
- drm_atomic_helper_commit_planes(dev, state,
- DRM_PLANE_COMMIT_ACTIVE_ONLY);
+ drm_atomic_helper_commit_planes(dev, state, 0);
drm_atomic_helper_commit_hw_done(state);
--
2.5.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH v2] virtio-gpu: fix vblank events
2016-10-13 11:55 ` Gerd Hoffmann
` (2 preceding siblings ...)
(?)
@ 2016-10-18 17:32 ` Gustavo Padovan
2016-11-02 22:00 ` Gustavo Padovan
-1 siblings, 1 reply; 9+ messages in thread
From: Gustavo Padovan @ 2016-10-18 17:32 UTC (permalink / raw)
To: dri-devel; +Cc: Gerd Hoffmann
From: Gerd Hoffmann <kraxel@redhat.com>
virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and
because of that it must be called for disabled planes too. Ask
drm_atomic_helper_commit_planes to do that.
v2: update to use new drm_atomic_helper_commit_planes() API.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
---
drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
index 6848651..64facc8 100644
--- a/drivers/gpu/drm/virtio/virtgpu_display.c
+++ b/drivers/gpu/drm/virtio/virtgpu_display.c
@@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
drm_atomic_helper_commit_modeset_disables(dev, state);
drm_atomic_helper_commit_modeset_enables(dev, state);
- drm_atomic_helper_commit_planes(dev, state,
- DRM_PLANE_COMMIT_ACTIVE_ONLY);
+ drm_atomic_helper_commit_planes(dev, state, 0);
drm_atomic_helper_commit_hw_done(state);
--
2.5.5
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] virtio-gpu: fix vblank events
2016-10-18 17:32 ` Gustavo Padovan
@ 2016-11-02 22:00 ` Gustavo Padovan
2016-11-03 8:35 ` Gerd Hoffmann
0 siblings, 1 reply; 9+ messages in thread
From: Gustavo Padovan @ 2016-11-02 22:00 UTC (permalink / raw)
To: dri-devel; +Cc: Dave Airlie, Gerd Hoffmann
ping
2016-10-18 Gustavo Padovan <gustavo@padovan.org>:
> From: Gerd Hoffmann <kraxel@redhat.com>
>
> virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and
> because of that it must be called for disabled planes too. Ask
> drm_atomic_helper_commit_planes to do that.
>
> v2: update to use new drm_atomic_helper_commit_planes() API.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> ---
> drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> index 6848651..64facc8 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> @@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
>
> drm_atomic_helper_commit_modeset_disables(dev, state);
> drm_atomic_helper_commit_modeset_enables(dev, state);
> - drm_atomic_helper_commit_planes(dev, state,
> - DRM_PLANE_COMMIT_ACTIVE_ONLY);
> + drm_atomic_helper_commit_planes(dev, state, 0);
>
> drm_atomic_helper_commit_hw_done(state);
>
> --
> 2.5.5
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] virtio-gpu: fix vblank events
2016-11-02 22:00 ` Gustavo Padovan
@ 2016-11-03 8:35 ` Gerd Hoffmann
2016-11-03 8:41 ` Gerd Hoffmann
0 siblings, 1 reply; 9+ messages in thread
From: Gerd Hoffmann @ 2016-11-03 8:35 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: Dave Airlie, dri-devel
Hi,
Dave, that is the only fix needed for for 4.9, can you pick it up
directly? Otherwise I can prepare a single-patch pull request with
it ...
thanks,
Gerd
On Mi, 2016-11-02 at 16:00 -0600, Gustavo Padovan wrote:
> ping
>
> 2016-10-18 Gustavo Padovan <gustavo@padovan.org>:
>
> > From: Gerd Hoffmann <kraxel@redhat.com>
> >
> > virtio-gpu sends vblank events in virtio_gpu_crtc_atomic_flush, and
> > because of that it must be called for disabled planes too. Ask
> > drm_atomic_helper_commit_planes to do that.
> >
> > v2: update to use new drm_atomic_helper_commit_planes() API.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > ---
> > drivers/gpu/drm/virtio/virtgpu_display.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/virtio/virtgpu_display.c b/drivers/gpu/drm/virtio/virtgpu_display.c
> > index 6848651..64facc8 100644
> > --- a/drivers/gpu/drm/virtio/virtgpu_display.c
> > +++ b/drivers/gpu/drm/virtio/virtgpu_display.c
> > @@ -340,8 +340,7 @@ static void vgdev_atomic_commit_tail(struct drm_atomic_state *state)
> >
> > drm_atomic_helper_commit_modeset_disables(dev, state);
> > drm_atomic_helper_commit_modeset_enables(dev, state);
> > - drm_atomic_helper_commit_planes(dev, state,
> > - DRM_PLANE_COMMIT_ACTIVE_ONLY);
> > + drm_atomic_helper_commit_planes(dev, state, 0);
> >
> > drm_atomic_helper_commit_hw_done(state);
> >
> > --
> > 2.5.5
> >
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] virtio-gpu: fix vblank events
2016-11-03 8:35 ` Gerd Hoffmann
@ 2016-11-03 8:41 ` Gerd Hoffmann
0 siblings, 0 replies; 9+ messages in thread
From: Gerd Hoffmann @ 2016-11-03 8:41 UTC (permalink / raw)
To: Gustavo Padovan; +Cc: Dave Airlie, dri-devel
On Do, 2016-11-03 at 09:35 +0100, Gerd Hoffmann wrote:
> Hi,
>
> Dave, that is the only fix needed for for 4.9, can you pick it up
> directly? Otherwise I can prepare a single-patch pull request with
> it ...
ok, scratch that, just saw this already is in the -rc4 fixes pull req.
cheers,
Gerd
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread