* [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
@ 2016-09-14 17:40 ` Eugeniy Paltsev
0 siblings, 0 replies; 10+ messages in thread
From: Eugeniy Paltsev @ 2016-09-14 17:40 UTC (permalink / raw)
To: linux-snps-arc
Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for
scatter-gather DMA mode") changes default "dmatest" behavior by
changing default mode from "memcpy" to "scatter-gather".
Now "memcpy" gets back as default mode.
Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
---
drivers/dma/dmatest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 53e9728..cf76fc6 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -56,10 +56,10 @@ module_param(sg_buffers, uint, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(sg_buffers,
"Number of scatter gather buffers (default: 1)");
-static unsigned int dmatest = 1;
+static unsigned int dmatest;
module_param(dmatest, uint, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(dmatest,
- "dmatest 0-memcpy 1-slave_sg (default: 1)");
+ "dmatest 0-memcpy 1-slave_sg (default: 0)");
static unsigned int xor_sources = 3;
module_param(xor_sources, uint, S_IRUGO | S_IWUSR);
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
@ 2016-09-14 17:40 ` Eugeniy Paltsev
0 siblings, 0 replies; 10+ messages in thread
From: Eugeniy Paltsev @ 2016-09-14 17:40 UTC (permalink / raw)
To: dmaengine
Cc: linux-kernel, appana.durga.rao, vinod.koul, dan.j.williams,
andriy.shevchenko, linux-snps-arc, Eugeniy Paltsev
Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for
scatter-gather DMA mode") changes default "dmatest" behavior by
changing default mode from "memcpy" to "scatter-gather".
Now "memcpy" gets back as default mode.
Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
---
drivers/dma/dmatest.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c
index 53e9728..cf76fc6 100644
--- a/drivers/dma/dmatest.c
+++ b/drivers/dma/dmatest.c
@@ -56,10 +56,10 @@ module_param(sg_buffers, uint, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(sg_buffers,
"Number of scatter gather buffers (default: 1)");
-static unsigned int dmatest = 1;
+static unsigned int dmatest;
module_param(dmatest, uint, S_IRUGO | S_IWUSR);
MODULE_PARM_DESC(dmatest,
- "dmatest 0-memcpy 1-slave_sg (default: 1)");
+ "dmatest 0-memcpy 1-slave_sg (default: 0)");
static unsigned int xor_sources = 3;
module_param(xor_sources, uint, S_IRUGO | S_IWUSR);
--
2.5.5
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
2016-09-14 17:40 ` Eugeniy Paltsev
@ 2016-09-15 3:24 ` Appana Durga Kedareswara Rao
-1 siblings, 0 replies; 10+ messages in thread
From: Appana Durga Kedareswara Rao @ 2016-09-15 3:24 UTC (permalink / raw)
To: linux-snps-arc
> -----Original Message-----
> From: Eugeniy Paltsev [mailto:Eugeniy.Paltsev at synopsys.com]
> Sent: Wednesday, September 14, 2016 11:11 PM
> To: dmaengine at vger.kernel.org
> Cc: linux-kernel at vger.kernel.org; Appana Durga Kedareswara Rao
> <appanad at xilinx.com>; vinod.koul at intel.com; dan.j.williams at intel.com;
> andriy.shevchenko at linux.intel.com; linux-snps-arc at lists.infradead.org; Eugeniy
> Paltsev <Eugeniy.Paltsev at synopsys.com>
> Subject: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
>
> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter-
> gather DMA mode") changes default "dmatest" behavior by changing default
> mode from "memcpy" to "scatter-gather".
> Now "memcpy" gets back as default mode.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>
Reviewed-by: Kedareswara rao Appana <appanad at xilinx.com>
Thanks,
Kedar.
> ---
> drivers/dma/dmatest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index
> 53e9728..cf76fc6 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -56,10 +56,10 @@ module_param(sg_buffers, uint, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(sg_buffers,
> "Number of scatter gather buffers (default: 1)");
>
> -static unsigned int dmatest = 1;
> +static unsigned int dmatest;
> module_param(dmatest, uint, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(dmatest,
> - "dmatest 0-memcpy 1-slave_sg (default: 1)");
> + "dmatest 0-memcpy 1-slave_sg (default: 0)");
>
> static unsigned int xor_sources = 3;
> module_param(xor_sources, uint, S_IRUGO | S_IWUSR);
> --
> 2.5.5
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
@ 2016-09-15 3:24 ` Appana Durga Kedareswara Rao
0 siblings, 0 replies; 10+ messages in thread
From: Appana Durga Kedareswara Rao @ 2016-09-15 3:24 UTC (permalink / raw)
To: Eugeniy Paltsev, dmaengine@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, vinod.koul@intel.com,
dan.j.williams@intel.com, andriy.shevchenko@linux.intel.com,
linux-snps-arc@lists.infradead.org
> -----Original Message-----
> From: Eugeniy Paltsev [mailto:Eugeniy.Paltsev@synopsys.com]
> Sent: Wednesday, September 14, 2016 11:11 PM
> To: dmaengine@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org; Appana Durga Kedareswara Rao
> <appanad@xilinx.com>; vinod.koul@intel.com; dan.j.williams@intel.com;
> andriy.shevchenko@linux.intel.com; linux-snps-arc@lists.infradead.org; Eugeniy
> Paltsev <Eugeniy.Paltsev@synopsys.com>
> Subject: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
>
> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter-
> gather DMA mode") changes default "dmatest" behavior by changing default
> mode from "memcpy" to "scatter-gather".
> Now "memcpy" gets back as default mode.
>
> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Reviewed-by: Kedareswara rao Appana <appanad@xilinx.com>
Thanks,
Kedar.
> ---
> drivers/dma/dmatest.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dmatest.c b/drivers/dma/dmatest.c index
> 53e9728..cf76fc6 100644
> --- a/drivers/dma/dmatest.c
> +++ b/drivers/dma/dmatest.c
> @@ -56,10 +56,10 @@ module_param(sg_buffers, uint, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(sg_buffers,
> "Number of scatter gather buffers (default: 1)");
>
> -static unsigned int dmatest = 1;
> +static unsigned int dmatest;
> module_param(dmatest, uint, S_IRUGO | S_IWUSR);
> MODULE_PARM_DESC(dmatest,
> - "dmatest 0-memcpy 1-slave_sg (default: 1)");
> + "dmatest 0-memcpy 1-slave_sg (default: 0)");
>
> static unsigned int xor_sources = 3;
> module_param(xor_sources, uint, S_IRUGO | S_IWUSR);
> --
> 2.5.5
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
2016-09-14 17:40 ` Eugeniy Paltsev
@ 2016-09-15 15:48 ` Vinod Koul
-1 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2016-09-15 15:48 UTC (permalink / raw)
To: linux-snps-arc
On Wed, Sep 14, 2016@08:40:38PM +0300, Eugeniy Paltsev wrote:
> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for
> scatter-gather DMA mode") changes default "dmatest" behavior by
> changing default mode from "memcpy" to "scatter-gather".
> Now "memcpy" gets back as default mode.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
@ 2016-09-15 15:48 ` Vinod Koul
0 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2016-09-15 15:48 UTC (permalink / raw)
To: Eugeniy Paltsev
Cc: dmaengine, linux-kernel, appana.durga.rao, dan.j.williams,
andriy.shevchenko, linux-snps-arc
On Wed, Sep 14, 2016 at 08:40:38PM +0300, Eugeniy Paltsev wrote:
> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for
> scatter-gather DMA mode") changes default "dmatest" behavior by
> changing default mode from "memcpy" to "scatter-gather".
> Now "memcpy" gets back as default mode.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
2016-09-15 15:48 ` Vinod Koul
@ 2016-10-18 18:14 ` Dave Jiang
-1 siblings, 0 replies; 10+ messages in thread
From: Dave Jiang @ 2016-10-18 18:14 UTC (permalink / raw)
To: linux-snps-arc
On 09/15/2016 08:48 AM, Vinod Koul wrote:
> On Wed, Sep 14, 2016@08:40:38PM +0300, Eugeniy Paltsev wrote:
>> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for
>> scatter-gather DMA mode") changes default "dmatest" behavior by
>> changing default mode from "memcpy" to "scatter-gather".
>> Now "memcpy" gets back as default mode.
>
> Applied, thanks
>
>
Did that go into stable? It's breaking the default expected behavior in
4.8 without the fix.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
@ 2016-10-18 18:14 ` Dave Jiang
0 siblings, 0 replies; 10+ messages in thread
From: Dave Jiang @ 2016-10-18 18:14 UTC (permalink / raw)
To: Vinod Koul, Eugeniy Paltsev
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
appana.durga.rao@xilinx.com, Williams, Dan J,
andriy.shevchenko@linux.intel.com,
linux-snps-arc@lists.infradead.org
On 09/15/2016 08:48 AM, Vinod Koul wrote:
> On Wed, Sep 14, 2016 at 08:40:38PM +0300, Eugeniy Paltsev wrote:
>> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for
>> scatter-gather DMA mode") changes default "dmatest" behavior by
>> changing default mode from "memcpy" to "scatter-gather".
>> Now "memcpy" gets back as default mode.
>
> Applied, thanks
>
>
Did that go into stable? It's breaking the default expected behavior in
4.8 without the fix.
^ permalink raw reply [flat|nested] 10+ messages in thread* [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
2016-10-18 18:14 ` Dave Jiang
@ 2016-10-19 3:34 ` Vinod Koul
-1 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2016-10-19 3:34 UTC (permalink / raw)
To: linux-snps-arc
On Tue, Oct 18, 2016@11:14:08AM -0700, Dave Jiang wrote:
> On 09/15/2016 08:48 AM, Vinod Koul wrote:
> > On Wed, Sep 14, 2016@08:40:38PM +0300, Eugeniy Paltsev wrote:
> >> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for
> >> scatter-gather DMA mode") changes default "dmatest" behavior by
> >> changing default mode from "memcpy" to "scatter-gather".
> >> Now "memcpy" gets back as default mode.
> >
> > Applied, thanks
>
> Did that go into stable? It's breaking the default expected behavior in
> 4.8 without the fix.
No it wasnt, and it should have...
I send to stable and lokks like it should applied on 4.7 and 4.8.
Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter-gather
DMA mode") came in 4.7 IIUC..
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode
@ 2016-10-19 3:34 ` Vinod Koul
0 siblings, 0 replies; 10+ messages in thread
From: Vinod Koul @ 2016-10-19 3:34 UTC (permalink / raw)
To: Dave Jiang
Cc: Eugeniy Paltsev, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org, appana.durga.rao@xilinx.com,
Williams, Dan J, andriy.shevchenko@linux.intel.com,
linux-snps-arc@lists.infradead.org
On Tue, Oct 18, 2016 at 11:14:08AM -0700, Dave Jiang wrote:
> On 09/15/2016 08:48 AM, Vinod Koul wrote:
> > On Wed, Sep 14, 2016 at 08:40:38PM +0300, Eugeniy Paltsev wrote:
> >> Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for
> >> scatter-gather DMA mode") changes default "dmatest" behavior by
> >> changing default mode from "memcpy" to "scatter-gather".
> >> Now "memcpy" gets back as default mode.
> >
> > Applied, thanks
>
> Did that go into stable? It's breaking the default expected behavior in
> 4.8 without the fix.
No it wasnt, and it should have...
I send to stable and lokks like it should applied on 4.7 and 4.8.
Commit 0d4cb44da6ca0e8 ("dmaengine: dmatest: Add support for scatter-gather
DMA mode") came in 4.7 IIUC..
Thanks
--
~Vinod
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-10-19 3:34 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-14 17:40 [PATCH] dmaengine: dmatest: Restore "memcpy" as default mode Eugeniy Paltsev
2016-09-14 17:40 ` Eugeniy Paltsev
2016-09-15 3:24 ` Appana Durga Kedareswara Rao
2016-09-15 3:24 ` Appana Durga Kedareswara Rao
2016-09-15 15:48 ` Vinod Koul
2016-09-15 15:48 ` Vinod Koul
2016-10-18 18:14 ` Dave Jiang
2016-10-18 18:14 ` Dave Jiang
2016-10-19 3:34 ` Vinod Koul
2016-10-19 3:34 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.