* [PATCH] nvmet-rdma: Fix REJ status code
@ 2016-10-18 19:59 Bart Van Assche
2016-10-19 10:34 ` Christoph Hellwig
2016-10-20 8:03 ` Sagi Grimberg
0 siblings, 2 replies; 3+ messages in thread
From: Bart Van Assche @ 2016-10-18 19:59 UTC (permalink / raw)
nvmet_sq_init() returns a value <= 0. nvmet_rdma_cm_reject() expects
a second argument that is a NVME_RDMA_CM_* constant. Hence this patch.
Signed-off-by: Bart Van Assche <bart.vanassche at sandisk.com>
---
drivers/nvme/target/rdma.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/nvme/target/rdma.c b/drivers/nvme/target/rdma.c
index f8d2399..35b97a8 100644
--- a/drivers/nvme/target/rdma.c
+++ b/drivers/nvme/target/rdma.c
@@ -1044,8 +1044,10 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev,
}
ret = nvmet_sq_init(&queue->nvme_sq);
- if (ret)
+ if (ret) {
+ ret = NVME_RDMA_CM_NO_RSC;
goto out_free_queue;
+ }
ret = nvmet_rdma_parse_cm_connect_req(&event->param.conn, queue);
if (ret)
@@ -1114,6 +1116,7 @@ nvmet_rdma_alloc_queue(struct nvmet_rdma_device *ndev,
out_free_queue:
kfree(queue);
out_reject:
+ pr_debug("rejecting connect request with status code %d\n", ret);
nvmet_rdma_cm_reject(cm_id, ret);
return NULL;
}
--
2.10.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] nvmet-rdma: Fix REJ status code
2016-10-18 19:59 [PATCH] nvmet-rdma: Fix REJ status code Bart Van Assche
@ 2016-10-19 10:34 ` Christoph Hellwig
2016-10-20 8:03 ` Sagi Grimberg
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2016-10-19 10:34 UTC (permalink / raw)
On Tue, Oct 18, 2016@12:59:47PM -0700, Bart Van Assche wrote:
> nvmet_sq_init() returns a value <= 0. nvmet_rdma_cm_reject() expects
> a second argument that is a NVME_RDMA_CM_* constant. Hence this patch.
>
> Signed-off-by: Bart Van Assche <bart.vanassche at sandisk.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch at lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] nvmet-rdma: Fix REJ status code
2016-10-18 19:59 [PATCH] nvmet-rdma: Fix REJ status code Bart Van Assche
2016-10-19 10:34 ` Christoph Hellwig
@ 2016-10-20 8:03 ` Sagi Grimberg
1 sibling, 0 replies; 3+ messages in thread
From: Sagi Grimberg @ 2016-10-20 8:03 UTC (permalink / raw)
Looks good,
Reviewed-by: Sagi Grimberg <sagi at grimbeg.me>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-10-20 8:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 19:59 [PATCH] nvmet-rdma: Fix REJ status code Bart Van Assche
2016-10-19 10:34 ` Christoph Hellwig
2016-10-20 8:03 ` Sagi Grimberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.