* [PATCH v4 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels @ 2016-10-04 15:29 ` Peter Rosin 0 siblings, 0 replies; 14+ messages in thread From: Peter Rosin @ 2016-10-04 15:29 UTC (permalink / raw) To: linux-kernel Cc: Peter Rosin, Thierry Reding, David Airlie, Rob Herring, Mark Rutland, dri-devel, devicetree Hi! New attempt to get this upstreamed. v4 addresses review comments from Rob (lvds -> sellvds and a couple of typos). Cheers, Peter Gustaf Lindström (1): drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin (1): dt-bindings: display: Add Sharp LQ150X1LG11 panel binding .../bindings/display/panel/sharp,lq150x1lg11.txt | 36 ++++++++++++++++++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++ 2 files changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt -- 2.1.4 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels @ 2016-10-04 15:29 ` Peter Rosin 0 siblings, 0 replies; 14+ messages in thread From: Peter Rosin @ 2016-10-04 15:29 UTC (permalink / raw) To: linux-kernel Cc: Peter Rosin, Thierry Reding, David Airlie, Rob Herring, Mark Rutland, dri-devel, devicetree Hi! New attempt to get this upstreamed. v4 addresses review comments from Rob (lvds -> sellvds and a couple of typos). Cheers, Peter Gustaf Lindström (1): drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin (1): dt-bindings: display: Add Sharp LQ150X1LG11 panel binding .../bindings/display/panel/sharp,lq150x1lg11.txt | 36 ++++++++++++++++++++++ drivers/gpu/drm/panel/panel-simple.c | 27 ++++++++++++++++ 2 files changed, 63 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt -- 2.1.4 ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH v4 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding 2016-10-04 15:29 ` Peter Rosin @ 2016-10-04 15:29 ` Peter Rosin -1 siblings, 0 replies; 14+ messages in thread From: Peter Rosin @ 2016-10-04 15:29 UTC (permalink / raw) To: linux-kernel Cc: Mark Rutland, devicetree, dri-devel, Rob Herring, Peter Rosin The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. Signed-off-by: Peter Rosin <peda@axentia.se> --- .../bindings/display/panel/sharp,lq150x1lg11.txt | 36 ++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt new file mode 100644 index 000000000000..0f57c3143506 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt @@ -0,0 +1,36 @@ +Sharp 15" LQ150X1LG11 XGA TFT LCD panel + +Required properties: +- compatible: should be "sharp,lq150x1lg11" +- power-supply: regulator to provide the VCC supply voltage (3.3 volts) + +Optional properties: +- backlight: phandle of the backlight device +- rlud-gpios: a single GPIO for the RL/UD (rotate 180 degrees) pin. +- sellvds-gpios: a single GPIO for the SELLVDS pin. + +If rlud-gpios and/or sellvds-gpios are not specified, the RL/UD and/or SELLVDS +pins are assumed to be handled appropriately by the hardware. + +Example: + + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm 0 100000>; /* VBR */ + + brightness-levels = <0 20 40 60 80 100>; + default-brightness-level = <2>; + + power-supply = <&vdd_12v_reg>; /* VDD */ + enable-gpios = <&gpio 42 GPIO_ACTIVE_HIGH>; /* XSTABY */ + }; + + panel { + compatible = "sharp,lq150x1lg11"; + + power-supply = <&vcc_3v3_reg>; /* VCC */ + + backlight = <&backlight>; + rlud-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>; /* RL/UD */ + sellvds-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>; /* SELLVDS */ + }; -- 2.1.4 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding @ 2016-10-04 15:29 ` Peter Rosin 0 siblings, 0 replies; 14+ messages in thread From: Peter Rosin @ 2016-10-04 15:29 UTC (permalink / raw) To: linux-kernel Cc: Peter Rosin, Thierry Reding, David Airlie, Rob Herring, Mark Rutland, dri-devel, devicetree The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. Signed-off-by: Peter Rosin <peda@axentia.se> --- .../bindings/display/panel/sharp,lq150x1lg11.txt | 36 ++++++++++++++++++++++ 1 file changed, 36 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt new file mode 100644 index 000000000000..0f57c3143506 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt @@ -0,0 +1,36 @@ +Sharp 15" LQ150X1LG11 XGA TFT LCD panel + +Required properties: +- compatible: should be "sharp,lq150x1lg11" +- power-supply: regulator to provide the VCC supply voltage (3.3 volts) + +Optional properties: +- backlight: phandle of the backlight device +- rlud-gpios: a single GPIO for the RL/UD (rotate 180 degrees) pin. +- sellvds-gpios: a single GPIO for the SELLVDS pin. + +If rlud-gpios and/or sellvds-gpios are not specified, the RL/UD and/or SELLVDS +pins are assumed to be handled appropriately by the hardware. + +Example: + + backlight: backlight { + compatible = "pwm-backlight"; + pwms = <&pwm 0 100000>; /* VBR */ + + brightness-levels = <0 20 40 60 80 100>; + default-brightness-level = <2>; + + power-supply = <&vdd_12v_reg>; /* VDD */ + enable-gpios = <&gpio 42 GPIO_ACTIVE_HIGH>; /* XSTABY */ + }; + + panel { + compatible = "sharp,lq150x1lg11"; + + power-supply = <&vcc_3v3_reg>; /* VCC */ + + backlight = <&backlight>; + rlud-gpios = <&gpio 17 GPIO_ACTIVE_HIGH>; /* RL/UD */ + sellvds-gpios = <&gpio 18 GPIO_ACTIVE_HIGH>; /* SELLVDS */ + }; -- 2.1.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding 2016-10-04 15:29 ` Peter Rosin @ 2016-10-09 1:29 ` Rob Herring -1 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2016-10-09 1:29 UTC (permalink / raw) To: Peter Rosin; +Cc: Mark Rutland, devicetree, linux-kernel, dri-devel On Tue, Oct 04, 2016 at 05:29:20PM +0200, Peter Rosin wrote: > The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > .../bindings/display/panel/sharp,lq150x1lg11.txt | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt Acked-by: Rob Herring <robh@kernel.org> _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding @ 2016-10-09 1:29 ` Rob Herring 0 siblings, 0 replies; 14+ messages in thread From: Rob Herring @ 2016-10-09 1:29 UTC (permalink / raw) To: Peter Rosin Cc: linux-kernel, Thierry Reding, David Airlie, Mark Rutland, dri-devel, devicetree On Tue, Oct 04, 2016 at 05:29:20PM +0200, Peter Rosin wrote: > The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. > > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > .../bindings/display/panel/sharp,lq150x1lg11.txt | 36 ++++++++++++++++++++++ > 1 file changed, 36 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq150x1lg11.txt Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <1475594961-5713-1-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>]
* [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels 2016-10-04 15:29 ` Peter Rosin @ 2016-10-04 15:29 ` Peter Rosin -1 siblings, 0 replies; 14+ messages in thread From: Peter Rosin @ 2016-10-04 15:29 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA Cc: Gustaf Lindström, Thierry Reding, David Airlie, Rob Herring, Mark Rutland, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, devicetree-u79uwXL29TY76Z2rM5mHXA, Peter Rosin From: Gustaf Lindström <gl-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. The simple-panel driver is used to get support for essential functionality of the panel. Signed-off-by: Gustaf Lindström <gl-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> Signed-off-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> --- drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1b9b31..58cfe0a7a9d6 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = { }, }; +static const struct drm_display_mode sharp_lq150x1lg11_mode = { + .clock = 71100, + .hdisplay = 1024, + .hsync_start = 1024 + 168, + .hsync_end = 1024 + 168 + 64, + .htotal = 1024 + 168 + 64 + 88, + .vdisplay = 768, + .vsync_start = 768 + 37, + .vsync_end = 768 + 37 + 2, + .vtotal = 768 + 37 + 2 + 8, + .vrefresh = 60, +}; + +static const struct panel_desc sharp_lq150x1lg11 = { + .modes = &sharp_lq150x1lg11_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 304, + .height = 228, + }, + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, +}; + static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = { .clock = 33300, .hdisplay = 800, @@ -1641,6 +1665,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "sharp,lq123p1jx31", .data = &sharp_lq123p1jx31, }, { + .compatible = "sharp,lq150x1lg11", + .data = &sharp_lq150x1lg11, + }, { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, }, { -- 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels @ 2016-10-04 15:29 ` Peter Rosin 0 siblings, 0 replies; 14+ messages in thread From: Peter Rosin @ 2016-10-04 15:29 UTC (permalink / raw) To: linux-kernel Cc: Gustaf Lindström, Thierry Reding, David Airlie, Rob Herring, Mark Rutland, dri-devel, devicetree, Peter Rosin From: Gustaf Lindström <gl@axentia.se> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. The simple-panel driver is used to get support for essential functionality of the panel. Signed-off-by: Gustaf Lindström <gl@axentia.se> Signed-off-by: Peter Rosin <peda@axentia.se> --- drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 85143d1b9b31..58cfe0a7a9d6 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = { }, }; +static const struct drm_display_mode sharp_lq150x1lg11_mode = { + .clock = 71100, + .hdisplay = 1024, + .hsync_start = 1024 + 168, + .hsync_end = 1024 + 168 + 64, + .htotal = 1024 + 168 + 64 + 88, + .vdisplay = 768, + .vsync_start = 768 + 37, + .vsync_end = 768 + 37 + 2, + .vtotal = 768 + 37 + 2 + 8, + .vrefresh = 60, +}; + +static const struct panel_desc sharp_lq150x1lg11 = { + .modes = &sharp_lq150x1lg11_mode, + .num_modes = 1, + .bpc = 8, + .size = { + .width = 304, + .height = 228, + }, + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, +}; + static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = { .clock = 33300, .hdisplay = 800, @@ -1641,6 +1665,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "sharp,lq123p1jx31", .data = &sharp_lq123p1jx31, }, { + .compatible = "sharp,lq150x1lg11", + .data = &sharp_lq150x1lg11, + }, { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, }, { -- 2.1.4 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels 2016-10-04 15:29 ` Peter Rosin @ 2016-10-19 12:27 ` Thierry Reding -1 siblings, 0 replies; 14+ messages in thread From: Thierry Reding @ 2016-10-19 12:27 UTC (permalink / raw) To: Peter Rosin Cc: Mark Rutland, devicetree, linux-kernel, dri-devel, Gustaf Lindström, Rob Herring [-- Attachment #1.1: Type: text/plain, Size: 1530 bytes --] On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote: > From: Gustaf Lindström <gl@axentia.se> > > The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. > > The simple-panel driver is used to get support for essential > functionality of the panel. > > Signed-off-by: Gustaf Lindström <gl@axentia.se> > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 85143d1b9b31..58cfe0a7a9d6 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = { > }, > }; > > +static const struct drm_display_mode sharp_lq150x1lg11_mode = { > + .clock = 71100, > + .hdisplay = 1024, > + .hsync_start = 1024 + 168, > + .hsync_end = 1024 + 168 + 64, > + .htotal = 1024 + 168 + 64 + 88, > + .vdisplay = 768, > + .vsync_start = 768 + 37, > + .vsync_end = 768 + 37 + 2, > + .vtotal = 768 + 37 + 2 + 8, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc sharp_lq150x1lg11 = { > + .modes = &sharp_lq150x1lg11_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 304, > + .height = 228, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for RGB565 panels. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels @ 2016-10-19 12:27 ` Thierry Reding 0 siblings, 0 replies; 14+ messages in thread From: Thierry Reding @ 2016-10-19 12:27 UTC (permalink / raw) To: Peter Rosin Cc: linux-kernel, Gustaf Lindström, David Airlie, Rob Herring, Mark Rutland, dri-devel, devicetree [-- Attachment #1: Type: text/plain, Size: 1530 bytes --] On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote: > From: Gustaf Lindström <gl@axentia.se> > > The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. > > The simple-panel driver is used to get support for essential > functionality of the panel. > > Signed-off-by: Gustaf Lindström <gl@axentia.se> > Signed-off-by: Peter Rosin <peda@axentia.se> > --- > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 85143d1b9b31..58cfe0a7a9d6 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = { > }, > }; > > +static const struct drm_display_mode sharp_lq150x1lg11_mode = { > + .clock = 71100, > + .hdisplay = 1024, > + .hsync_start = 1024 + 168, > + .hsync_end = 1024 + 168 + 64, > + .htotal = 1024 + 168 + 64 + 88, > + .vdisplay = 768, > + .vsync_start = 768 + 37, > + .vsync_end = 768 + 37 + 2, > + .vtotal = 768 + 37 + 2 + 8, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc sharp_lq150x1lg11 = { > + .modes = &sharp_lq150x1lg11_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 304, > + .height = 228, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for RGB565 panels. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels 2016-10-19 12:27 ` Thierry Reding @ 2016-10-19 12:31 ` Thierry Reding -1 siblings, 0 replies; 14+ messages in thread From: Thierry Reding @ 2016-10-19 12:31 UTC (permalink / raw) To: Peter Rosin Cc: Mark Rutland, devicetree, linux-kernel, dri-devel, Gustaf Lindström, Rob Herring [-- Attachment #1.1: Type: text/plain, Size: 2024 bytes --] On Wed, Oct 19, 2016 at 02:27:50PM +0200, Thierry Reding wrote: > On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote: > > From: Gustaf Lindström <gl@axentia.se> > > > > The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. > > > > The simple-panel driver is used to get support for essential > > functionality of the panel. > > > > Signed-off-by: Gustaf Lindström <gl@axentia.se> > > Signed-off-by: Peter Rosin <peda@axentia.se> > > --- > > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 85143d1b9b31..58cfe0a7a9d6 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = { > > }, > > }; > > > > +static const struct drm_display_mode sharp_lq150x1lg11_mode = { > > + .clock = 71100, > > + .hdisplay = 1024, > > + .hsync_start = 1024 + 168, > > + .hsync_end = 1024 + 168 + 64, > > + .htotal = 1024 + 168 + 64 + 88, > > + .vdisplay = 768, > > + .vsync_start = 768 + 37, > > + .vsync_end = 768 + 37 + 2, > > + .vtotal = 768 + 37 + 2 + 8, > > + .vrefresh = 60, > > +}; > > + > > +static const struct panel_desc sharp_lq150x1lg11 = { > > + .modes = &sharp_lq150x1lg11_mode, > > + .num_modes = 1, > > + .bpc = 8, > > + .size = { > > + .width = 304, > > + .height = 228, > > + }, > > + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, > > This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for > RGB565 panels. Are you actually using the .bpc field in your driver? If yes, can you please test if things work correctly if you set it to 6? If it's unused I'm leaning towards just applying this with .bpc set to 6 and hope for the best (and fix it if somebody finds that it's broken). So no need to resend, just let me know what you think. Thierry [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] [-- Attachment #2: Type: text/plain, Size: 160 bytes --] _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels @ 2016-10-19 12:31 ` Thierry Reding 0 siblings, 0 replies; 14+ messages in thread From: Thierry Reding @ 2016-10-19 12:31 UTC (permalink / raw) To: Peter Rosin Cc: linux-kernel, Gustaf Lindström, David Airlie, Rob Herring, Mark Rutland, dri-devel, devicetree [-- Attachment #1: Type: text/plain, Size: 2024 bytes --] On Wed, Oct 19, 2016 at 02:27:50PM +0200, Thierry Reding wrote: > On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote: > > From: Gustaf Lindström <gl@axentia.se> > > > > The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. > > > > The simple-panel driver is used to get support for essential > > functionality of the panel. > > > > Signed-off-by: Gustaf Lindström <gl@axentia.se> > > Signed-off-by: Peter Rosin <peda@axentia.se> > > --- > > drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 85143d1b9b31..58cfe0a7a9d6 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = { > > }, > > }; > > > > +static const struct drm_display_mode sharp_lq150x1lg11_mode = { > > + .clock = 71100, > > + .hdisplay = 1024, > > + .hsync_start = 1024 + 168, > > + .hsync_end = 1024 + 168 + 64, > > + .htotal = 1024 + 168 + 64 + 88, > > + .vdisplay = 768, > > + .vsync_start = 768 + 37, > > + .vsync_end = 768 + 37 + 2, > > + .vtotal = 768 + 37 + 2 + 8, > > + .vrefresh = 60, > > +}; > > + > > +static const struct panel_desc sharp_lq150x1lg11 = { > > + .modes = &sharp_lq150x1lg11_mode, > > + .num_modes = 1, > > + .bpc = 8, > > + .size = { > > + .width = 304, > > + .height = 228, > > + }, > > + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, > > This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for > RGB565 panels. Are you actually using the .bpc field in your driver? If yes, can you please test if things work correctly if you set it to 6? If it's unused I'm leaning towards just applying this with .bpc set to 6 and hope for the best (and fix it if somebody finds that it's broken). So no need to resend, just let me know what you think. Thierry [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 801 bytes --] ^ permalink raw reply [flat|nested] 14+ messages in thread
[parent not found: <20161019123153.GB16158-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>]
* Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels 2016-10-19 12:31 ` Thierry Reding @ 2016-10-28 12:18 ` Peter Rosin -1 siblings, 0 replies; 14+ messages in thread From: Peter Rosin @ 2016-10-28 12:18 UTC (permalink / raw) To: Thierry Reding Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, Gustaf Lindström, David Airlie, Rob Herring, Mark Rutland, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, devicetree-u79uwXL29TY76Z2rM5mHXA On 2016-10-19 14:31, Thierry Reding wrote: > On Wed, Oct 19, 2016 at 02:27:50PM +0200, Thierry Reding wrote: >> On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote: >>> From: Gustaf Lindström <gl-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> >>> >>> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. >>> >>> The simple-panel driver is used to get support for essential >>> functionality of the panel. >>> >>> Signed-off-by: Gustaf Lindström <gl-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> >>> Signed-off-by: Peter Rosin <peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org> >>> --- >>> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ >>> 1 file changed, 27 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >>> index 85143d1b9b31..58cfe0a7a9d6 100644 >>> --- a/drivers/gpu/drm/panel/panel-simple.c >>> +++ b/drivers/gpu/drm/panel/panel-simple.c >>> @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = { >>> }, >>> }; >>> >>> +static const struct drm_display_mode sharp_lq150x1lg11_mode = { >>> + .clock = 71100, >>> + .hdisplay = 1024, >>> + .hsync_start = 1024 + 168, >>> + .hsync_end = 1024 + 168 + 64, >>> + .htotal = 1024 + 168 + 64 + 88, >>> + .vdisplay = 768, >>> + .vsync_start = 768 + 37, >>> + .vsync_end = 768 + 37 + 2, >>> + .vtotal = 768 + 37 + 2 + 8, >>> + .vrefresh = 60, >>> +}; >>> + >>> +static const struct panel_desc sharp_lq150x1lg11 = { >>> + .modes = &sharp_lq150x1lg11_mode, >>> + .num_modes = 1, >>> + .bpc = 8, >>> + .size = { >>> + .width = 304, >>> + .height = 228, >>> + }, >>> + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, >> >> This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for >> RGB565 panels. > > Are you actually using the .bpc field in your driver? If yes, can you > please test if things work correctly if you set it to 6? If it's unused > I'm leaning towards just applying this with .bpc set to 6 and hope for > the best (and fix it if somebody finds that it's broken). > > So no need to resend, just let me know what you think. Sorry for the delay, but I just tested .bpc = 6 and it was ok too. It doesn't seem to matter for us, so do as you like. Cheers, Peter -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels @ 2016-10-28 12:18 ` Peter Rosin 0 siblings, 0 replies; 14+ messages in thread From: Peter Rosin @ 2016-10-28 12:18 UTC (permalink / raw) To: Thierry Reding Cc: linux-kernel, Gustaf Lindström, David Airlie, Rob Herring, Mark Rutland, dri-devel, devicetree On 2016-10-19 14:31, Thierry Reding wrote: > On Wed, Oct 19, 2016 at 02:27:50PM +0200, Thierry Reding wrote: >> On Tue, Oct 04, 2016 at 05:29:21PM +0200, Peter Rosin wrote: >>> From: Gustaf Lindström <gl@axentia.se> >>> >>> The Sharp 15" LQ150X1LG11 panel is an XGA TFT LCD panel. >>> >>> The simple-panel driver is used to get support for essential >>> functionality of the panel. >>> >>> Signed-off-by: Gustaf Lindström <gl@axentia.se> >>> Signed-off-by: Peter Rosin <peda@axentia.se> >>> --- >>> drivers/gpu/drm/panel/panel-simple.c | 27 +++++++++++++++++++++++++++ >>> 1 file changed, 27 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c >>> index 85143d1b9b31..58cfe0a7a9d6 100644 >>> --- a/drivers/gpu/drm/panel/panel-simple.c >>> +++ b/drivers/gpu/drm/panel/panel-simple.c >>> @@ -1386,6 +1386,30 @@ static const struct panel_desc sharp_lq123p1jx31 = { >>> }, >>> }; >>> >>> +static const struct drm_display_mode sharp_lq150x1lg11_mode = { >>> + .clock = 71100, >>> + .hdisplay = 1024, >>> + .hsync_start = 1024 + 168, >>> + .hsync_end = 1024 + 168 + 64, >>> + .htotal = 1024 + 168 + 64 + 88, >>> + .vdisplay = 768, >>> + .vsync_start = 768 + 37, >>> + .vsync_end = 768 + 37 + 2, >>> + .vtotal = 768 + 37 + 2 + 8, >>> + .vrefresh = 60, >>> +}; >>> + >>> +static const struct panel_desc sharp_lq150x1lg11 = { >>> + .modes = &sharp_lq150x1lg11_mode, >>> + .num_modes = 1, >>> + .bpc = 8, >>> + .size = { >>> + .width = 304, >>> + .height = 228, >>> + }, >>> + .bus_format = MEDIA_BUS_FMT_RGB565_1X16, >> >> This doesn't match the .bpc = 8 above. You'd usually use a .bpc = 6 for >> RGB565 panels. > > Are you actually using the .bpc field in your driver? If yes, can you > please test if things work correctly if you set it to 6? If it's unused > I'm leaning towards just applying this with .bpc set to 6 and hope for > the best (and fix it if somebody finds that it's broken). > > So no need to resend, just let me know what you think. Sorry for the delay, but I just tested .bpc = 6 and it was ok too. It doesn't seem to matter for us, so do as you like. Cheers, Peter ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2016-10-28 12:18 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-04 15:29 [PATCH v4 0/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin
2016-10-04 15:29 ` Peter Rosin
2016-10-04 15:29 ` [PATCH v4 1/2] dt-bindings: display: Add Sharp LQ150X1LG11 panel binding Peter Rosin
2016-10-04 15:29 ` Peter Rosin
2016-10-09 1:29 ` Rob Herring
2016-10-09 1:29 ` Rob Herring
[not found] ` <1475594961-5713-1-git-send-email-peda-koto5C5qi+TLoDKTGw+V6w@public.gmane.org>
2016-10-04 15:29 ` [PATCH v4 2/2] drm/panel: simple: add support for Sharp LQ150X1LG11 panels Peter Rosin
2016-10-04 15:29 ` Peter Rosin
2016-10-19 12:27 ` Thierry Reding
2016-10-19 12:27 ` Thierry Reding
2016-10-19 12:31 ` Thierry Reding
2016-10-19 12:31 ` Thierry Reding
[not found] ` <20161019123153.GB16158-EkSeR96xj6Pcmrwk2tT4+A@public.gmane.org>
2016-10-28 12:18 ` Peter Rosin
2016-10-28 12:18 ` Peter Rosin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.