From: Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Sarangdhar Joshi <spjoshi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Bjorn Andersson
<bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
David Brown <david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Catalin Marinas <catalin.marinas-5wv7dgnIgG8@public.gmane.org>,
Will Deacon <will.deacon-5wv7dgnIgG8@public.gmane.org>,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Trilok Soni <tsoni-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes
Date: Thu, 20 Oct 2016 16:51:37 -0500 [thread overview]
Message-ID: <20161020215137.GF3145@hector.attlocal.net> (raw)
In-Reply-To: <1c7504f2-48ca-bcae-3eef-16589513d1aa-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
> >On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> >
> >>From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >>
> >>Add SMEM and TCSR DT nodes on MSM8996.
> >>
> >>Signed-off-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >>Signed-off-by: Sarangdhar Joshi <spjoshi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> >>---
> >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
> >> 1 file changed, 19 insertions(+)
> >>
> >>diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>index 949b096..0a810f5 100644
> >>--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>@@ -169,12 +169,31 @@
> >> method = "smc";
> >> };
> >>
> >>+ smem {
> >>+ compatible = "qcom,smem";
> >>+
> >>+ memory-region = <&smem_mem>;
> >>+
> >>+ hwlocks = <&tcsr_mutex 3>;
> >>+ };
> >>+
> >> soc: soc {
> >> #address-cells = <1>;
> >> #size-cells = <1>;
> >> ranges = <0 0 0 0xffffffff>;
> >> compatible = "simple-bus";
> >>
> >>+ tcsr_mutex_regs: syscon@740000 {
> >>+ compatible = "syscon";
> >>+ reg = <0x740000 0x20000>;
> >>+ };
> >>+
> >>+ tcsr_mutex: hwlock {
> >>+ compatible = "qcom,tcsr-mutex";
> >>+ syscon = <&tcsr_mutex_regs 0 0x1000>;
> >>+ #hwlock-cells = <1>;
> >>+ };
> >
> >Sorry, I got this in the wrong place, the hwlock node should sit outside
> >of soc {} - looks like we got this wrong in msm8916 as well.
>
> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
> root)?
Yes. Any node that doesn't have reg properties should go under the root.
Andy
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: andy.gross@linaro.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes
Date: Thu, 20 Oct 2016 16:51:37 -0500 [thread overview]
Message-ID: <20161020215137.GF3145@hector.attlocal.net> (raw)
In-Reply-To: <1c7504f2-48ca-bcae-3eef-16589513d1aa@codeaurora.org>
On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
> >On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> >
> >>From: Bjorn Andersson <bjorn.andersson@linaro.org>
> >>
> >>Add SMEM and TCSR DT nodes on MSM8996.
> >>
> >>Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >>Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
> >>---
> >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
> >> 1 file changed, 19 insertions(+)
> >>
> >>diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>index 949b096..0a810f5 100644
> >>--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>@@ -169,12 +169,31 @@
> >> method = "smc";
> >> };
> >>
> >>+ smem {
> >>+ compatible = "qcom,smem";
> >>+
> >>+ memory-region = <&smem_mem>;
> >>+
> >>+ hwlocks = <&tcsr_mutex 3>;
> >>+ };
> >>+
> >> soc: soc {
> >> #address-cells = <1>;
> >> #size-cells = <1>;
> >> ranges = <0 0 0 0xffffffff>;
> >> compatible = "simple-bus";
> >>
> >>+ tcsr_mutex_regs: syscon at 740000 {
> >>+ compatible = "syscon";
> >>+ reg = <0x740000 0x20000>;
> >>+ };
> >>+
> >>+ tcsr_mutex: hwlock {
> >>+ compatible = "qcom,tcsr-mutex";
> >>+ syscon = <&tcsr_mutex_regs 0 0x1000>;
> >>+ #hwlock-cells = <1>;
> >>+ };
> >
> >Sorry, I got this in the wrong place, the hwlock node should sit outside
> >of soc {} - looks like we got this wrong in msm8916 as well.
>
> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
> root)?
Yes. Any node that doesn't have reg properties should go under the root.
Andy
WARNING: multiple messages have this Message-ID (diff)
From: Andy Gross <andy.gross@linaro.org>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
David Brown <david.brown@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Stephen Boyd <sboyd@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>
Subject: Re: [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes
Date: Thu, 20 Oct 2016 16:51:37 -0500 [thread overview]
Message-ID: <20161020215137.GF3145@hector.attlocal.net> (raw)
In-Reply-To: <1c7504f2-48ca-bcae-3eef-16589513d1aa@codeaurora.org>
On Thu, Oct 20, 2016 at 02:18:33PM -0700, Sarangdhar Joshi wrote:
> On 10/20/2016 12:56 PM, Bjorn Andersson wrote:
> >On Thu 20 Oct 11:56 PDT 2016, Sarangdhar Joshi wrote:
> >
> >>From: Bjorn Andersson <bjorn.andersson@linaro.org>
> >>
> >>Add SMEM and TCSR DT nodes on MSM8996.
> >>
> >>Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> >>Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
> >>---
> >> arch/arm64/boot/dts/qcom/msm8996.dtsi | 19 +++++++++++++++++++
> >> 1 file changed, 19 insertions(+)
> >>
> >>diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>index 949b096..0a810f5 100644
> >>--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> >>@@ -169,12 +169,31 @@
> >> method = "smc";
> >> };
> >>
> >>+ smem {
> >>+ compatible = "qcom,smem";
> >>+
> >>+ memory-region = <&smem_mem>;
> >>+
> >>+ hwlocks = <&tcsr_mutex 3>;
> >>+ };
> >>+
> >> soc: soc {
> >> #address-cells = <1>;
> >> #size-cells = <1>;
> >> ranges = <0 0 0 0xffffffff>;
> >> compatible = "simple-bus";
> >>
> >>+ tcsr_mutex_regs: syscon@740000 {
> >>+ compatible = "syscon";
> >>+ reg = <0x740000 0x20000>;
> >>+ };
> >>+
> >>+ tcsr_mutex: hwlock {
> >>+ compatible = "qcom,tcsr-mutex";
> >>+ syscon = <&tcsr_mutex_regs 0 0x1000>;
> >>+ #hwlock-cells = <1>;
> >>+ };
> >
> >Sorry, I got this in the wrong place, the hwlock node should sit outside
> >of soc {} - looks like we got this wrong in msm8916 as well.
>
> Thanks for reviewing the patch. Do you mean to move it under / {}; (i.e.
> root)?
Yes. Any node that doesn't have reg properties should go under the root.
Andy
next prev parent reply other threads:[~2016-10-20 21:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 18:56 [PATCH 1/4] arm64: dts: msm8996: Add SMEM reserve-memory node Sarangdhar Joshi
2016-10-20 18:56 ` Sarangdhar Joshi
2016-10-20 18:56 ` [PATCH 2/4] arm64: dts: msm8996: Add reserve-memory nodes Sarangdhar Joshi
2016-10-20 18:56 ` Sarangdhar Joshi
2016-10-20 19:57 ` Bjorn Andersson
2016-10-20 19:57 ` Bjorn Andersson
2016-10-20 21:17 ` Sarangdhar Joshi
2016-10-20 21:17 ` Sarangdhar Joshi
2016-10-20 21:17 ` Sarangdhar Joshi
[not found] ` <1476989765-7524-1-git-send-email-spjoshi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-10-20 18:56 ` [PATCH 3/4] arm64: dts: msm8996: Add SMEM DT nodes Sarangdhar Joshi
2016-10-20 18:56 ` Sarangdhar Joshi
2016-10-20 18:56 ` Sarangdhar Joshi
[not found] ` <1476989765-7524-3-git-send-email-spjoshi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-10-20 19:56 ` Bjorn Andersson
2016-10-20 19:56 ` Bjorn Andersson
2016-10-20 19:56 ` Bjorn Andersson
2016-10-20 21:18 ` Sarangdhar Joshi
2016-10-20 21:18 ` Sarangdhar Joshi
[not found] ` <1c7504f2-48ca-bcae-3eef-16589513d1aa-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-10-20 21:51 ` Andy Gross [this message]
2016-10-20 21:51 ` Andy Gross
2016-10-20 21:51 ` Andy Gross
2016-10-20 21:59 ` Sarangdhar Joshi
2016-10-20 21:59 ` Sarangdhar Joshi
2016-10-20 18:56 ` [PATCH 4/4] arm64: dts: msm8996: Add SMP2P and APCS nodes Sarangdhar Joshi
2016-10-20 18:56 ` Sarangdhar Joshi
2016-10-20 18:56 ` Sarangdhar Joshi
2016-10-20 20:03 ` Bjorn Andersson
2016-10-20 20:03 ` Bjorn Andersson
2016-10-20 21:22 ` Sarangdhar Joshi
2016-10-20 21:22 ` Sarangdhar Joshi
2016-10-20 19:57 ` [PATCH 1/4] arm64: dts: msm8996: Add SMEM reserve-memory node Bjorn Andersson
2016-10-20 19:57 ` Bjorn Andersson
2016-10-20 21:16 ` Sarangdhar Joshi
2016-10-20 21:16 ` Sarangdhar Joshi
2016-10-20 21:16 ` Sarangdhar Joshi
[not found] ` <4ca66e5d-c235-435b-c966-49a0e0722b8e-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-10-20 21:53 ` Andy Gross
2016-10-20 21:53 ` Andy Gross
2016-10-20 21:53 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020215137.GF3145@hector.attlocal.net \
--to=andy.gross-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=catalin.marinas-5wv7dgnIgG8@public.gmane.org \
--cc=david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=spjoshi-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=tsoni-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=will.deacon-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.