From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/5] ARM: dts: imx6qdl-icore: Add usbhost support
Date: Fri, 21 Oct 2016 09:21:37 +0800 [thread overview]
Message-ID: <20161021012137.GC30578@tiger> (raw)
In-Reply-To: <1476437243-13297-4-git-send-email-jteki@openedev.com>
On Fri, Oct 14, 2016 at 02:57:21PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> Add usbhost support for Engicam i.CoreM6 dql modules.
>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v7:
> - none
> Changes for v6:
> - none
> Changes for v5:
> - none
> Changes for v4:
> - new patch
>
> arch/arm/boot/dts/imx6qdl-icore.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> index f424cd5..ffec879 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> @@ -56,6 +56,15 @@
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + reg_usb_h1_vbus: usb_h1_vbus {
Hyphen instead of underscore should be used in node name. Also please
name fixed regulator in the following schema:
reg_xxx: regulator-xxx {
...
};
Shawn
> + compatible = "regulator-fixed";
> + regulator-name = "usb_h1_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> };
>
> &can1 {
> @@ -109,6 +118,12 @@
> status = "okay";
> };
>
> +&usbh1 {
> + vbus-supply = <®_usb_h1_vbus>;
> + disable-over-current;
> + status = "okay";
> +};
> +
> &usdhc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usdhc1>;
> --
> 2.7.4
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Jagan Teki <jteki@openedev.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Matteo Lisi <matteo.lisi@engicam.com>,
Michael Trimarchi <michael@amarulasolutions.com>,
Jagan Teki <jagan@amarulasolutions.com>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH v7 3/5] ARM: dts: imx6qdl-icore: Add usbhost support
Date: Fri, 21 Oct 2016 09:21:37 +0800 [thread overview]
Message-ID: <20161021012137.GC30578@tiger> (raw)
In-Reply-To: <1476437243-13297-4-git-send-email-jteki@openedev.com>
On Fri, Oct 14, 2016 at 02:57:21PM +0530, Jagan Teki wrote:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> Add usbhost support for Engicam i.CoreM6 dql modules.
>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
> Changes for v7:
> - none
> Changes for v6:
> - none
> Changes for v5:
> - none
> Changes for v4:
> - new patch
>
> arch/arm/boot/dts/imx6qdl-icore.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> index f424cd5..ffec879 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
> @@ -56,6 +56,15 @@
> regulator-boot-on;
> regulator-always-on;
> };
> +
> + reg_usb_h1_vbus: usb_h1_vbus {
Hyphen instead of underscore should be used in node name. Also please
name fixed regulator in the following schema:
reg_xxx: regulator-xxx {
...
};
Shawn
> + compatible = "regulator-fixed";
> + regulator-name = "usb_h1_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + regulator-boot-on;
> + regulator-always-on;
> + };
> };
>
> &can1 {
> @@ -109,6 +118,12 @@
> status = "okay";
> };
>
> +&usbh1 {
> + vbus-supply = <®_usb_h1_vbus>;
> + disable-over-current;
> + status = "okay";
> +};
> +
> &usdhc1 {
> pinctrl-names = "default";
> pinctrl-0 = <&pinctrl_usdhc1>;
> --
> 2.7.4
>
next prev parent reply other threads:[~2016-10-21 1:21 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-14 9:27 [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-14 9:27 ` [PATCH v7 1/5] ARM: dts: imx6q: Add Engicam i.CoreM6 Quad/Dual initial support Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-14 9:27 ` [PATCH v7 2/5] ARM: dts: imx6q: Add Engicam i.CoreM6 DualLite/Solo " Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-14 9:27 ` [PATCH v7 3/5] ARM: dts: imx6qdl-icore: Add usbhost support Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-21 1:21 ` Shawn Guo [this message]
2016-10-21 1:21 ` Shawn Guo
2016-10-14 9:27 ` [PATCH v7 4/5] ARM: dts: imx6qdl-icore: Add usbotg support Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-21 1:25 ` Shawn Guo
2016-10-21 1:25 ` Shawn Guo
2016-10-21 1:25 ` Shawn Guo
2016-10-14 9:27 ` [PATCH v7 5/5] ARM: dts: imx6qdl-icore: Add FEC support Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-14 9:27 ` Jagan Teki
2016-10-21 1:31 ` Shawn Guo
2016-10-21 1:31 ` Shawn Guo
2016-10-18 12:00 ` [PATCH v7 0/5] ARM: dts: imx6q: Add Engicam i.CoreM6 dts Jagan Teki
2016-10-18 12:00 ` Jagan Teki
2016-10-18 12:00 ` Jagan Teki
2016-10-21 1:35 ` Shawn Guo
2016-10-21 1:35 ` Shawn Guo
2016-10-21 7:55 ` Jagan Teki
2016-10-21 7:55 ` Jagan Teki
2016-10-21 7:55 ` Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021012137.GC30578@tiger \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.