From: Dan Carpenter <dan.carpenter@oracle.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
David Airlie <airlied@linux.ie>, Zhi Wang <zhi.a.wang@intel.com>,
Yulei Zhang <yulei.zhang@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/i915/gvt: cleanup a type issue in submit_context()
Date: Fri, 21 Oct 2016 10:27:22 +0000 [thread overview]
Message-ID: <20161021102722.GT4469@mwanda> (raw)
In-Reply-To: <20161021082738.2va437v2qzsf7inq@zhen-hp.sh.intel.com>
On Fri, Oct 21, 2016 at 04:27:38PM +0800, Zhenyu Wang wrote:
> On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote:
> > submit_context() should return negative error codes and zero on success
> > but by mistake we made it a bool. I've changed it to int. Also I made
> > it static because this isn't referenced in any other files.
> >
> > This doesn't affect runtime because the return is eventually propogated
> > to elsp_mmio_write() where it is ignored.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c
> > index c50a3d1a5131..bc69ba1842ea 100644
> > --- a/drivers/gpu/drm/i915/gvt/execlist.c
> > +++ b/drivers/gpu/drm/i915/gvt/execlist.c
> > @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload)
> > (list_empty(q) ? NULL : container_of(q->prev, \
> > struct intel_vgpu_workload, list))
> >
> > -bool submit_context(struct intel_vgpu *vgpu, int ring_id,
> > +static int submit_context(struct intel_vgpu *vgpu, int ring_id,
> > struct execlist_ctx_descriptor_format *desc,
> > bool emulate_schedule_in)
> > {
>
> Dan, this has been fixed in our recent pull, should hit linux-next very soon.
>
Could you review elsp_mmio_write() as well? Should we be doing
something with that return value?
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Zhenyu Wang <zhenyuw@linux.intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Jani Nikula <jani.nikula@linux.intel.com>,
David Airlie <airlied@linux.ie>, Zhi Wang <zhi.a.wang@intel.com>,
Yulei Zhang <yulei.zhang@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch] drm/i915/gvt: cleanup a type issue in submit_context()
Date: Fri, 21 Oct 2016 13:27:22 +0300 [thread overview]
Message-ID: <20161021102722.GT4469@mwanda> (raw)
In-Reply-To: <20161021082738.2va437v2qzsf7inq@zhen-hp.sh.intel.com>
On Fri, Oct 21, 2016 at 04:27:38PM +0800, Zhenyu Wang wrote:
> On 2016.10.21 11:06:01 +0300, Dan Carpenter wrote:
> > submit_context() should return negative error codes and zero on success
> > but by mistake we made it a bool. I've changed it to int. Also I made
> > it static because this isn't referenced in any other files.
> >
> > This doesn't affect runtime because the return is eventually propogated
> > to elsp_mmio_write() where it is ignored.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/gpu/drm/i915/gvt/execlist.c b/drivers/gpu/drm/i915/gvt/execlist.c
> > index c50a3d1a5131..bc69ba1842ea 100644
> > --- a/drivers/gpu/drm/i915/gvt/execlist.c
> > +++ b/drivers/gpu/drm/i915/gvt/execlist.c
> > @@ -616,7 +616,7 @@ static int prepare_mm(struct intel_vgpu_workload *workload)
> > (list_empty(q) ? NULL : container_of(q->prev, \
> > struct intel_vgpu_workload, list))
> >
> > -bool submit_context(struct intel_vgpu *vgpu, int ring_id,
> > +static int submit_context(struct intel_vgpu *vgpu, int ring_id,
> > struct execlist_ctx_descriptor_format *desc,
> > bool emulate_schedule_in)
> > {
>
> Dan, this has been fixed in our recent pull, should hit linux-next very soon.
>
Could you review elsp_mmio_write() as well? Should we be doing
something with that return value?
regards,
dan carpenter
next prev parent reply other threads:[~2016-10-21 10:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 8:06 [patch] drm/i915/gvt: cleanup a type issue in submit_context() Dan Carpenter
2016-10-21 8:06 ` Dan Carpenter
2016-10-21 8:27 ` Zhenyu Wang
2016-10-21 8:27 ` Zhenyu Wang
2016-10-21 10:27 ` Dan Carpenter [this message]
2016-10-21 10:27 ` Dan Carpenter
2016-10-21 12:27 ` Zhenyu Wang
2016-10-21 12:27 ` Zhenyu Wang
2016-10-21 8:33 ` [Intel-gfx] " Chris Wilson
2016-10-21 8:33 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021102722.GT4469@mwanda \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=yulei.zhang@intel.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.