From: Daniel Vetter <daniel@ffwll.ch>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: marcheu@google.com, Daniel Stone <daniels@collabora.com>,
seanpaul@google.com, Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
m.chehab@samsung.com,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>,
John Harrison <John.C.Harrison@Intel.com>,
laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v5 2/4] drm/fence: release fence reference when canceling event
Date: Fri, 21 Oct 2016 14:52:37 +0200 [thread overview]
Message-ID: <20161021125237.GD20761@phenom.ffwll.local> (raw)
In-Reply-To: <1476975005-30441-3-git-send-email-gustavo@padovan.org>
On Thu, Oct 20, 2016 at 12:50:03PM -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> If the event gets canceled we also need to put away the fence
> reference it holds.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I've broken my local dim scripts right now, so can't apply ;-)
-Daniel
> ---
> drivers/gpu/drm/drm_fops.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fops.c b/drivers/gpu/drm/drm_fops.c
> index e84faec..8bed5f4 100644
> --- a/drivers/gpu/drm/drm_fops.c
> +++ b/drivers/gpu/drm/drm_fops.c
> @@ -663,6 +663,10 @@ void drm_event_cancel_free(struct drm_device *dev,
> list_del(&p->pending_link);
> }
> spin_unlock_irqrestore(&dev->event_lock, flags);
> +
> + if (p->fence)
> + fence_put(p->fence);
> +
> kfree(p);
> }
> EXPORT_SYMBOL(drm_event_cancel_free);
> --
> 2.5.5
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Daniel Vetter <daniel@ffwll.ch>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Daniel Stone <daniels@collabora.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Rob Clark <robdclark@gmail.com>,
Greg Hackmann <ghackmann@google.com>,
John Harrison <John.C.Harrison@Intel.com>,
laurent.pinchart@ideasonboard.com, seanpaul@google.com,
marcheu@google.com, m.chehab@samsung.com,
Sumit Semwal <sumit.semwal@linaro.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH v5 2/4] drm/fence: release fence reference when canceling event
Date: Fri, 21 Oct 2016 14:52:37 +0200 [thread overview]
Message-ID: <20161021125237.GD20761@phenom.ffwll.local> (raw)
In-Reply-To: <1476975005-30441-3-git-send-email-gustavo@padovan.org>
On Thu, Oct 20, 2016 at 12:50:03PM -0200, Gustavo Padovan wrote:
> From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
>
> If the event gets canceled we also need to put away the fence
> reference it holds.
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I've broken my local dim scripts right now, so can't apply ;-)
-Daniel
> ---
> drivers/gpu/drm/drm_fops.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_fops.c b/drivers/gpu/drm/drm_fops.c
> index e84faec..8bed5f4 100644
> --- a/drivers/gpu/drm/drm_fops.c
> +++ b/drivers/gpu/drm/drm_fops.c
> @@ -663,6 +663,10 @@ void drm_event_cancel_free(struct drm_device *dev,
> list_del(&p->pending_link);
> }
> spin_unlock_irqrestore(&dev->event_lock, flags);
> +
> + if (p->fence)
> + fence_put(p->fence);
> +
> kfree(p);
> }
> EXPORT_SYMBOL(drm_event_cancel_free);
> --
> 2.5.5
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
next prev parent reply other threads:[~2016-10-21 12:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 14:50 [PATCH v5 0/4] drm: add explicit fencing Gustavo Padovan
2016-10-20 14:50 ` [PATCH v5 1/4] drm/fence: add in-fences support Gustavo Padovan
2016-10-21 12:51 ` Daniel Vetter
2016-10-21 12:51 ` Daniel Vetter
2016-10-20 14:50 ` [PATCH v5 2/4] drm/fence: release fence reference when canceling event Gustavo Padovan
2016-10-21 12:52 ` Daniel Vetter [this message]
2016-10-21 12:52 ` Daniel Vetter
2016-10-20 14:50 ` [PATCH v5 3/4] drm/fence: add fence timeline to drm_crtc Gustavo Padovan
2016-10-20 17:20 ` Brian Starkey
2016-10-20 20:12 ` Gustavo Padovan
2016-10-21 12:54 ` Daniel Vetter
2016-10-21 12:54 ` Daniel Vetter
2016-10-20 14:50 ` [PATCH v5 4/4] drm/fence: add out-fences support Gustavo Padovan
2016-10-20 15:35 ` Ville Syrjälä
2016-10-20 15:55 ` Gustavo Padovan
2016-10-20 16:34 ` Ville Syrjälä
2016-10-20 19:15 ` Ville Syrjälä
2016-10-21 12:57 ` Daniel Vetter
2016-10-21 12:57 ` Daniel Vetter
2016-10-21 13:07 ` Gustavo Padovan
2016-10-21 13:07 ` Gustavo Padovan
2016-10-20 17:48 ` Brian Starkey
2016-10-20 17:48 ` Brian Starkey
2016-10-20 20:30 ` Gustavo Padovan
2016-10-21 10:55 ` Brian Starkey
2016-10-21 13:00 ` Daniel Vetter
2016-10-21 13:00 ` Daniel Vetter
2016-10-21 15:44 ` Brian Starkey
2016-10-21 13:04 ` [PATCH v5 0/4] drm: add explicit fencing Daniel Vetter
2016-10-21 13:04 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021125237.GD20761@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=John.C.Harrison@Intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=gustavo@padovan.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=marcheu@google.com \
--cc=seanpaul@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.