From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: Peter Chen <Peter.Chen-3arQi8VN3Tc@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Sriram Dash <sriram.dash-3arQi8VN3Tc@public.gmane.org>
Subject: Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT
Date: Fri, 21 Oct 2016 10:53:50 -0700 [thread overview]
Message-ID: <20161021175350.GU7509@tuxbot> (raw)
In-Reply-To: <20161021173827.GJ26139-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On Fri 21 Oct 10:38 PDT 2016, Stephen Boyd wrote:
> On 10/21, Bjorn Andersson wrote:
> > hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent
> > memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated manually
> > it will not have any dma_mem or dma_ops assigned, which makes the
> > dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch solves
> > this by assigning the dma_mem and dma_ops based on the parent's DeviceTree
> > node.
> >
> > Cc: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> >
> > Hi Peter,
> >
> > After (once more) debugging why USB doesn't work up on the 64-bit Qualcomm
> > systems I realized that we never concluded on this patch. Unfortunately I can't
> > find it in my mailbox either, so resending it to restart the discussion.
> >
>
> I thought we were going to go down the route that Arnd has been
> pushing[1]? That should work, but I haven't tried it yet and
> there are some more fixes on top from Sriram. I think Sriram is
> taking over the patch now?
>
> [1] https://patchwork.kernel.org/patch/9319527/
Thanks for the pointer, I've heard about it but couldn't find it.
It does make me further wonder about the multi-device model of these
drivers, but I agree with you that it looks like the patch would
solve our issue.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Peter Chen <Peter.Chen@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Sriram Dash <sriram.dash@nxp.com>
Subject: Re: [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT
Date: Fri, 21 Oct 2016 10:53:50 -0700 [thread overview]
Message-ID: <20161021175350.GU7509@tuxbot> (raw)
In-Reply-To: <20161021173827.GJ26139@codeaurora.org>
On Fri 21 Oct 10:38 PDT 2016, Stephen Boyd wrote:
> On 10/21, Bjorn Andersson wrote:
> > hcd_alloc_coherent() and usb_alloc_coherent() ends up allocating coherent
> > memory on behalf of ci_hdrc driver. But as the ci_hdrc is instantiated manually
> > it will not have any dma_mem or dma_ops assigned, which makes the
> > dma_alloc_coherent() fail on some platforms (e.g. arm64). This patch solves
> > this by assigning the dma_mem and dma_ops based on the parent's DeviceTree
> > node.
> >
> > Cc: Stephen Boyd <sboyd@codeaurora.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> >
> > Hi Peter,
> >
> > After (once more) debugging why USB doesn't work up on the 64-bit Qualcomm
> > systems I realized that we never concluded on this patch. Unfortunately I can't
> > find it in my mailbox either, so resending it to restart the discussion.
> >
>
> I thought we were going to go down the route that Arnd has been
> pushing[1]? That should work, but I haven't tried it yet and
> there are some more fixes on top from Sriram. I think Sriram is
> taking over the patch now?
>
> [1] https://patchwork.kernel.org/patch/9319527/
Thanks for the pointer, I've heard about it but couldn't find it.
It does make me further wonder about the multi-device model of these
drivers, but I agree with you that it looks like the patch would
solve our issue.
Regards,
Bjorn
next prev parent reply other threads:[~2016-10-21 17:53 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 5:32 [PATCH] usb: chipidea: Configure DMA properties and ops from DT Bjorn Andersson
2016-02-22 6:02 ` Peter Chen
2016-02-22 6:14 ` Bjorn Andersson
2016-02-22 10:03 ` Srinivas Kandagatla
2016-02-22 22:07 ` Bjorn Andersson
2016-02-23 1:31 ` Peter Chen
2016-03-02 22:59 ` Li Yang
2016-03-08 19:52 ` Li Yang
2016-03-08 19:52 ` Li Yang
2016-03-08 19:52 ` Li Yang
2016-03-09 3:40 ` Bjorn Andersson
2016-03-09 3:40 ` Bjorn Andersson
2016-03-09 23:16 ` Li Yang
2016-03-09 23:16 ` Li Yang
2016-03-09 23:16 ` Li Yang
2016-03-14 10:51 ` Peter Chen
2016-03-14 10:51 ` Peter Chen
2016-03-17 15:52 ` Arnd Bergmann
2016-03-17 15:52 ` Arnd Bergmann
2016-03-18 1:54 ` Peter Chen
2016-03-18 1:54 ` Peter Chen
2016-03-18 3:25 ` Rajesh Bhagat
2016-03-18 3:25 ` Rajesh Bhagat
2016-03-18 3:25 ` Rajesh Bhagat
2016-03-18 7:28 ` Arnd Bergmann
2016-03-18 7:28 ` Arnd Bergmann
2016-03-18 10:56 ` Russell King - ARM Linux
2016-03-18 10:56 ` Russell King - ARM Linux
2016-03-25 4:02 ` Peter Chen
2016-03-25 4:02 ` Peter Chen
2016-03-25 4:39 ` [PATCH 1/1] usb: chipidea: add DMA mask configuration API kbuild test robot
2016-03-25 4:39 ` kbuild test robot
2016-03-25 4:39 ` kbuild test robot
2016-10-21 16:59 ` [RESEND PATCH] usb: chipidea: Configure DMA properties and ops from DT Bjorn Andersson
[not found] ` <1477069159-12399-1-git-send-email-bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-21 17:38 ` Stephen Boyd
2016-10-21 17:38 ` Stephen Boyd
[not found] ` <20161021173827.GJ26139-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2016-10-21 17:53 ` Bjorn Andersson [this message]
2016-10-21 17:53 ` Bjorn Andersson
2016-10-22 6:22 ` Sriram Dash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161021175350.GU7509@tuxbot \
--to=bjorn.andersson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=Peter.Chen-3arQi8VN3Tc@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=sriram.dash-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.