From: Jarod Wilson <jarod@redhat.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
davem@davemloft.net, linux-kernel@vger.kernel.org
Subject: Re: [B.A.T.M.A.N.] [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"
Date: Sun, 23 Oct 2016 21:48:23 -0400 [thread overview]
Message-ID: <20161024014823.GA42084@redhat.com> (raw)
In-Reply-To: <2358358.cV5hCSMD7y@sven-edge>
On Sun, Oct 23, 2016 at 09:17:50AM +0200, Sven Eckelmann wrote:
> On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote:
> [...]
> > You're going to
> > need more than just this revert though, since batman-adv calls
> > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless
> > batadv_hardif_min_mtu() always returns something 1500 or less.
>
> It does only returns 1500 or less at the moment.
>
> return min_t(int, min_mtu - batadv_max_header_len(), ETH_DATA_LEN);
>
> > Actually,
> > looking at that, you could omit the mtu < 68 bit from
> > batadv_interface_change_mtu() too, since that'll already get done in the
> > core, but I have no clue what you need for max_mtu.
>
> I would like to get this revert through net-next.git before anything else.
Looks like that should work fine then.
--
Jarod Wilson
jarod@redhat.com
WARNING: multiple messages have this Message-ID (diff)
From: Jarod Wilson <jarod@redhat.com>
To: Sven Eckelmann <sven@narfation.org>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
b.a.t.m.a.n@lists.open-mesh.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers"
Date: Sun, 23 Oct 2016 21:48:23 -0400 [thread overview]
Message-ID: <20161024014823.GA42084@redhat.com> (raw)
In-Reply-To: <2358358.cV5hCSMD7y@sven-edge>
On Sun, Oct 23, 2016 at 09:17:50AM +0200, Sven Eckelmann wrote:
> On Samstag, 22. Oktober 2016 21:08:26 CEST Jarod Wilson wrote:
> [...]
> > You're going to
> > need more than just this revert though, since batman-adv calls
> > ether_setup, which will set min_mtu = 68, max_mtu = 1500, unless
> > batadv_hardif_min_mtu() always returns something 1500 or less.
>
> It does only returns 1500 or less at the moment.
>
> return min_t(int, min_mtu - batadv_max_header_len(), ETH_DATA_LEN);
>
> > Actually,
> > looking at that, you could omit the mtu < 68 bit from
> > batadv_interface_change_mtu() too, since that'll already get done in the
> > core, but I have no clue what you need for max_mtu.
>
> I would like to get this revert through net-next.git before anything else.
Looks like that should work fine then.
--
Jarod Wilson
jarod@redhat.com
next prev parent reply other threads:[~2016-10-24 1:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 7:46 [B.A.T.M.A.N.] [PATCH] batman-adv: Revert "use core MTU range checking in misc drivers" Sven Eckelmann
2016-10-22 7:46 ` Sven Eckelmann
2016-10-23 1:08 ` [B.A.T.M.A.N.] " Jarod Wilson
2016-10-23 1:08 ` Jarod Wilson
2016-10-23 7:17 ` [B.A.T.M.A.N.] " Sven Eckelmann
2016-10-23 7:17 ` Sven Eckelmann
2016-10-23 7:17 ` Sven Eckelmann
2016-10-24 1:48 ` Jarod Wilson [this message]
2016-10-24 1:48 ` Jarod Wilson
2016-10-26 21:20 ` [B.A.T.M.A.N.] " David Miller
2016-10-26 21:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024014823.GA42084@redhat.com \
--to=jarod@redhat.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sven@narfation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.