From: Lee Jones <lee.jones@linaro.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Chen-Yu Tsai <wens@csie.org>, Sebastian Reichel <sre@kernel.org>,
Dennis Gilmore <dennis@ausil.us>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
Date: Mon, 24 Oct 2016 11:09:38 +0100 [thread overview]
Message-ID: <20161024100938.GI14477@dell> (raw)
In-Reply-To: <bbd16837-a260-b574-1b1a-1bede038e3de@redhat.com>
On Tue, 18 Oct 2016, Hans de Goede wrote:
> On 18-10-16 07:25, Chen-Yu Tsai wrote:
> > On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > > The i2c subsys does not load modules by compatible, only by
> > > i2c-id, with e.g. a modalias of: "i2c:axp209".
> > >
> > > Populate the axp20x_i2c_id[] table with supported ids, so that
> > > module auto-loading will work.
> > >
> > > Reported-by: Dennis Gilmore <dennis@ausil.us>
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Acked-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Even though axp20x-i2c seems to be the only "DT only" i2c client,
> > would it make sense to add DT-based module autoloading to the i2c
> > core?
>
> If it is not too invasive, then yes that would be a sensible addition IMHO.
If I understand you correctly, I already have a patch-set on the ML
that does this.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading
Date: Mon, 24 Oct 2016 11:09:38 +0100 [thread overview]
Message-ID: <20161024100938.GI14477@dell> (raw)
In-Reply-To: <bbd16837-a260-b574-1b1a-1bede038e3de@redhat.com>
On Tue, 18 Oct 2016, Hans de Goede wrote:
> On 18-10-16 07:25, Chen-Yu Tsai wrote:
> > On Wed, Oct 5, 2016 at 11:51 PM, Hans de Goede <hdegoede@redhat.com> wrote:
> > > The i2c subsys does not load modules by compatible, only by
> > > i2c-id, with e.g. a modalias of: "i2c:axp209".
> > >
> > > Populate the axp20x_i2c_id[] table with supported ids, so that
> > > module auto-loading will work.
> > >
> > > Reported-by: Dennis Gilmore <dennis@ausil.us>
> > > Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> >
> > Acked-by: Chen-Yu Tsai <wens@csie.org>
> >
> > Even though axp20x-i2c seems to be the only "DT only" i2c client,
> > would it make sense to add DT-based module autoloading to the i2c
> > core?
>
> If it is not too invasive, then yes that would be a sensible addition IMHO.
If I understand you correctly, I already have a patch-set on the ML
that does this.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-10-24 10:07 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-05 15:51 [PATCH 0/1] mfd: axp20x-i2c: Add i2c-ids to fix module auto-loading Hans de Goede
2016-10-05 15:51 ` Hans de Goede
2016-10-05 15:51 ` [PATCH] " Hans de Goede
2016-10-05 15:51 ` Hans de Goede
2016-10-18 5:25 ` Chen-Yu Tsai
2016-10-18 5:25 ` Chen-Yu Tsai
2016-10-18 10:25 ` Hans de Goede
2016-10-18 10:25 ` Hans de Goede
2016-10-24 10:09 ` Lee Jones [this message]
2016-10-24 10:09 ` Lee Jones
2016-10-24 10:17 ` Wolfram Sang
2016-10-24 10:17 ` Wolfram Sang
2016-10-24 10:34 ` Lee Jones
2016-10-24 10:34 ` Lee Jones
2016-10-24 10:47 ` Wolfram Sang
2016-10-24 10:47 ` Wolfram Sang
2016-10-26 14:00 ` Lee Jones
2016-10-26 14:00 ` Lee Jones
2016-10-19 2:51 ` Sebastian Reichel
2016-10-19 2:51 ` Sebastian Reichel
2016-10-19 2:56 ` Sebastian Reichel
2016-10-19 2:56 ` Sebastian Reichel
2016-10-26 14:01 ` Lee Jones
2016-10-26 14:01 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161024100938.GI14477@dell \
--to=lee.jones@linaro.org \
--cc=dennis@ausil.us \
--cc=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.