Re: [Stable 4.4 - NEEDS REVIEW - 1/3] mm: workingset: fix crash in shadow node shrinker caused by replace_page_cache_page()

[Michal Hocko <mhocko@kernel.org>]

On Mon 24-10-16 14:52:23, Johannes Weiner wrote:
> On Mon, Oct 24, 2016 at 05:26:03PM +0200, Michal Hocko wrote:
[...]
> > diff --git a/include/linux/swap.h b/include/linux/swap.h
> > index 7ba7dccaf0e7..b28de19aadbf 100644
> > --- a/include/linux/swap.h
> > +++ b/include/linux/swap.h
> > @@ -266,6 +266,7 @@ static inline void workingset_node_pages_inc(struct radix_tree_node *node)
> >  
> >  static inline void workingset_node_pages_dec(struct radix_tree_node *node)
> >  {
> > +	VM_BUG_ON(!workingset_node_pages(node));
> >  	node->count--;
> >  }
> 
> We should also pull 21f54ddae449 ("Using BUG_ON() as an assert() is
> _never_ acceptable") into stable on top of this patch to replace the
> BUG_ONs with warnings.
> 
> Otherwise this looks good to me.

OK, I have put that one on top and after the review will post it in one
series. Thanks for the review Johannes!

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>