From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-media@vger.kernel.org,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rafael Lourenço de Lima Chehab" <chehabrafael@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"Wolfram Sang" <wsa-dev@sang-engineering.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()
Date: Tue, 25 Oct 2016 08:40:32 +0000 [thread overview]
Message-ID: <20161025084031.GF4469@mwanda> (raw)
In-Reply-To: <68ad1aaa-c029-04b9-805a-e859f6c2d2d5@users.sourceforge.net>
On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote:
> + dev->isoc_ctl.transfer_buffer = kcalloc(num_bufs,
> + sizeof(*dev->isoc_ctl
> + .transfer_buffer),
This is ugly.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-media@vger.kernel.org,
"Hans Verkuil" <hans.verkuil@cisco.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Rafael Lourenço de Lima Chehab" <chehabrafael@gmail.com>,
"Shuah Khan" <shuah@kernel.org>,
"Wolfram Sang" <wsa-dev@sang-engineering.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc()
Date: Tue, 25 Oct 2016 11:40:32 +0300 [thread overview]
Message-ID: <20161025084031.GF4469@mwanda> (raw)
In-Reply-To: <68ad1aaa-c029-04b9-805a-e859f6c2d2d5@users.sourceforge.net>
On Mon, Oct 24, 2016 at 10:59:24PM +0200, SF Markus Elfring wrote:
> + dev->isoc_ctl.transfer_buffer = kcalloc(num_bufs,
> + sizeof(*dev->isoc_ctl
> + .transfer_buffer),
This is ugly.
regards,
dan carpenter
next prev parent reply other threads:[~2016-10-25 8:40 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 20:58 [PATCH 0/3] [media] au0828-video: Fine-tuning for au0828_init_isoc() SF Markus Elfring
2016-10-24 20:58 ` SF Markus Elfring
2016-10-24 20:59 ` [PATCH 1/3] [media] au0828-video: Use kcalloc() in au0828_init_isoc() SF Markus Elfring
2016-10-24 20:59 ` SF Markus Elfring
2016-10-24 22:28 ` Andrey Utkin
2016-10-24 22:28 ` Andrey Utkin
2016-10-25 0:11 ` Mauro Carvalho Chehab
2016-10-25 0:11 ` Mauro Carvalho Chehab
2016-10-25 5:51 ` Julia Lawall
2016-10-25 5:51 ` Julia Lawall
2016-10-25 12:46 ` Andrey Utkin
2016-10-25 12:46 ` Andrey Utkin
2016-10-25 8:40 ` Dan Carpenter [this message]
2016-10-25 8:40 ` Dan Carpenter
2016-10-24 21:00 ` [PATCH 2/3] [media] au0828-video: Delete three error messages for a failed memory allocation SF Markus Elfring
2016-10-24 21:00 ` SF Markus Elfring
2016-10-24 21:01 ` [PATCH 3/3] [media] au0828-video: Move two assignments in au0828_init_isoc() SF Markus Elfring
2016-10-24 21:01 ` SF Markus Elfring
2016-10-25 9:06 ` Dan Carpenter
2016-10-25 9:06 ` Dan Carpenter
2016-11-03 12:41 ` Hans Verkuil
2016-11-03 12:41 ` Hans Verkuil
2016-11-03 19:56 ` SF Markus Elfring
2016-11-03 19:56 ` SF Markus Elfring
2016-11-04 8:09 ` Hans Verkuil
2016-11-04 8:09 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025084031.GF4469@mwanda \
--to=dan.carpenter@oracle.com \
--cc=chehabrafael@gmail.com \
--cc=elfring@users.sourceforge.net \
--cc=hans.verkuil@cisco.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=shuah@kernel.org \
--cc=wsa-dev@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.