From: Pavel Machek <pavel@ucw.cz>
To: Karol Herbst <karolherbst@gmail.com>
Cc: ML nouveau <nouveau@lists.freedesktop.org>,
Ben Skeggs <bskeggs@redhat.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Nouveau] noveau: emergency shutdown handling is overcomplex and broken
Date: Tue, 25 Oct 2016 13:13:00 +0200 [thread overview]
Message-ID: <20161025111300.GB25855@amd> (raw)
In-Reply-To: <CAEXux-YC5CRsEXc0EKxVgEgcQEO6J9cu5WeeAvorTfUHEDcr-Q@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 2356 bytes --]
On Tue 2016-10-25 13:09:25, Karol Herbst wrote:
> Thanks for the pointer.
>
> But I don't like this patch. If you find a bug, make a bug report or
> just fix it if you know the fix already. Or write something in
> IRC. Or
I found a bug, and this is my bug report. Can you take care and fix
it?
Pavel
> write on the Mailing list as a general question or something else
>
> But I really don't agree on doing it this way. You would have needed
> like the same amount of time to actual fix the problem.
>
> Anyway, for adding a printk:
>
> struct nvkm_subdev *subdev = &therm->subdev;
> nvkm_error(subdev, "message");
>
> 2016-10-25 12:50 GMT+02:00 Pavel Machek <pavel@ucw.cz>:
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> > index b9703c0..adb1deb 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> > @@ -120,6 +120,11 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
> > struct work_struct *work;
> >
> > work = kmalloc(sizeof(*work), GFP_ATOMIC);
> > + /* FIXME:
> > + 1) this is total overkill, orderly_poweroff() already
> > + uses schedule_work internally
> > + 2) it would be good to at least printk what is going on
> > + */
> > if (work) {
> > INIT_WORK(work, nv_poweroff_work);
> > schedule_work(work);
> >
> > GFP_ATOMIC is not reliable. Plus, see the fixme.
> >
> > Best regards,
> > Pavel
> >
> > --
> > (english) http://www.livejournal.com/~pavelmachek
> > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> >
> > _______________________________________________
> > Nouveau mailing list
> > Nouveau@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/nouveau
> >
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Karol Herbst <karolherbst@gmail.com>
Cc: Ben Skeggs <bskeggs@redhat.com>, David Airlie <airlied@linux.ie>,
dri-devel <dri-devel@lists.freedesktop.org>,
ML nouveau <nouveau@lists.freedesktop.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [Nouveau] noveau: emergency shutdown handling is overcomplex and broken
Date: Tue, 25 Oct 2016 13:13:00 +0200 [thread overview]
Message-ID: <20161025111300.GB25855@amd> (raw)
In-Reply-To: <CAEXux-YC5CRsEXc0EKxVgEgcQEO6J9cu5WeeAvorTfUHEDcr-Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2356 bytes --]
On Tue 2016-10-25 13:09:25, Karol Herbst wrote:
> Thanks for the pointer.
>
> But I don't like this patch. If you find a bug, make a bug report or
> just fix it if you know the fix already. Or write something in
> IRC. Or
I found a bug, and this is my bug report. Can you take care and fix
it?
Pavel
> write on the Mailing list as a general question or something else
>
> But I really don't agree on doing it this way. You would have needed
> like the same amount of time to actual fix the problem.
>
> Anyway, for adding a printk:
>
> struct nvkm_subdev *subdev = &therm->subdev;
> nvkm_error(subdev, "message");
>
> 2016-10-25 12:50 GMT+02:00 Pavel Machek <pavel@ucw.cz>:
> >
> > diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> > index b9703c0..adb1deb 100644
> > --- a/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> > +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/therm/temp.c
> > @@ -120,6 +120,11 @@ nvkm_therm_sensor_event(struct nvkm_therm *therm, enum nvkm_therm_thrs thrs,
> > struct work_struct *work;
> >
> > work = kmalloc(sizeof(*work), GFP_ATOMIC);
> > + /* FIXME:
> > + 1) this is total overkill, orderly_poweroff() already
> > + uses schedule_work internally
> > + 2) it would be good to at least printk what is going on
> > + */
> > if (work) {
> > INIT_WORK(work, nv_poweroff_work);
> > schedule_work(work);
> >
> > GFP_ATOMIC is not reliable. Plus, see the fixme.
> >
> > Best regards,
> > Pavel
> >
> > --
> > (english) http://www.livejournal.com/~pavelmachek
> > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> >
> > _______________________________________________
> > Nouveau mailing list
> > Nouveau@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/nouveau
> >
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-10-25 11:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 10:50 noveau: emergency shutdown handling is overcomplex and broken Pavel Machek
2016-10-25 11:09 ` Karol Herbst
2016-10-25 11:09 ` [Nouveau] " Karol Herbst
2016-10-25 11:13 ` Pavel Machek [this message]
2016-10-25 11:13 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025111300.GB25855@amd \
--to=pavel@ucw.cz \
--cc=bskeggs@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karolherbst@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.