* [meta-networking][PATCH] wireshark: install missing header files
@ 2016-10-19 0:28 Armin Kuster
2016-10-25 13:27 ` Martin Jansa
2016-10-25 13:33 ` Martin Jansa
0 siblings, 2 replies; 4+ messages in thread
From: Armin Kuster @ 2016-10-19 0:28 UTC (permalink / raw)
To: akuster, openembedded-devel
Wireshark does not install header files. add install_append
Remove ALLOW_EMPTY & INHIBIT_PACKAGE_DEBUG_SPLIT, they are no longer needed
Signed-off-by: Armin Kuster <akuster808@gmail.com>
---
.../recipes-support/wireshark/wireshark_2.2.1.bb | 22 +++++++++++++++++++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb b/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
index a5fb7f6..f7d7927 100644
--- a/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
+++ b/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
@@ -43,7 +43,23 @@ PACKAGECONFIG[c-ares] = "--with-c-ares=yes, --with-c-ares=no, c-ares"
EXTRA_OECONF += "--with-qt=no --enable-tshark --enable-rawshark"
-ALLOW_EMPTY_${PN} = "1"
-INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
+# Currently wireshark does not install header files
+do_install_append () {
-FILES_${PN} += "${datadir}*"
+ install -d ${D}/${includedir}/${BPN}
+ install -d ${D}/${includedir}/${BPN}/epan
+ install -d ${D}/${includedir}/${BPN}/epan/crypt
+ install -d ${D}/${includedir}/${BPN}/epan/dfilter
+ install -d ${D}/${includedir}/${BPN}/epan/dissectors
+ install -d ${D}/${includedir}/${BPN}/epan/ftypes
+ install -d ${D}/${includedir}/${BPN}/epan/wmem
+
+ install config.h ${D}/${includedir}/${BPN}
+ install ${S}/register.h ${D}/${includedir}/${BPN}
+ install -D ${S}/epan/*.h ${D}/${includedir}/${BPN}/epan
+ install -D ${S}/epan/crypt/*.h ${D}/${includedir}/${BPN}/epan/crypt
+ install -D ${S}/epan/dfilter/*.h ${D}/${includedir}/${BPN}/epan/dfilter
+ install -D ${S}/epan/dissectors/*.h ${D}/${includedir}/${BPN}/epan/dissectors
+ install -D ${S}/epan/ftypes/*.h ${D}/${includedir}/${BPN}/epan/ftypes
+ install -D ${S}/epan/wmem/*.h ${D}/${includedir}/${BPN}/epan/wmem
+}
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [meta-networking][PATCH] wireshark: install missing header files
2016-10-19 0:28 [meta-networking][PATCH] wireshark: install missing header files Armin Kuster
@ 2016-10-25 13:27 ` Martin Jansa
2016-10-25 13:33 ` Martin Jansa
1 sibling, 0 replies; 4+ messages in thread
From: Martin Jansa @ 2016-10-25 13:27 UTC (permalink / raw)
To: openembedded-devel; +Cc: akuster
[-- Attachment #1: Type: text/plain, Size: 4730 bytes --]
On Tue, Oct 18, 2016 at 05:28:45PM -0700, Armin Kuster wrote:
> Wireshark does not install header files. add install_append
> Remove ALLOW_EMPTY & INHIBIT_PACKAGE_DEBUG_SPLIT, they are no longer needed
>
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> .../recipes-support/wireshark/wireshark_2.2.1.bb | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb b/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
> index a5fb7f6..f7d7927 100644
> --- a/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
> +++ b/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
> @@ -43,7 +43,23 @@ PACKAGECONFIG[c-ares] = "--with-c-ares=yes, --with-c-ares=no, c-ares"
>
> EXTRA_OECONF += "--with-qt=no --enable-tshark --enable-rawshark"
>
> -ALLOW_EMPTY_${PN} = "1"
> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> +# Currently wireshark does not install header files
> +do_install_append () {
>
> -FILES_${PN} += "${datadir}*"
Why was this removed?
Now there is couple QA errors:
wireshark-2.2.1: wireshark: Files/directories were installed but not shipped in any package:
/usr/share/mime
/usr/share/appdata
/usr/share/icons
/usr/share/mime/packages
/usr/share/mime/packages/wireshark.xml
/usr/share/appdata/wireshark.appdata.xml
/usr/share/icons/hicolor
/usr/share/icons/hicolor/16x16
/usr/share/icons/hicolor/24x24
/usr/share/icons/hicolor/32x32
/usr/share/icons/hicolor/48x48
/usr/share/icons/hicolor/64x64
/usr/share/icons/hicolor/128x128
/usr/share/icons/hicolor/256x256
/usr/share/icons/hicolor/scalable
/usr/share/icons/hicolor/16x16/apps
/usr/share/icons/hicolor/16x16/mimetypes
/usr/share/icons/hicolor/16x16/apps/wireshark.png
/usr/share/icons/hicolor/16x16/mimetypes/application-wireshark-doc.png
/usr/share/icons/hicolor/24x24/apps
/usr/share/icons/hicolor/24x24/mimetypes
/usr/share/icons/hicolor/24x24/apps/wireshark.png
/usr/share/icons/hicolor/24x24/mimetypes/application-wireshark-doc.png
/usr/share/icons/hicolor/32x32/apps
/usr/share/icons/hicolor/32x32/mimetypes
/usr/share/icons/hicolor/32x32/apps/wireshark.png
/usr/share/icons/hicolor/32x32/mimetypes/application-wireshark-doc.png
/usr/share/icons/hicolor/48x48/apps
/usr/share/icons/hicolor/48x48/mimetypes
/usr/share/icons/hicolor/48x48/apps/wireshark.png
/usr/share/icons/hicolor/48x48/mimetypes/application-wireshark-doc.png
/usr/share/icons/hicolor/64x64/apps
/usr/share/icons/hicolor/64x64/mimetypes
/usr/share/icons/hicolor/64x64/apps/wireshark.png
/usr/share/icons/hicolor/64x64/mimetypes/application-wireshark-doc.png
/usr/share/icons/hicolor/128x128/apps
/usr/share/icons/hicolor/128x128/mimetypes
/usr/share/icons/hicolor/128x128/apps/wireshark.png
/usr/share/icons/hicolor/128x128/mimetypes/application-wireshark-doc.png
/usr/share/icons/hicolor/256x256/apps
/usr/share/icons/hicolor/256x256/mimetypes
/usr/share/icons/hicolor/256x256/apps/wireshark.png
/usr/share/icons/hicolor/256x256/mimetypes/application-wireshark-doc.png
/usr/share/icons/hicolor/scalable/apps
/usr/share/icons/hicolor/scalable/apps/wireshark.svg
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
wireshark: 45 installed and not shipped files. [installed-vs-shipped]
> + install -d ${D}/${includedir}/${BPN}
> + install -d ${D}/${includedir}/${BPN}/epan
> + install -d ${D}/${includedir}/${BPN}/epan/crypt
> + install -d ${D}/${includedir}/${BPN}/epan/dfilter
> + install -d ${D}/${includedir}/${BPN}/epan/dissectors
> + install -d ${D}/${includedir}/${BPN}/epan/ftypes
> + install -d ${D}/${includedir}/${BPN}/epan/wmem
> +
> + install config.h ${D}/${includedir}/${BPN}
> + install ${S}/register.h ${D}/${includedir}/${BPN}
> + install -D ${S}/epan/*.h ${D}/${includedir}/${BPN}/epan
> + install -D ${S}/epan/crypt/*.h ${D}/${includedir}/${BPN}/epan/crypt
> + install -D ${S}/epan/dfilter/*.h ${D}/${includedir}/${BPN}/epan/dfilter
> + install -D ${S}/epan/dissectors/*.h ${D}/${includedir}/${BPN}/epan/dissectors
> + install -D ${S}/epan/ftypes/*.h ${D}/${includedir}/${BPN}/epan/ftypes
> + install -D ${S}/epan/wmem/*.h ${D}/${includedir}/${BPN}/epan/wmem
> +}
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [meta-networking][PATCH] wireshark: install missing header files
2016-10-19 0:28 [meta-networking][PATCH] wireshark: install missing header files Armin Kuster
2016-10-25 13:27 ` Martin Jansa
@ 2016-10-25 13:33 ` Martin Jansa
2016-10-25 21:09 ` akuster808
1 sibling, 1 reply; 4+ messages in thread
From: Martin Jansa @ 2016-10-25 13:33 UTC (permalink / raw)
To: openembedded-devel; +Cc: akuster
[-- Attachment #1: Type: text/plain, Size: 2514 bytes --]
On Tue, Oct 18, 2016 at 05:28:45PM -0700, Armin Kuster wrote:
> Wireshark does not install header files. add install_append
> Remove ALLOW_EMPTY & INHIBIT_PACKAGE_DEBUG_SPLIT, they are no longer needed
There is also:
wireshark-2.2.1: wireshark rdepends on libssh, but it isn't a build
dependency, missing libssh in DEPENDS or PACKAGECONFIG? [build-deps]
Probably not caused by this change, but one of previous 2 upgrades.
> Signed-off-by: Armin Kuster <akuster808@gmail.com>
> ---
> .../recipes-support/wireshark/wireshark_2.2.1.bb | 22 +++++++++++++++++++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb b/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
> index a5fb7f6..f7d7927 100644
> --- a/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
> +++ b/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
> @@ -43,7 +43,23 @@ PACKAGECONFIG[c-ares] = "--with-c-ares=yes, --with-c-ares=no, c-ares"
>
> EXTRA_OECONF += "--with-qt=no --enable-tshark --enable-rawshark"
>
> -ALLOW_EMPTY_${PN} = "1"
> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
> +# Currently wireshark does not install header files
> +do_install_append () {
>
> -FILES_${PN} += "${datadir}*"
> + install -d ${D}/${includedir}/${BPN}
> + install -d ${D}/${includedir}/${BPN}/epan
> + install -d ${D}/${includedir}/${BPN}/epan/crypt
> + install -d ${D}/${includedir}/${BPN}/epan/dfilter
> + install -d ${D}/${includedir}/${BPN}/epan/dissectors
> + install -d ${D}/${includedir}/${BPN}/epan/ftypes
> + install -d ${D}/${includedir}/${BPN}/epan/wmem
> +
> + install config.h ${D}/${includedir}/${BPN}
> + install ${S}/register.h ${D}/${includedir}/${BPN}
> + install -D ${S}/epan/*.h ${D}/${includedir}/${BPN}/epan
> + install -D ${S}/epan/crypt/*.h ${D}/${includedir}/${BPN}/epan/crypt
> + install -D ${S}/epan/dfilter/*.h ${D}/${includedir}/${BPN}/epan/dfilter
> + install -D ${S}/epan/dissectors/*.h ${D}/${includedir}/${BPN}/epan/dissectors
> + install -D ${S}/epan/ftypes/*.h ${D}/${includedir}/${BPN}/epan/ftypes
> + install -D ${S}/epan/wmem/*.h ${D}/${includedir}/${BPN}/epan/wmem
> +}
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 169 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [meta-networking][PATCH] wireshark: install missing header files
2016-10-25 13:33 ` Martin Jansa
@ 2016-10-25 21:09 ` akuster808
0 siblings, 0 replies; 4+ messages in thread
From: akuster808 @ 2016-10-25 21:09 UTC (permalink / raw)
To: openembedded-devel
On 10/25/2016 06:33 AM, Martin Jansa wrote:
> On Tue, Oct 18, 2016 at 05:28:45PM -0700, Armin Kuster wrote:
>> Wireshark does not install header files. add install_append
>> Remove ALLOW_EMPTY & INHIBIT_PACKAGE_DEBUG_SPLIT, they are no longer needed
> There is also:
> wireshark-2.2.1: wireshark rdepends on libssh, but it isn't a build
> dependency, missing libssh in DEPENDS or PACKAGECONFIG? [build-deps]
>
> Probably not caused by this change, but one of previous 2 upgrades.
k, thanks.
Will look in this.
Armin
>
>
>> Signed-off-by: Armin Kuster <akuster808@gmail.com>
>> ---
>> .../recipes-support/wireshark/wireshark_2.2.1.bb | 22 +++++++++++++++++++---
>> 1 file changed, 19 insertions(+), 3 deletions(-)
>>
>> diff --git a/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb b/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
>> index a5fb7f6..f7d7927 100644
>> --- a/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
>> +++ b/meta-networking/recipes-support/wireshark/wireshark_2.2.1.bb
>> @@ -43,7 +43,23 @@ PACKAGECONFIG[c-ares] = "--with-c-ares=yes, --with-c-ares=no, c-ares"
>>
>> EXTRA_OECONF += "--with-qt=no --enable-tshark --enable-rawshark"
>>
>> -ALLOW_EMPTY_${PN} = "1"
>> -INHIBIT_PACKAGE_DEBUG_SPLIT = "1"
>> +# Currently wireshark does not install header files
>> +do_install_append () {
>>
>> -FILES_${PN} += "${datadir}*"
>> + install -d ${D}/${includedir}/${BPN}
>> + install -d ${D}/${includedir}/${BPN}/epan
>> + install -d ${D}/${includedir}/${BPN}/epan/crypt
>> + install -d ${D}/${includedir}/${BPN}/epan/dfilter
>> + install -d ${D}/${includedir}/${BPN}/epan/dissectors
>> + install -d ${D}/${includedir}/${BPN}/epan/ftypes
>> + install -d ${D}/${includedir}/${BPN}/epan/wmem
>> +
>> + install config.h ${D}/${includedir}/${BPN}
>> + install ${S}/register.h ${D}/${includedir}/${BPN}
>> + install -D ${S}/epan/*.h ${D}/${includedir}/${BPN}/epan
>> + install -D ${S}/epan/crypt/*.h ${D}/${includedir}/${BPN}/epan/crypt
>> + install -D ${S}/epan/dfilter/*.h ${D}/${includedir}/${BPN}/epan/dfilter
>> + install -D ${S}/epan/dissectors/*.h ${D}/${includedir}/${BPN}/epan/dissectors
>> + install -D ${S}/epan/ftypes/*.h ${D}/${includedir}/${BPN}/epan/ftypes
>> + install -D ${S}/epan/wmem/*.h ${D}/${includedir}/${BPN}/epan/wmem
>> +}
>> --
>> 2.7.4
>>
>> --
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-10-25 21:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-19 0:28 [meta-networking][PATCH] wireshark: install missing header files Armin Kuster
2016-10-25 13:27 ` Martin Jansa
2016-10-25 13:33 ` Martin Jansa
2016-10-25 21:09 ` akuster808
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.