From: Lina Iyer <lina.iyer@linaro.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: ulf.hansson@linaro.org, khilman@kernel.org, rjw@rjwysocki.net,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
andy.gross@linaro.org, sboyd@codeaurora.org,
linux-arm-msm@vger.kernel.org, brendan.jackman@arm.com,
lorenzo.pieralisi@arm.com, Juri.Lelli@arm.com,
devicetree@vger.kernel.org, Rob Herring <robh@kernel.org>
Subject: Re: [PATCH 3/4] dt-bindings: Update domain-idle-state binding to use correct compatibles
Date: Tue, 25 Oct 2016 10:24:40 -0600 [thread overview]
Message-ID: <20161025162440.GA48977@linaro.org> (raw)
In-Reply-To: <383a62dd-b4d7-f764-baf1-ff73691b3cbc@arm.com>
On Tue, Oct 25 2016 at 09:59 -0600, Sudeep Holla wrote:
>
>
>On 25/10/16 16:26, Lina Iyer wrote:
>>Update domain-idle-state binding to use "domain-idle-state" compatible
>>from Documentation/devicetree/bindings/arm/idle-states.txt.
>>
>>Cc: <devicetree@vger.kernel.org>
>>Cc: Rob Herring <robh@kernel.org>
>>Suggested-by: Sudeep Holla <sudeep.holla@arm.com>
>>Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
>>---
>> Documentation/devicetree/bindings/power/power_domain.txt | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>>diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt
>>index e165036..6fb53a3 100644
>>--- a/Documentation/devicetree/bindings/power/power_domain.txt
>>+++ b/Documentation/devicetree/bindings/power/power_domain.txt
>>@@ -30,8 +30,9 @@ Optional properties:
>> available in the next section.
>>
>> - domain-idle-states : A phandle of an idle-state that shall be soaked into a
>>- generic domain power state. The idle state definitions are
>>- compatible with arm,idle-state specified in [1].
>>+ generic domain power state. The idle state definitions must be
>>+ compatible with "domain-idle-state"
>
>I would reword the below a bit different so that it's flexible to be
>reused without "arm,idle-state".
>
>>as well as
>>+ "arm,idle-state" as defined in [1].
>
>'Idle states that are "arm,idle-state" compatible are generally
>"domain-idle-state" compatible as well if it's a PM domain.'
>
I believe we should have both compatible strings. Per [1], any CPU that
follows the idle state compatible *must* have "arm,idle-state" as a
compatible. Since we are re-using the same compatible, its only correct
that we retain what is already spec'd up in [1] and in addition provide
this new compatible.
Thanks,
Lina
>or something like that in line with what's in patch 2/4.
>
>That would give us the scope of reuse of "domain-idle-state" in device
>for future. Also it aligns with your patch 4/4.
>
>Otherwise, it looks good.
>
>--
>Regards,
>Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: lina.iyer@linaro.org (Lina Iyer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] dt-bindings: Update domain-idle-state binding to use correct compatibles
Date: Tue, 25 Oct 2016 10:24:40 -0600 [thread overview]
Message-ID: <20161025162440.GA48977@linaro.org> (raw)
In-Reply-To: <383a62dd-b4d7-f764-baf1-ff73691b3cbc@arm.com>
On Tue, Oct 25 2016 at 09:59 -0600, Sudeep Holla wrote:
>
>
>On 25/10/16 16:26, Lina Iyer wrote:
>>Update domain-idle-state binding to use "domain-idle-state" compatible
>>from Documentation/devicetree/bindings/arm/idle-states.txt.
>>
>>Cc: <devicetree@vger.kernel.org>
>>Cc: Rob Herring <robh@kernel.org>
>>Suggested-by: Sudeep Holla <sudeep.holla@arm.com>
>>Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
>>---
>> Documentation/devicetree/bindings/power/power_domain.txt | 9 +++++----
>> 1 file changed, 5 insertions(+), 4 deletions(-)
>>
>>diff --git a/Documentation/devicetree/bindings/power/power_domain.txt b/Documentation/devicetree/bindings/power/power_domain.txt
>>index e165036..6fb53a3 100644
>>--- a/Documentation/devicetree/bindings/power/power_domain.txt
>>+++ b/Documentation/devicetree/bindings/power/power_domain.txt
>>@@ -30,8 +30,9 @@ Optional properties:
>> available in the next section.
>>
>> - domain-idle-states : A phandle of an idle-state that shall be soaked into a
>>- generic domain power state. The idle state definitions are
>>- compatible with arm,idle-state specified in [1].
>>+ generic domain power state. The idle state definitions must be
>>+ compatible with "domain-idle-state"
>
>I would reword the below a bit different so that it's flexible to be
>reused without "arm,idle-state".
>
>>as well as
>>+ "arm,idle-state" as defined in [1].
>
>'Idle states that are "arm,idle-state" compatible are generally
>"domain-idle-state" compatible as well if it's a PM domain.'
>
I believe we should have both compatible strings. Per [1], any CPU that
follows the idle state compatible *must* have "arm,idle-state" as a
compatible. Since we are re-using the same compatible, its only correct
that we retain what is already spec'd up in [1] and in addition provide
this new compatible.
Thanks,
Lina
>or something like that in line with what's in patch 2/4.
>
>That would give us the scope of reuse of "domain-idle-state" in device
>for future. Also it aligns with your patch 4/4.
>
>Otherwise, it looks good.
>
>--
>Regards,
>Sudeep
next prev parent reply other threads:[~2016-10-25 16:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 15:26 [PATCH 0/4] PM / Domains: DT bindings for domain idle states and doc updates Lina Iyer
2016-10-25 15:26 ` Lina Iyer
2016-10-25 15:26 ` [PATCH 1/4] PM / doc: Update device documentation for devices in IRQ safe PM domains Lina Iyer
2016-10-25 15:26 ` Lina Iyer
2016-11-01 4:15 ` Rafael J. Wysocki
2016-11-01 4:15 ` Rafael J. Wysocki
2016-10-25 15:26 ` [PATCH 2/4] dt-bindings: add domain-idle-state compatible to arm,idle-state Lina Iyer
2016-10-25 15:26 ` [PATCH 2/4] dt-bindings: add domain-idle-state compatible to arm, idle-state Lina Iyer
[not found] ` <1477409199-52182-1-git-send-email-lina.iyer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-25 15:26 ` [PATCH 3/4] dt-bindings: Update domain-idle-state binding to use correct compatibles Lina Iyer
2016-10-25 15:26 ` Lina Iyer
2016-10-25 15:59 ` Sudeep Holla
2016-10-25 15:59 ` Sudeep Holla
2016-10-25 16:24 ` Lina Iyer [this message]
2016-10-25 16:24 ` Lina Iyer
[not found] ` <20161025162440.GA48977-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-25 16:52 ` Sudeep Holla
2016-10-25 16:52 ` Sudeep Holla
2016-10-25 20:49 ` Kevin Hilman
2016-10-25 20:49 ` Kevin Hilman
2016-10-26 8:57 ` Sudeep Holla
2016-10-26 8:57 ` Sudeep Holla
2016-10-31 2:50 ` Rob Herring
2016-10-31 2:50 ` Rob Herring
2016-10-25 15:26 ` [PATCH 4/4] PM / Domains: Use domain-idle-state compatible Lina Iyer
2016-10-25 15:26 ` Lina Iyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025162440.GA48977@linaro.org \
--to=lina.iyer@linaro.org \
--cc=Juri.Lelli@arm.com \
--cc=andy.gross@linaro.org \
--cc=brendan.jackman@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.