From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: Neaten show_regs, remove KERN_CONT
Date: Tue, 25 Oct 2016 19:04:08 +0100 [thread overview]
Message-ID: <20161025180408.GF8898@leverpostej> (raw)
In-Reply-To: <CA+55aFwFQSass91gdGsjo4BkkAYmoFSn-Cpm6yF+SygF_tRp1g@mail.gmail.com>
On Tue, Oct 25, 2016 at 10:38:31AM -0700, Linus Torvalds wrote:
> On Mon, Oct 24, 2016 at 9:42 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > That does not appear to be the case; as fr as I can tell the core prints a
> > timestamp per line as required. If I run:
> >
> > printk("TEST\nLINE1\nLINE2\nLINE3\nLINE4\n");
>
> Please don't do this.
>
> It has historically not worked well, and it still doesn't actually
> work reliably. In particular, it currently works in the *logs* (ie
> dmesg), but not necessarily on screen (because "msg_print_text()" does
> do the "look for newlines in the middle", but console_cont_flush()
> does not).
Sure; I'll avoid that.
it seems that's a drop in the ocean, though. :/
[mark at leverpostej:~/src/linux]% git grep 'pr\(intk\|_.*\)(.*)' | grep '\\n[^"]' | wc -l
375
> So you can try the attached patch. It likely fixes your issues simply
> because it removes all the crazy code.
That worked for me. I see consistent results over the UART and in dmesg
with that applied atop of v4.9-rc2. Feel free to add:
Tested-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Joe Perches <joe@perches.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: Neaten show_regs, remove KERN_CONT
Date: Tue, 25 Oct 2016 19:04:08 +0100 [thread overview]
Message-ID: <20161025180408.GF8898@leverpostej> (raw)
In-Reply-To: <CA+55aFwFQSass91gdGsjo4BkkAYmoFSn-Cpm6yF+SygF_tRp1g@mail.gmail.com>
On Tue, Oct 25, 2016 at 10:38:31AM -0700, Linus Torvalds wrote:
> On Mon, Oct 24, 2016 at 9:42 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> >
> > That does not appear to be the case; as fr as I can tell the core prints a
> > timestamp per line as required. If I run:
> >
> > printk("TEST\nLINE1\nLINE2\nLINE3\nLINE4\n");
>
> Please don't do this.
>
> It has historically not worked well, and it still doesn't actually
> work reliably. In particular, it currently works in the *logs* (ie
> dmesg), but not necessarily on screen (because "msg_print_text()" does
> do the "look for newlines in the middle", but console_cont_flush()
> does not).
Sure; I'll avoid that.
it seems that's a drop in the ocean, though. :/
[mark@leverpostej:~/src/linux]% git grep 'pr\(intk\|_.*\)(.*)' | grep '\\n[^"]' | wc -l
375
> So you can try the attached patch. It likely fixes your issues simply
> because it removes all the crazy code.
That worked for me. I see consistent results over the UART and in dmesg
with that applied atop of v4.9-rc2. Feel free to add:
Tested-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
next prev parent reply other threads:[~2016-10-25 18:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 20:40 [PATCH] arm64: Neaten show_regs, remove KERN_CONT Joe Perches
2016-10-23 20:40 ` Joe Perches
2016-10-24 11:31 ` Mark Rutland
2016-10-24 11:31 ` Mark Rutland
2016-10-24 16:27 ` Joe Perches
2016-10-24 16:27 ` Joe Perches
2016-10-24 16:42 ` Mark Rutland
2016-10-24 16:42 ` Mark Rutland
2016-10-25 17:38 ` Linus Torvalds
2016-10-25 17:38 ` Linus Torvalds
2016-10-25 17:55 ` Linus Torvalds
2016-10-25 17:55 ` Linus Torvalds
2016-10-25 18:05 ` Joe Perches
2016-10-25 18:05 ` Joe Perches
2016-10-25 18:04 ` Mark Rutland [this message]
2016-10-25 18:04 ` Mark Rutland
2016-10-25 14:32 ` Mark Rutland
2016-10-25 14:32 ` Mark Rutland
2016-10-25 16:44 ` Joe Perches
2016-10-25 16:44 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025180408.GF8898@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.