All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
	qemu-devel@nongnu.org, Xen-devel <xen-devel@lists.xenproject.org>,
	Anthony PERARD <anthony.perard@citrix.com>,
	mst@redhat.com, pbonzini@redhat.com, rth@twiddle.net,
	ehabkost@redhat.com
Subject: Re: [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests
Date: Wed, 26 Oct 2016 11:32:56 +0100	[thread overview]
Message-ID: <20161026103255.GG30231@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1610251631290.9978@sstabellini-ThinkPad-X260>

On Tue, Oct 25, 2016 at 04:33:03PM -0700, Stefano Stabellini wrote:
> CC'ing maintainers
> 
> On Tue, 25 Oct 2016, Wei Liu wrote:
> > Xen's toolstack is in charge of building ACPI tables. Skip acpi table
> > building if running on Xen.
> > 
> > This issue is discovered due to direct kernel boot on Xen doesn't boot
> > anymore, because the new ACPI tables cause the guest to exceed its
> > memory allocation limit.
> > 
> > Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Hi Wei,
> thanks for the patch. I think the right fix is to set
> 
> pcmc->has_acpi_build = false
> 
> for the xenfv machine and for the PC machine when accel=xen.
> 
> Thoughts?
> 

This sounds like a better idea to me.

Wei.

WARNING: multiple messages have this Message-ID (diff)
From: Wei Liu <wei.liu2@citrix.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: Wei Liu <wei.liu2@citrix.com>,
	ehabkost@redhat.com, mst@redhat.com, qemu-devel@nongnu.org,
	pbonzini@redhat.com, Anthony PERARD <anthony.perard@citrix.com>,
	Xen-devel <xen-devel@lists.xenproject.org>,
	rth@twiddle.net
Subject: Re: [PATCH RFC] acpi: don't build acpi tables for xen hvm guests
Date: Wed, 26 Oct 2016 11:32:56 +0100	[thread overview]
Message-ID: <20161026103255.GG30231@citrix.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1610251631290.9978@sstabellini-ThinkPad-X260>

On Tue, Oct 25, 2016 at 04:33:03PM -0700, Stefano Stabellini wrote:
> CC'ing maintainers
> 
> On Tue, 25 Oct 2016, Wei Liu wrote:
> > Xen's toolstack is in charge of building ACPI tables. Skip acpi table
> > building if running on Xen.
> > 
> > This issue is discovered due to direct kernel boot on Xen doesn't boot
> > anymore, because the new ACPI tables cause the guest to exceed its
> > memory allocation limit.
> > 
> > Reported-by: Sander Eikelenboom <linux@eikelenboom.it>
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> 
> Hi Wei,
> thanks for the patch. I think the right fix is to set
> 
> pcmc->has_acpi_build = false
> 
> for the xenfv machine and for the PC machine when accel=xen.
> 
> Thoughts?
> 

This sounds like a better idea to me.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-10-26 10:33 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25 17:28 [Qemu-devel] [PATCH RFC] acpi: don't build acpi tables for xen hvm guests Wei Liu
2016-10-25 23:33 ` Stefano Stabellini
2016-10-26 10:32   ` Wei Liu [this message]
2016-10-26 10:32     ` Wei Liu
2016-10-26 14:26     ` Eduardo Habkost
2016-10-26 14:26     ` [Qemu-devel] " Eduardo Habkost
2016-10-25 23:33 ` Stefano Stabellini
2016-10-26 15:09 ` [Qemu-devel] " Igor Mammedov
2016-10-26 15:09   ` Igor Mammedov
2016-10-26 15:22   ` Wei Liu
2016-10-26 15:22     ` Wei Liu
2016-10-26 21:27     ` Stefano Stabellini
2016-10-26 21:30       ` Stefano Stabellini
2016-10-26 21:30         ` Stefano Stabellini
2016-10-26 21:27     ` Stefano Stabellini
2016-10-27 10:54     ` Igor Mammedov
2016-10-27 10:54       ` Igor Mammedov
2016-10-27 11:03       ` Wei Liu
2016-10-27 11:03         ` Wei Liu
2016-10-27 11:10         ` Wei Liu
2016-10-27 11:10           ` Wei Liu
2016-10-27 11:26           ` [Qemu-devel] [Xen-devel] " Igor Mammedov
2016-10-27 11:29             ` [Qemu-devel] " Wei Liu
2016-10-27 11:29             ` [Qemu-devel] [Xen-devel] " Wei Liu
2016-10-27 13:02               ` Igor Mammedov
2016-10-27 13:02                 ` [Qemu-devel] " Igor Mammedov
2016-10-27 11:26           ` Igor Mammedov
2016-10-27 10:57     ` Igor Mammedov
2016-10-27 10:57       ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161026103255.GG30231@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=ehabkost@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.