From: Lee Jones <lee.jones@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/15] mfd: tc3589x: improve function-level documentation
Date: Wed, 26 Oct 2016 12:18:32 +0000 [thread overview]
Message-ID: <20161026121832.GT8574@dell> (raw)
In-Reply-To: <1475351192-27079-7-git-send-email-Julia.Lawall@lip6.fr>
On Sat, 01 Oct 2016, Julia Lawall wrote:
> Use the correct function name in one case and adjust a variable name to
> that of the corresponding function parameter in another case.
>
> Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/mfd/tc3589x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
> index 274bf39..cc9e563 100644
> --- a/drivers/mfd/tc3589x.c
> +++ b/drivers/mfd/tc3589x.c
> @@ -53,7 +53,7 @@ int tc3589x_reg_read(struct tc3589x *tc3589x, u8 reg)
> EXPORT_SYMBOL_GPL(tc3589x_reg_read);
>
> /**
> - * tc3589x_reg_read() - write a single TC3589x register
> + * tc3589x_reg_write() - write a single TC3589x register
> * @tc3589x: Device to write to
> * @reg: Register to read
> * @data: Value to write
> @@ -118,7 +118,7 @@ int tc3589x_block_write(struct tc3589x *tc3589x, u8 reg, u8 length,
> * @tc3589x: Device to write to
> * @reg: Register to write
> * @mask: Mask of bits to set
> - * @values: Value to set
> + * @val: Value to set
> */
> int tc3589x_set_bits(struct tc3589x *tc3589x, u8 reg, u8 mask, u8 val)
> {
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 06/15] mfd: tc3589x: improve function-level documentation
Date: Wed, 26 Oct 2016 13:18:32 +0100 [thread overview]
Message-ID: <20161026121832.GT8574@dell> (raw)
In-Reply-To: <1475351192-27079-7-git-send-email-Julia.Lawall@lip6.fr>
On Sat, 01 Oct 2016, Julia Lawall wrote:
> Use the correct function name in one case and adjust a variable name to
> that of the corresponding function parameter in another case.
>
> Issue detected using Coccinelle (http://coccinelle.lip6.fr/)
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
> drivers/mfd/tc3589x.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/tc3589x.c b/drivers/mfd/tc3589x.c
> index 274bf39..cc9e563 100644
> --- a/drivers/mfd/tc3589x.c
> +++ b/drivers/mfd/tc3589x.c
> @@ -53,7 +53,7 @@ int tc3589x_reg_read(struct tc3589x *tc3589x, u8 reg)
> EXPORT_SYMBOL_GPL(tc3589x_reg_read);
>
> /**
> - * tc3589x_reg_read() - write a single TC3589x register
> + * tc3589x_reg_write() - write a single TC3589x register
> * @tc3589x: Device to write to
> * @reg: Register to read
> * @data: Value to write
> @@ -118,7 +118,7 @@ int tc3589x_block_write(struct tc3589x *tc3589x, u8 reg, u8 length,
> * @tc3589x: Device to write to
> * @reg: Register to write
> * @mask: Mask of bits to set
> - * @values: Value to set
> + * @val: Value to set
> */
> int tc3589x_set_bits(struct tc3589x *tc3589x, u8 reg, u8 mask, u8 val)
> {
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-10-26 12:18 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 19:46 [PATCH 00/15] improve function-level documentation Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [Drbd-dev] " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [PATCH 01/15] UBIFS: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [PATCH 02/15] netlink: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [PATCH 03/15] fscrypto: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [PATCH 04/15] lru_cache: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [Drbd-dev] " Julia Lawall
2016-10-01 19:46 ` [PATCH 05/15] dma-buf/sw_sync: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [PATCH 06/15] mfd: tc3589x: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-26 12:18 ` Lee Jones [this message]
2016-10-26 12:18 ` Lee Jones
2016-10-01 19:46 ` [PATCH 07/15] clk: sunxi: mod0: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-04 21:05 ` Maxime Ripard
2016-10-04 21:05 ` Maxime Ripard
2016-10-04 21:05 ` Maxime Ripard
2016-10-01 19:46 ` [PATCH 08/15] power: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-19 2:59 ` Sebastian Reichel
2016-10-19 2:59 ` Sebastian Reichel
2016-10-01 19:46 ` [PATCH 09/15] gma500: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [PATCH 10/15] clk: keystone: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-11-02 0:38 ` Stephen Boyd
2016-11-02 0:38 ` Stephen Boyd
2016-10-01 19:46 ` [PATCH 11/15] kobject: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 19:46 ` [PATCH 12/15] clk: tegra: dfll: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-11-02 0:38 ` Stephen Boyd
2016-11-02 0:38 ` Stephen Boyd
2016-10-01 19:46 ` [PATCH 13/15] irqchip: vic: " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-05 9:57 ` [tip:irq/urgent] irqchip/vic: Improve " tip-bot for Julia Lawall
2016-10-01 19:46 ` [PATCH 14/15] irqchip/metag-ext: improve " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 20:33 ` James Hogan
2016-10-01 20:33 ` James Hogan
2016-10-05 9:58 ` [tip:irq/urgent] irqchip/metag-ext: Improve " tip-bot for Julia Lawall
2016-10-01 19:46 ` [PATCH 15/15] drm/omap: improve " Julia Lawall
2016-10-01 19:46 ` Julia Lawall
2016-10-01 20:19 ` [PATCH 00/15] " Joe Perches
2016-10-01 20:19 ` Joe Perches
2016-10-01 20:19 ` [Drbd-dev] " Joe Perches
2016-10-01 20:19 ` Joe Perches
2016-10-01 20:39 ` Julia Lawall
2016-10-01 20:39 ` Julia Lawall
2016-10-01 20:39 ` [Drbd-dev] " Julia Lawall
2016-10-01 20:39 ` Julia Lawall
2016-10-01 20:39 ` Julia Lawall
[not found] ` <1475351192-27079-1-git-send-email-Julia.Lawall-L2FTfq7BK8M@public.gmane.org>
2016-10-05 13:15 ` Daniel Vetter
2016-10-05 13:15 ` Daniel Vetter
2016-10-05 13:15 ` [Drbd-dev] " Daniel Vetter
2016-10-05 13:15 ` Daniel Vetter
2016-10-05 13:15 ` Daniel Vetter
2016-10-05 14:04 ` kernel-doc-rst-lint (was: Re: [PATCH 00/15] improve function-level documentation) Jani Nikula
2016-10-05 14:04 ` Jani Nikula
2016-10-05 14:04 ` [Drbd-dev] " Jani Nikula
2016-10-05 14:04 ` Jani Nikula
2016-10-05 14:04 ` Jani Nikula
2016-10-05 14:04 ` Jani Nikula
2016-10-05 14:04 ` Jani Nikula
2016-10-05 14:04 ` Jani Nikula
2016-10-05 17:27 ` Markus Heiser
2016-10-05 17:27 ` Markus Heiser
2016-10-05 17:27 ` [Drbd-dev] " Markus Heiser
2016-10-05 17:27 ` Markus Heiser
2016-10-05 17:27 ` Markus Heiser
2016-10-05 17:27 ` Markus Heiser
2016-10-05 20:25 ` Julia Lawall
2016-10-05 20:25 ` Julia Lawall
2016-10-05 20:25 ` [Drbd-dev] " Julia Lawall
2016-10-05 20:25 ` Julia Lawall
[not found] ` <CAKMK7uHT3FutHQuQQ3iwXmYbidB3AOs7AxnpaJD4MTqy0-QehQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-10-05 14:47 ` [PATCH 00/15] improve function-level documentation Julia Lawall
2016-10-05 14:47 ` Julia Lawall
2016-10-05 14:47 ` [Drbd-dev] " Julia Lawall
2016-10-05 14:47 ` Julia Lawall
2016-10-05 14:47 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026121832.GT8574@dell \
--to=lee.jones@linaro.org \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.