From: Zach Brown <zach.brown@ni.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: ulf.hansson@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.
Date: Wed, 26 Oct 2016 17:28:12 -0500 [thread overview]
Message-ID: <20161026222811.GA24391@zach-desktop> (raw)
In-Reply-To: <d65f018e-b20e-9e87-fc07-eb2fb4b5079e@intel.com>
On Tue, Oct 25, 2016 at 02:30:25PM +0300, Adrian Hunter wrote:
> On 24/10/16 18:48, Zach Brown wrote:
> > On Mon, Oct 24, 2016 at 10:34:46AM +0300, Adrian Hunter wrote:
> >> On 22/10/16 00:35, Zach Brown wrote:
> >>> When the sdhci-cap-speed-modes-broken DT property is set, the driver
> >>> will ignore the bits of the capability registers that correspond to
> >>> speed modes.
> >>>
> >>> Signed-off-by: Zach Brown <zach.brown@ni.com>
> >>> ---
> >>> drivers/mmc/host/sdhci.c | 10 ++++++++++
> >>> 1 file changed, 10 insertions(+)
> >>>
> >>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> >>> index 1e25b01..59c62d3 100644
> >>> --- a/drivers/mmc/host/sdhci.c
> >>> +++ b/drivers/mmc/host/sdhci.c
> >>> @@ -22,6 +22,7 @@
> >>> #include <linux/scatterlist.h>
> >>> #include <linux/regulator/consumer.h>
> >>> #include <linux/pm_runtime.h>
> >>> +#include <linux/of.h>
> >>>
> >>> #include <linux/leds.h>
> >>>
> >>> @@ -3013,10 +3014,19 @@ void __sdhci_read_caps(struct sdhci_host *host, u16 *ver, u32 *caps, u32 *caps1)
> >>>
> >>> host->caps = caps ? *caps : sdhci_readl(host, SDHCI_CAPABILITIES);
> >>>
> >>> + if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
> >>> + "sdhci-cap-speed-modes-broken"))
> >>
> >> It rather begs the question: if you are going to do something sdhci
> >> specific, why not just read the whole of the caps register from DT?
> >>
> >
> > Throwing out the whole of the caps register seems like overkill. Also
>
> What about 2 values: one for the 64-bit caps register and one for a 64-bit
> mask of bits to override. That way you can select which bits to override
> and what to override them to.
>
I like this idea. I sent a RFC of it.
> > there are some things set by the caps that are not available in the DT.
> > For example, SDHCI_CAN_64BIT is set by the cap register and is used in
> > sdhci_setup_host to set host->flags SDHCI_USE_64_BIT_DMA.
>
> Not sure what you mean.
>
Your suggestion addresses my concern. So it's not an issue.
WARNING: multiple messages have this Message-ID (diff)
From: Zach Brown <zach.brown@ni.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: <ulf.hansson@linaro.org>, <robh+dt@kernel.org>,
<mark.rutland@arm.com>, <linux-mmc@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set.
Date: Wed, 26 Oct 2016 17:28:12 -0500 [thread overview]
Message-ID: <20161026222811.GA24391@zach-desktop> (raw)
In-Reply-To: <d65f018e-b20e-9e87-fc07-eb2fb4b5079e@intel.com>
On Tue, Oct 25, 2016 at 02:30:25PM +0300, Adrian Hunter wrote:
> On 24/10/16 18:48, Zach Brown wrote:
> > On Mon, Oct 24, 2016 at 10:34:46AM +0300, Adrian Hunter wrote:
> >> On 22/10/16 00:35, Zach Brown wrote:
> >>> When the sdhci-cap-speed-modes-broken DT property is set, the driver
> >>> will ignore the bits of the capability registers that correspond to
> >>> speed modes.
> >>>
> >>> Signed-off-by: Zach Brown <zach.brown@ni.com>
> >>> ---
> >>> drivers/mmc/host/sdhci.c | 10 ++++++++++
> >>> 1 file changed, 10 insertions(+)
> >>>
> >>> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> >>> index 1e25b01..59c62d3 100644
> >>> --- a/drivers/mmc/host/sdhci.c
> >>> +++ b/drivers/mmc/host/sdhci.c
> >>> @@ -22,6 +22,7 @@
> >>> #include <linux/scatterlist.h>
> >>> #include <linux/regulator/consumer.h>
> >>> #include <linux/pm_runtime.h>
> >>> +#include <linux/of.h>
> >>>
> >>> #include <linux/leds.h>
> >>>
> >>> @@ -3013,10 +3014,19 @@ void __sdhci_read_caps(struct sdhci_host *host, u16 *ver, u32 *caps, u32 *caps1)
> >>>
> >>> host->caps = caps ? *caps : sdhci_readl(host, SDHCI_CAPABILITIES);
> >>>
> >>> + if (of_property_read_bool(mmc_dev(host->mmc)->of_node,
> >>> + "sdhci-cap-speed-modes-broken"))
> >>
> >> It rather begs the question: if you are going to do something sdhci
> >> specific, why not just read the whole of the caps register from DT?
> >>
> >
> > Throwing out the whole of the caps register seems like overkill. Also
>
> What about 2 values: one for the 64-bit caps register and one for a 64-bit
> mask of bits to override. That way you can select which bits to override
> and what to override them to.
>
I like this idea. I sent a RFC of it.
> > there are some things set by the caps that are not available in the DT.
> > For example, SDHCI_CAN_64BIT is set by the cap register and is used in
> > sdhci_setup_host to set host->flags SDHCI_USE_64_BIT_DMA.
>
> Not sure what you mean.
>
Your suggestion addresses my concern. So it's not an issue.
next prev parent reply other threads:[~2016-10-26 22:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 21:35 [RFC v2 0/2] Ignore capability registers when it comes to speeds and use DT binding instead Zach Brown
2016-10-21 21:35 ` Zach Brown
2016-10-21 21:35 ` [RFC v2 1/2] mmc: sdhci: Add device tree property sdhci-cap-speed-modes-broken Zach Brown
2016-10-21 21:35 ` Zach Brown
2016-10-21 21:35 ` [RFC v2 2/2] mmc: sdhci: Ignore capability register when it comes to speeds and use DT binding instead when sdhci-cap-speed-modes-broken is set Zach Brown
2016-10-21 21:35 ` Zach Brown
2016-10-24 7:34 ` Adrian Hunter
2016-10-24 15:48 ` Zach Brown
2016-10-24 15:48 ` Zach Brown
2016-10-25 11:30 ` Adrian Hunter
2016-10-25 11:30 ` Adrian Hunter
2016-10-26 22:28 ` Zach Brown [this message]
2016-10-26 22:28 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026222811.GA24391@zach-desktop \
--to=zach.brown@ni.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.