* Re: [PATCH 3/3] stk1160: Remove VIDEO_STK1160_AC97 and SND_AC97_CODEC from Kconfig and Makefile.
2016-10-27 12:38 ` Ezequiel Garcia
@ 2016-10-27 13:14 ` Marcel Hasler
0 siblings, 0 replies; 3+ messages in thread
From: Marcel Hasler @ 2016-10-27 13:14 UTC (permalink / raw)
To: Ezequiel Garcia; +Cc: Mauro Carvalho Chehab, linux-media
Hi
Sure, I'll clean up the patches later on today and resubmit. The last
one should be merged with the first one anyway, I missed that at
first.
Regards
Marcel
2016-10-27 14:38 GMT+02:00 Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>:
>
> Marcel,
>
> Thanks a lot for all your stk1160 fixes. They are much appreciated! In
> particular,
> the click noise was something we really wanted to get rid of:
>
> http://mailman.alsa-project.org/pipermail/alsa-devel/2016-October/113981.html
>
> Regarding the linux-media fixes, is there any chance you re-submit
> this set of patches, in way that they are properly numbered
> PATCH 1, PATCH 2, PATCH 3...
>
> git-format-patch is able to do that for you automatically.
>
> You may also include a cover letter (it's optional) to explain
> what stuff you are fixing, how you tested, where are the patches
> based, and anything else you want to mention.
>
> (And don't forget to Cc the media mailing list)
>
> Thanks again!
> Ezequiel
>
> On 27 October 2016 at 06:10, Marcel Hasler <mahasler@gmail.com> wrote:
> > The VIDEO_STK1160_AC97 option is no longer needed after the removal of stk1160-mixer. For the
> > same reason SND and SND_AC97_CODEC are no longer required.
> >
> > Signed-off-by: Marcel Hasler <mahasler@gmail.com>
> > ---
> > drivers/media/usb/stk1160/Kconfig | 3 +--
> > drivers/media/usb/stk1160/Makefile | 4 +---
> > 2 files changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/media/usb/stk1160/Kconfig b/drivers/media/usb/stk1160/Kconfig
> > index 53617da..22dff4f 100644
> > --- a/drivers/media/usb/stk1160/Kconfig
> > +++ b/drivers/media/usb/stk1160/Kconfig
> > @@ -10,8 +10,7 @@ config VIDEO_STK1160_COMMON
> >
> > config VIDEO_STK1160
> > tristate
> > - depends on (!VIDEO_STK1160_AC97 || (SND='n') || SND) && VIDEO_STK1160_COMMON
> > + depends on VIDEO_STK1160_COMMON
> > default y
> > select VIDEOBUF2_VMALLOC
> > select VIDEO_SAA711X
> > - select SND_AC97_CODEC if SND
> > diff --git a/drivers/media/usb/stk1160/Makefile b/drivers/media/usb/stk1160/Makefile
> > index dfe3e90..42d0546 100644
> > --- a/drivers/media/usb/stk1160/Makefile
> > +++ b/drivers/media/usb/stk1160/Makefile
> > @@ -1,10 +1,8 @@
> > -obj-stk1160-ac97-$(CONFIG_VIDEO_STK1160_AC97) := stk1160-ac97.o
> > -
> > stk1160-y := stk1160-core.o \
> > stk1160-v4l.o \
> > stk1160-video.o \
> > stk1160-i2c.o \
> > - $(obj-stk1160-ac97-y)
> > + stk1160-ac97.o
> >
> > obj-$(CONFIG_VIDEO_STK1160) += stk1160.o
> >
> > --
> > 2.10.1
> >
>
>
>
> --
> Ezequiel García, VanguardiaSur
> www.vanguardiasur.com.ar
2016-10-27 14:38 GMT+02:00 Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>:
> Marcel,
>
> Thanks a lot for all your stk1160 fixes. They are much appreciated! In
> particular,
> the click noise was something we really wanted to get rid of:
>
> http://mailman.alsa-project.org/pipermail/alsa-devel/2016-October/113981.html
>
> Regarding the linux-media fixes, is there any chance you re-submit
> this set of patches, in way that they are properly numbered
> PATCH 1, PATCH 2, PATCH 3...
>
> git-format-patch is able to do that for you automatically.
>
> You may also include a cover letter (it's optional) to explain
> what stuff you are fixing, how you tested, where are the patches
> based, and anything else you want to mention.
>
> (And don't forget to Cc the media mailing list)
>
> Thanks again!
> Ezequiel
>
> On 27 October 2016 at 06:10, Marcel Hasler <mahasler@gmail.com> wrote:
>> The VIDEO_STK1160_AC97 option is no longer needed after the removal of stk1160-mixer. For the
>> same reason SND and SND_AC97_CODEC are no longer required.
>>
>> Signed-off-by: Marcel Hasler <mahasler@gmail.com>
>> ---
>> drivers/media/usb/stk1160/Kconfig | 3 +--
>> drivers/media/usb/stk1160/Makefile | 4 +---
>> 2 files changed, 2 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/media/usb/stk1160/Kconfig b/drivers/media/usb/stk1160/Kconfig
>> index 53617da..22dff4f 100644
>> --- a/drivers/media/usb/stk1160/Kconfig
>> +++ b/drivers/media/usb/stk1160/Kconfig
>> @@ -10,8 +10,7 @@ config VIDEO_STK1160_COMMON
>>
>> config VIDEO_STK1160
>> tristate
>> - depends on (!VIDEO_STK1160_AC97 || (SND='n') || SND) && VIDEO_STK1160_COMMON
>> + depends on VIDEO_STK1160_COMMON
>> default y
>> select VIDEOBUF2_VMALLOC
>> select VIDEO_SAA711X
>> - select SND_AC97_CODEC if SND
>> diff --git a/drivers/media/usb/stk1160/Makefile b/drivers/media/usb/stk1160/Makefile
>> index dfe3e90..42d0546 100644
>> --- a/drivers/media/usb/stk1160/Makefile
>> +++ b/drivers/media/usb/stk1160/Makefile
>> @@ -1,10 +1,8 @@
>> -obj-stk1160-ac97-$(CONFIG_VIDEO_STK1160_AC97) := stk1160-ac97.o
>> -
>> stk1160-y := stk1160-core.o \
>> stk1160-v4l.o \
>> stk1160-video.o \
>> stk1160-i2c.o \
>> - $(obj-stk1160-ac97-y)
>> + stk1160-ac97.o
>>
>> obj-$(CONFIG_VIDEO_STK1160) += stk1160.o
>>
>> --
>> 2.10.1
>>
>
>
>
> --
> Ezequiel García, VanguardiaSur
> www.vanguardiasur.com.ar
^ permalink raw reply [flat|nested] 3+ messages in thread