From: Mark Brown <broonie@kernel.org>
To: "Jon Medhurst (Tixy)" <tixy@linaro.org>
Cc: alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-kernel@vger.kernel.org, Jyri Sarha <jsarha@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: hdmi-codec: Fix hdmi_of_xlate_dai_name when #sound-dai-cells = <0>
Date: Thu, 27 Oct 2016 15:19:56 +0100 [thread overview]
Message-ID: <20161027141956.GL25322@sirena.org.uk> (raw)
In-Reply-To: <1477568568.2908.14.camel@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 200 bytes --]
On Thu, Oct 27, 2016 at 12:42:48PM +0100, Jon Medhurst (Tixy) wrote:
> - int id = args->args[0];
> + int id = args->args_count ? args->args[0] : 0;
Please write normal if statements for legibility.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: hdmi-codec: Fix hdmi_of_xlate_dai_name when #sound-dai-cells = <0>
Date: Thu, 27 Oct 2016 15:19:56 +0100 [thread overview]
Message-ID: <20161027141956.GL25322@sirena.org.uk> (raw)
In-Reply-To: <1477568568.2908.14.camel@linaro.org>
On Thu, Oct 27, 2016 at 12:42:48PM +0100, Jon Medhurst (Tixy) wrote:
> - int id = args->args[0];
> + int id = args->args_count ? args->args[0] : 0;
Please write normal if statements for legibility.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161027/35ec96ca/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Jon Medhurst (Tixy)" <tixy@linaro.org>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Jyri Sarha <jsarha@ti.com>, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ASoC: hdmi-codec: Fix hdmi_of_xlate_dai_name when #sound-dai-cells = <0>
Date: Thu, 27 Oct 2016 15:19:56 +0100 [thread overview]
Message-ID: <20161027141956.GL25322@sirena.org.uk> (raw)
In-Reply-To: <1477568568.2908.14.camel@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 200 bytes --]
On Thu, Oct 27, 2016 at 12:42:48PM +0100, Jon Medhurst (Tixy) wrote:
> - int id = args->args[0];
> + int id = args->args_count ? args->args[0] : 0;
Please write normal if statements for legibility.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-10-27 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 11:42 [PATCH] ASoC: hdmi-codec: Fix hdmi_of_xlate_dai_name when #sound-dai-cells = <0> Jon Medhurst (Tixy)
2016-10-27 11:42 ` Jon Medhurst (Tixy)
2016-10-27 11:42 ` Jon Medhurst (Tixy)
2016-10-27 14:19 ` Mark Brown [this message]
2016-10-27 14:19 ` Mark Brown
2016-10-27 14:19 ` Mark Brown
2016-10-28 8:18 ` [PATCH v2] " Jon Medhurst (Tixy)
2016-10-28 8:18 ` Jon Medhurst (Tixy)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027141956.GL25322@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=jsarha@ti.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tixy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.