All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: Infinite loop with DAX PMD faults
Date: Thu, 27 Oct 2016 13:54:49 -0600	[thread overview]
Message-ID: <20161027195449.GA29643@linux.intel.com> (raw)
In-Reply-To: <20161027190750.GA28888@quack2.suse.cz>

On Thu, Oct 27, 2016 at 09:07:50PM +0200, Jan Kara wrote:
> Hello,
> 
> When testing my DAX patches rebased on top of Ross' DAX PMD series, I've
> come across the following issue with generic/344 test from xfstests. The
> test ends in an infinite fault loop when we fault index 0 over and over
> again never finishing the fault. The problem is that we do a write fault
> for index 0 when there is PMD for that index. So we enter wp_huge_pmd().
> For whatever reason that returns VM_FAULT_FALLBACK so we continue to
> handle_pte_fault(). There we do
> 
> 	if (pmd_trans_unstable(vmf->pmd) || pmd_devmap(*vmf->pmd))
> 
> check which is true - the PMD we have is pmd_trans_huge() - so we 'return
> 0' and that results in retrying the fault and all happens from the
> beginning again.
> 
> It isn't quite obvious how to break that cycle to me. The comment before
> pmd_none_or_trans_huge_or_clear_bad() goes to great lengths explaining
> possible races when PMD is pmd_trans_huge() so it needs careful evaluation
> what needs to be done for DAX. Ross, any idea?

I'll try & reproduce this, and I'll get back to you.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: Infinite loop with DAX PMD faults
Date: Thu, 27 Oct 2016 13:54:49 -0600	[thread overview]
Message-ID: <20161027195449.GA29643@linux.intel.com> (raw)
In-Reply-To: <20161027190750.GA28888@quack2.suse.cz>

On Thu, Oct 27, 2016 at 09:07:50PM +0200, Jan Kara wrote:
> Hello,
> 
> When testing my DAX patches rebased on top of Ross' DAX PMD series, I've
> come across the following issue with generic/344 test from xfstests. The
> test ends in an infinite fault loop when we fault index 0 over and over
> again never finishing the fault. The problem is that we do a write fault
> for index 0 when there is PMD for that index. So we enter wp_huge_pmd().
> For whatever reason that returns VM_FAULT_FALLBACK so we continue to
> handle_pte_fault(). There we do
> 
> 	if (pmd_trans_unstable(vmf->pmd) || pmd_devmap(*vmf->pmd))
> 
> check which is true - the PMD we have is pmd_trans_huge() - so we 'return
> 0' and that results in retrying the fault and all happens from the
> beginning again.
> 
> It isn't quite obvious how to break that cycle to me. The comment before
> pmd_none_or_trans_huge_or_clear_bad() goes to great lengths explaining
> possible races when PMD is pmd_trans_huge() so it needs careful evaluation
> what needs to be done for DAX. Ross, any idea?

I'll try & reproduce this, and I'll get back to you.

  parent reply	other threads:[~2016-10-27 19:54 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27 19:07 Infinite loop with DAX PMD faults Jan Kara
2016-10-27 19:07 ` Jan Kara
2016-10-27 19:46 ` Dan Williams
2016-10-27 19:46   ` Dan Williams
2016-10-27 21:03   ` Ross Zwisler
2016-10-27 21:03     ` Ross Zwisler
2016-10-27 21:48     ` Kani, Toshimitsu
2016-10-27 21:48       ` Kani, Toshimitsu
2016-10-28  4:13       ` Ross Zwisler
2016-10-28  4:13         ` Ross Zwisler
2016-10-28  8:17         ` Jan Kara
2016-10-28  8:17           ` Jan Kara
2016-10-28 13:51           ` Kani, Toshimitsu
2016-10-28 13:51             ` Kani, Toshimitsu
2016-10-28  8:12   ` Jan Kara
2016-10-28  8:12     ` Jan Kara
2016-10-27 19:54 ` Ross Zwisler [this message]
2016-10-27 19:54   ` Ross Zwisler
2016-10-28  8:02   ` Jan Kara
2016-10-28  8:02     ` Jan Kara
2016-10-28 15:35     ` Ross Zwisler
2016-10-28 15:35       ` Ross Zwisler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161027195449.GA29643@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.