From: Stephen Boyd <sboyd@codeaurora.org>
To: Emil Lundmark <emil@limesaudio.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Michael Turquette <mturquette@baylibre.com>,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
"Ken . Lin" <ken.lin@advantech.com>,
Anson Huang <b20788@freescale.com>
Subject: Re: [PATCH v3 1/2] clk: imx: fix integer overflow in AV PLL round rate
Date: Thu, 27 Oct 2016 18:41:27 -0700 [thread overview]
Message-ID: <20161028014127.GD16026@codeaurora.org> (raw)
In-Reply-To: <4d2e3a91dfb74209735c940b51d7efc9ba2ed69b.1476267249.git.emil@limesaudio.com>
On 10/12, Emil Lundmark wrote:
> Since 'parent_rate * mfn' may overflow 32 bits, the result should be
> stored using 64 bits.
>
> The problem was discovered when trying to set the rate of the audio PLL
> (pll4_post_div) on an i.MX6Q. The desired rate was 196.608 MHz, but
> the actual rate returned was 192.000570 MHz. The round rate function should
> have been able to return 196.608 MHz, i.e., the desired rate.
>
> Fixes: ba7f4f557eb6 ("clk: imx: correct AV PLL rate formula")
> Cc: Anson Huang <b20788@freescale.com>
> Signed-off-by: Emil Lundmark <emil@limesaudio.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] clk: imx: fix integer overflow in AV PLL round rate
Date: Thu, 27 Oct 2016 18:41:27 -0700 [thread overview]
Message-ID: <20161028014127.GD16026@codeaurora.org> (raw)
In-Reply-To: <4d2e3a91dfb74209735c940b51d7efc9ba2ed69b.1476267249.git.emil@limesaudio.com>
On 10/12, Emil Lundmark wrote:
> Since 'parent_rate * mfn' may overflow 32 bits, the result should be
> stored using 64 bits.
>
> The problem was discovered when trying to set the rate of the audio PLL
> (pll4_post_div) on an i.MX6Q. The desired rate was 196.608 MHz, but
> the actual rate returned was 192.000570 MHz. The round rate function should
> have been able to return 196.608 MHz, i.e., the desired rate.
>
> Fixes: ba7f4f557eb6 ("clk: imx: correct AV PLL rate formula")
> Cc: Anson Huang <b20788@freescale.com>
> Signed-off-by: Emil Lundmark <emil@limesaudio.com>
> ---
Applied to clk-next
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-10-28 1:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 10:31 [PATCH v3 0/2] clk: imx: fix AV PLL rate setting Emil Lundmark
2016-10-12 10:31 ` Emil Lundmark
2016-10-12 10:31 ` [PATCH v3 1/2] clk: imx: fix integer overflow in AV PLL round rate Emil Lundmark
2016-10-12 10:31 ` Emil Lundmark
2016-10-14 13:33 ` Fabio Estevam
2016-10-14 13:33 ` Fabio Estevam
2016-10-28 1:41 ` Stephen Boyd [this message]
2016-10-28 1:41 ` Stephen Boyd
2016-10-28 11:47 ` Fabio Estevam
2016-10-28 11:47 ` Fabio Estevam
2016-10-28 18:13 ` Stephen Boyd
2016-10-28 18:13 ` Stephen Boyd
2016-10-28 19:32 ` Fabio Estevam
2016-10-28 19:32 ` Fabio Estevam
2016-11-02 0:07 ` Stephen Boyd
2016-11-02 0:07 ` Stephen Boyd
2016-10-12 10:31 ` [PATCH v3 2/2] clk: imx: improve precision of AV PLL to 1 Hz Emil Lundmark
2016-10-12 10:31 ` Emil Lundmark
2016-10-14 13:34 ` Fabio Estevam
2016-10-14 13:34 ` Fabio Estevam
2016-10-28 1:41 ` Stephen Boyd
2016-10-28 1:41 ` Stephen Boyd
2016-10-24 7:34 ` [PATCH v3 0/2] clk: imx: fix AV PLL rate setting Shawn Guo
2016-10-24 7:34 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028014127.GD16026@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=b20788@freescale.com \
--cc=emil@limesaudio.com \
--cc=fabio.estevam@nxp.com \
--cc=ken.lin@advantech.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.