From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Vlad Yasevich <vyasevich@gmail.com>,
daniel@iogearbox.net
Subject: Re: [PATCH net 2/3] sctp: return back transport in __sctp_rcv_init_lookup
Date: Fri, 28 Oct 2016 21:39:43 +0000 [thread overview]
Message-ID: <20161028213943.GA14175@localhost.localdomain> (raw)
In-Reply-To: <20161028194221.GC4193@localhost.localdomain>
On Fri, Oct 28, 2016 at 05:42:21PM -0200, Marcelo Ricardo Leitner wrote:
> On Fri, Oct 28, 2016 at 06:10:53PM +0800, Xin Long wrote:
> > Prior to this patch, it used a local variable to save the transport that is
> > looked up by __sctp_lookup_association(), and didn't return it back. But in
> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this
> > code, it was initializing chunk->transport with some random stack value
> > instead.
> >
> > This patch is to return the transport back through transport pointer
> > that is from __sctp_rcv_lookup_harder().
> >
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
>
> transport pointer in sctp_rcv() is initialized to null and there are
> checks for it after this path, so this shouldn't be exploitable, just
> malfunction.
This actually sort of contradicts the changelog.
Xin, did I miss something here? Seems we need to update the changelog if
not.
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Vlad Yasevich <vyasevich@gmail.com>,
daniel@iogearbox.net
Subject: Re: [PATCH net 2/3] sctp: return back transport in __sctp_rcv_init_lookup
Date: Fri, 28 Oct 2016 19:39:43 -0200 [thread overview]
Message-ID: <20161028213943.GA14175@localhost.localdomain> (raw)
In-Reply-To: <20161028194221.GC4193@localhost.localdomain>
On Fri, Oct 28, 2016 at 05:42:21PM -0200, Marcelo Ricardo Leitner wrote:
> On Fri, Oct 28, 2016 at 06:10:53PM +0800, Xin Long wrote:
> > Prior to this patch, it used a local variable to save the transport that is
> > looked up by __sctp_lookup_association(), and didn't return it back. But in
> > sctp_rcv, it is used to initialize chunk->transport. So when hitting this
> > code, it was initializing chunk->transport with some random stack value
> > instead.
> >
> > This patch is to return the transport back through transport pointer
> > that is from __sctp_rcv_lookup_harder().
> >
> > Signed-off-by: Xin Long <lucien.xin@gmail.com>
>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
>
> transport pointer in sctp_rcv() is initialized to null and there are
> checks for it after this path, so this shouldn't be exploitable, just
> malfunction.
This actually sort of contradicts the changelog.
Xin, did I miss something here? Seems we need to update the changelog if
not.
next prev parent reply other threads:[~2016-10-28 21:39 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-28 10:10 [PATCH net 0/3] sctp: a bunch of fixes by holding transport Xin Long
2016-10-28 10:10 ` Xin Long
2016-10-28 10:10 ` [PATCH net 1/3] sctp: hold transport instead of assoc in sctp_diag Xin Long
2016-10-28 10:10 ` Xin Long
2016-10-28 10:10 ` [PATCH net 2/3] sctp: return back transport in __sctp_rcv_init_lookup Xin Long
2016-10-28 10:10 ` Xin Long
2016-10-28 10:10 ` [PATCH net 3/3] sctp: hold transport instead of assoc when lookup assoc in rx path Xin Long
2016-10-28 10:10 ` Xin Long
2016-10-28 14:13 ` Neil Horman
2016-10-28 14:13 ` Neil Horman
2016-10-28 19:57 ` Marcelo Ricardo Leitner
2016-10-28 19:57 ` Marcelo Ricardo Leitner
2016-10-28 14:03 ` [PATCH net 2/3] sctp: return back transport in __sctp_rcv_init_lookup Neil Horman
2016-10-28 14:03 ` Neil Horman
2016-10-28 19:42 ` Marcelo Ricardo Leitner
2016-10-28 19:42 ` Marcelo Ricardo Leitner
2016-10-28 21:39 ` Marcelo Ricardo Leitner [this message]
2016-10-28 21:39 ` Marcelo Ricardo Leitner
2016-10-29 17:29 ` Xin Long
2016-10-29 17:29 ` Xin Long
2016-10-28 14:01 ` [PATCH net 1/3] sctp: hold transport instead of assoc in sctp_diag Neil Horman
2016-10-28 14:01 ` Neil Horman
2016-10-28 19:25 ` Marcelo Ricardo Leitner
2016-10-28 19:25 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161028213943.GA14175@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.