All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>,
	"John L. Hammond" <john.hammond@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3
Date: Sun, 30 Oct 2016 10:59:59 -0400	[thread overview]
Message-ID: <20161030145959.GA31097@kroah.com> (raw)
In-Reply-To: <1477606323-30325-23-git-send-email-jsimmons@infradead.org>

On Thu, Oct 27, 2016 at 06:11:56PM -0400, James Simmons wrote:
> From: John L. Hammond <john.hammond@intel.com>
> 
> Add a new regular file ioctl LL_IOC_FUTIMES_3 similar to futimes() but
> which allows setting of all three inode timestamps. Use this ioctl
> during HSM restore to ensure that the volatile file has the same
> timestamps as the file to be restored. Strengthen sanity-hsm test_24a
> to check that archive, release, and restore do not change a file's
> ctime. Add sanity-hsm test_24e to check that tar will succeed when it
> encounters a HSM released file.

This sounds odd, why is this filesystem the only one that needs a
"special" futimes?  Don't make up new syscalls by making an ioctl
please, make a new syscall if that's what you really need!

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Simmons <jsimmons@infradead.org>
Cc: devel@driverdev.osuosl.org,
	Andreas Dilger <andreas.dilger@intel.com>,
	Oleg Drokin <oleg.drokin@intel.com>,
	"John L. Hammond" <john.hammond@intel.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3
Date: Sun, 30 Oct 2016 10:59:59 -0400	[thread overview]
Message-ID: <20161030145959.GA31097@kroah.com> (raw)
In-Reply-To: <1477606323-30325-23-git-send-email-jsimmons@infradead.org>

On Thu, Oct 27, 2016 at 06:11:56PM -0400, James Simmons wrote:
> From: John L. Hammond <john.hammond@intel.com>
> 
> Add a new regular file ioctl LL_IOC_FUTIMES_3 similar to futimes() but
> which allows setting of all three inode timestamps. Use this ioctl
> during HSM restore to ensure that the volatile file has the same
> timestamps as the file to be restored. Strengthen sanity-hsm test_24a
> to check that archive, release, and restore do not change a file's
> ctime. Add sanity-hsm test_24e to check that tar will succeed when it
> encounters a HSM released file.

This sounds odd, why is this filesystem the only one that needs a
"special" futimes?  Don't make up new syscalls by making an ioctl
please, make a new syscall if that's what you really need!

thanks,

greg k-h

  reply	other threads:[~2016-10-30 14:59 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-27 22:11 [lustre-devel] [PATCH 00/29] Batch one for work from 2.7.55 to 2.7.59 James Simmons
2016-10-27 22:11 ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 01/29] staging: lustre: osc: remove handling cl_avail_grant less than zero James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 02/29] staging: lustre: llite: remove IS_ERR(master_inode) check James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 03/29] staging: lustre: llite: restart short read/write for normal IO James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 04/29] staging: lustre: obdclass: variable llog chunk size James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 05/29] staging: lustre: lmv: allow cross-MDT rename and link James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 06/29] staging: lustre: ptlrpc: Introduce iovec to bulk descriptor James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 07/29] staging: lustre: lov: remove LSM from struct lustre_md James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 08/29] staging: lustre: clio: update file attributes after sync James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 09/29] staging: lustre: dne: setdirstripe should fail if not supported James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 10/29] staging: lustre: ptlrpc: embed highest XID in each request James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 11/29] staging: lustre: llite: basic support of SELinux in CLIO James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 12/29] staging: lustre: mdc: manage number of modify RPCs in flight James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 23:40   ` [lustre-devel] " kbuild test robot
2016-10-27 23:40     ` kbuild test robot
2016-10-30 15:04   ` [lustre-devel] " Greg Kroah-Hartman
2016-10-30 15:04     ` Greg Kroah-Hartman
2016-10-27 22:11 ` [lustre-devel] [PATCH 13/29] staging: lustre: llite: report back to user bad stripe count James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 14/29] staging: lustre: ptlrpc: Do not resend req with allow_replay James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 15/29] staging: lustre: obdecho: don't copy lu_site James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 16/29] staging: lustre: mdc: deactive MDT permanently James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 17/29] staging: lustre: ptlrpc: replay bulk request James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 18/29] staging: lustre: mdt: disable IMA support James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 19/29] staging: lustre: ldlm: reclaim granted locks defensively James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 20/29] staging: lustre: recovery: don't skip open replay on reconnect James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 21/29] staging: lustre: obdclass: race lustre_profile_list James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 22/29] staging: lustre: llite: add LL_IOC_FUTIMES_3 James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-30 14:59   ` Greg Kroah-Hartman [this message]
2016-10-30 14:59     ` Greg Kroah-Hartman
2016-11-07  3:47     ` [lustre-devel] " James Simmons
2016-11-07  3:47       ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 23/29] staging: lustre: ptlrpc: do not sleep if encpool reached max capacity James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 24/29] staging: lustre: ptlrpc: Forbid too early NRS policy tunings James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:11 ` [lustre-devel] [PATCH 25/29] staging: lustre: llite: Inform copytool of dataversion changes James Simmons
2016-10-27 22:11   ` James Simmons
2016-10-27 22:12 ` [lustre-devel] [PATCH 26/29] staging: lustre: ptlrpc: do not switch out-of-date context James Simmons
2016-10-27 22:12   ` James Simmons
2016-10-27 22:12 ` [lustre-devel] [PATCH 27/29] staging: lustre: headers: Create single .h for lu_seq_range James Simmons
2016-10-27 22:12   ` James Simmons
2016-10-27 22:12 ` [lustre-devel] [PATCH 28/29] staging: lustre: ptlrpc: imp_peer_committed_transno should increase James Simmons
2016-10-27 22:12   ` James Simmons
2016-10-27 22:12 ` [lustre-devel] [PATCH 29/29] staging: lustre: llog: record the minimum record size James Simmons
2016-10-27 22:12   ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161030145959.GA31097@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=john.hammond@intel.com \
    --cc=jsimmons@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.