From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Sebastian Reichel <sre@kernel.org>,
kernel-janitors@vger.kernel.org,
patches@opensource.wolfsonmicro.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 03/15] wm8350_power: use permission-specific DEVICE_ATTR variants
Date: Sun, 30 Oct 2016 15:03:05 +0000 [thread overview]
Message-ID: <20161030150305.GB1575@localhost.localdomain> (raw)
In-Reply-To: <1477769829-22230-4-git-send-email-Julia.Lawall@lip6.fr>
On Sat, Oct 29, 2016 at 09:36:57PM +0200, Julia Lawall wrote:
> Use DEVICE_ATTR_RO for read only attributes. This simplifies the source
> code, improves readbility, and reduces the chance of inconsistencies.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @ro@
> declarer name DEVICE_ATTR;
> identifier x,x_show;
> @@
>
> DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
>
> @script:ocaml@
> x << ro.x;
> x_show << ro.x_show;
> @@
>
> if not (x^"_show" = x_show) then Coccilib.include_match false
>
> @@
> declarer name DEVICE_ATTR_RO;
> identifier ro.x,ro.x_show;
> @@
>
> - DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
> + DEVICE_ATTR_RO(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
WARNING: multiple messages have this Message-ID (diff)
From: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Sebastian Reichel <sre@kernel.org>,
<kernel-janitors@vger.kernel.org>,
<patches@opensource.wolfsonmicro.com>, <linux-pm@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 03/15] wm8350_power: use permission-specific DEVICE_ATTR variants
Date: Sun, 30 Oct 2016 15:03:05 +0000 [thread overview]
Message-ID: <20161030150305.GB1575@localhost.localdomain> (raw)
In-Reply-To: <1477769829-22230-4-git-send-email-Julia.Lawall@lip6.fr>
On Sat, Oct 29, 2016 at 09:36:57PM +0200, Julia Lawall wrote:
> Use DEVICE_ATTR_RO for read only attributes. This simplifies the source
> code, improves readbility, and reduces the chance of inconsistencies.
>
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @ro@
> declarer name DEVICE_ATTR;
> identifier x,x_show;
> @@
>
> DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
>
> @script:ocaml@
> x << ro.x;
> x_show << ro.x_show;
> @@
>
> if not (x^"_show" = x_show) then Coccilib.include_match false
>
> @@
> declarer name DEVICE_ATTR_RO;
> identifier ro.x,ro.x_show;
> @@
>
> - DEVICE_ATTR(x, \(0444\|S_IRUGO\), x_show, NULL);
> + DEVICE_ATTR_RO(x);
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Thanks,
Charles
next prev parent reply other threads:[~2016-10-30 15:03 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-29 19:36 [PATCH 00/15] use permission-specific DEVICE_ATTR variants Julia Lawall
2016-10-29 19:36 ` Julia Lawall
2016-10-29 19:36 ` Julia Lawall
2016-10-29 19:36 ` [PATCH 01/15] wusbcore: dev-sysfs: " Julia Lawall
2016-10-29 19:36 ` Julia Lawall
2016-10-29 19:36 ` [PATCH 02/15] wusbcore: wusbhc: " Julia Lawall
2016-10-29 19:36 ` Julia Lawall
2016-10-29 19:36 ` [PATCH 03/15] wm8350_power: " Julia Lawall
2016-10-29 19:36 ` Julia Lawall
2016-10-30 15:03 ` Charles Keepax [this message]
2016-10-30 15:03 ` Charles Keepax
2016-11-23 23:10 ` Sebastian Reichel
2016-11-23 23:10 ` Sebastian Reichel
2016-10-29 19:36 ` [PATCH 04/15] video: fbdev: " Julia Lawall
2016-10-29 19:36 ` Julia Lawall
2016-10-29 19:36 ` Julia Lawall
2017-01-11 16:06 ` Bartlomiej Zolnierkiewicz
2017-01-11 16:06 ` Bartlomiej Zolnierkiewicz
2017-01-11 16:06 ` Bartlomiej Zolnierkiewicz
2016-10-29 19:36 ` [PATCH 05/15] MIPS: TXx9: 7segled: " Julia Lawall
2016-10-29 19:36 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 06/15] thermal: int340x_thermal: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 07/15] thermal: hwmon: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 08/15] powerpc/iommu: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-31 6:06 ` Michael Ellerman
2016-10-31 6:06 ` Michael Ellerman
2017-09-01 13:29 ` [08/15] " Michael Ellerman
2017-09-01 13:29 ` Michael Ellerman
2016-10-29 19:37 ` [PATCH 09/15] arch/tile: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 10/15] ASoC: omap-mcbsp: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-30 10:58 ` Jarkko Nikula
2016-10-30 10:58 ` Jarkko Nikula
2016-10-30 10:58 ` Jarkko Nikula
2016-10-30 11:50 ` Julia Lawall
2016-10-30 11:50 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 11/15] ASoC: dapm: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 12/15] ptp: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-31 9:30 ` Richard Cochran
2016-10-31 9:30 ` Richard Cochran
2016-10-31 19:32 ` David Miller
2016-10-31 19:32 ` David Miller
2016-10-29 19:37 ` [PATCH 13/15] PCI/ASPM: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-11-14 21:40 ` Bjorn Helgaas
2016-11-14 21:40 ` Bjorn Helgaas
2016-11-14 21:52 ` Julia Lawall
2016-11-14 21:52 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 14/15] tty: nozomi: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-29 19:37 ` [PATCH 15/15] solos-pci: " Julia Lawall
2016-10-29 19:37 ` Julia Lawall
2016-10-31 19:32 ` David Miller
2016-10-31 19:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161030150305.GB1575@localhost.localdomain \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=Julia.Lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.