All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend
Date: Sun, 30 Oct 2016 16:24:04 +0100	[thread overview]
Message-ID: <20161030152404.GY3671@var.home> (raw)
In-Reply-To: <1477477064.18984.39.camel@redhat.com>

Gerd Hoffmann, on Wed 26 Oct 2016 12:17:44 +0200, wrote:
> > +        /* All consoles share the same window */
> 
> No.  That is the default setup, but try "View / Detach tab".  Window ID
> changing at runtime ...

So we would need to make baum register for notification of Window ID
change.

It could be a mere

typedef void QemuConsoleWindowIDListener(void);
qemu_console_window_id_add_listener(QemuConsoleWindowIDListener listener);
qemu_console_window_id_remove_listener(QemuConsoleWindowIDListener listener);

that adds/removes the listener to a list to be called when
qemu_console_set_window_id is called.

Or we could generalize a bit: 

typedef void QemuConsoleConfigListener(void);
qemu_console_config_add_listener(QemuConsoleConfigListener listener);
qemu_console_config_remove_listener(QemuConsoleConfigListener listener);

Or even more generalized:

struct QemuConsoleListener {
  void (*window_id)(void);
};
typedef struct QemuConsoleListener QemuConsoleListener;
qemu_console_add_listener(QemuConsoleListener *listener);
qemu_console_remove_listener(QemuConsoleListener *listener);

What would be preferrable?

Samuel

  parent reply	other threads:[~2016-10-30 15:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-23 19:54 [Qemu-devel] [PATCHv2 0/3] baum driver update v2 Samuel Thibault
2016-10-23 19:54 ` [Qemu-devel] [PATCH 1/3] Add dots keypresses support to the baum braille device Samuel Thibault
2016-10-26 12:37   ` Gerd Hoffmann
2016-10-26 15:14     ` Samuel Thibault
2016-10-27 11:29       ` Gerd Hoffmann
2016-10-23 19:54 ` [Qemu-devel] [PATCH 2/3] Defer BrlAPI tty acquisition to when guest starts using device Samuel Thibault
2016-10-23 19:54 ` [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend Samuel Thibault
2016-10-26 10:17   ` Gerd Hoffmann
2016-10-26 11:35     ` Samuel Thibault
2016-10-26 12:24       ` Gerd Hoffmann
2016-10-30 15:24     ` Samuel Thibault [this message]
2016-11-01 10:03       ` Gerd Hoffmann
  -- strict thread matches above, loose matches on Subject: below --
2016-10-23 18:47 [Qemu-devel] [PATCH 0/3] baum driver update Samuel Thibault
2016-10-23 18:47 ` [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161030152404.GY3671@var.home \
    --to=samuel.thibault@gnu.org \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.