From: Gerd Hoffmann <kraxel@redhat.com>
To: Samuel Thibault <samuel.thibault@gnu.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend
Date: Wed, 26 Oct 2016 14:24:46 +0200 [thread overview]
Message-ID: <1477484686.18984.47.camel@redhat.com> (raw)
In-Reply-To: <20161026113552.GA2811@var.bordeaux.inria.fr>
> > Also splitting this up would be nice.
>
> You mean separating the move of the sdl1.2 code from the addition of
> sdl2+gtk code? (and perhaps separate sdl2 and gtk?)
One patch adding new console.[ch] interfaces, then one patch per UI,
finally switch over baum to the new interfaces.
Maybe put sdl-ui + baum into one patch as this moves existing code sdl
code from baum.c to sdl*.c for the most part.
> > No loop needed here. qemu sorts consoles so the graphic ones come
> > first.
>
> Ok, but are we sure nobody will change that assumption someday? Or do
> we assume that if somebody changes it he will notice the assumption in
> qemu_graphic_console_get_window_id?
If that assumption ever changes the code here (and in quite a few more
places) must be adapted to it.
cheers,
Gerd
next prev parent reply other threads:[~2016-10-26 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 19:54 [Qemu-devel] [PATCHv2 0/3] baum driver update v2 Samuel Thibault
2016-10-23 19:54 ` [Qemu-devel] [PATCH 1/3] Add dots keypresses support to the baum braille device Samuel Thibault
2016-10-26 12:37 ` Gerd Hoffmann
2016-10-26 15:14 ` Samuel Thibault
2016-10-27 11:29 ` Gerd Hoffmann
2016-10-23 19:54 ` [Qemu-devel] [PATCH 2/3] Defer BrlAPI tty acquisition to when guest starts using device Samuel Thibault
2016-10-23 19:54 ` [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend Samuel Thibault
2016-10-26 10:17 ` Gerd Hoffmann
2016-10-26 11:35 ` Samuel Thibault
2016-10-26 12:24 ` Gerd Hoffmann [this message]
2016-10-30 15:24 ` Samuel Thibault
2016-11-01 10:03 ` Gerd Hoffmann
-- strict thread matches above, loose matches on Subject: below --
2016-10-23 18:47 [Qemu-devel] [PATCH 0/3] baum driver update Samuel Thibault
2016-10-23 18:47 ` [Qemu-devel] [PATCH 3/3] Move getting XWindow ID from baum driver to graphical backend Samuel Thibault
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1477484686.18984.47.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.