From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
linux-s390@vger.kernel.org
Subject: [PATCH 3/9] s390: char: make con3215 explicitly non-modular
Date: Sun, 30 Oct 2016 16:37:26 -0400 [thread overview]
Message-ID: <20161030203732.26405-4-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20161030203732.26405-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
drivers/s390/char/Kconfig:config TN3215
drivers/s390/char/Kconfig: def_bool y
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.
We don't replace module.h with init.h since the file already has that.
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/s390/char/con3215.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
index 931d10e86837..1b8d825623bd 100644
--- a/drivers/s390/char/con3215.c
+++ b/drivers/s390/char/con3215.c
@@ -9,7 +9,6 @@
* Dan Morrison, IBM Corporation <dmorriso@cse.buffalo.edu>
*/
-#include <linux/module.h>
#include <linux/types.h>
#include <linux/kdev_t.h>
#include <linux/tty.h>
@@ -1215,13 +1214,4 @@ static int __init tty3215_init(void)
tty3215_driver = driver;
return 0;
}
-
-static void __exit tty3215_exit(void)
-{
- tty_unregister_driver(tty3215_driver);
- put_tty_driver(tty3215_driver);
- ccw_driver_unregister(&raw3215_ccw_driver);
-}
-
-module_init(tty3215_init);
-module_exit(tty3215_exit);
+device_initcall(tty3215_init);
--
2.10.1
WARNING: multiple messages have this Message-ID (diff)
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: <linux-kernel@vger.kernel.org>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
<linux-s390@vger.kernel.org>
Subject: [PATCH 3/9] s390: char: make con3215 explicitly non-modular
Date: Sun, 30 Oct 2016 16:37:26 -0400 [thread overview]
Message-ID: <20161030203732.26405-4-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <20161030203732.26405-1-paul.gortmaker@windriver.com>
The Kconfig currently controlling compilation of this code is:
drivers/s390/char/Kconfig:config TN3215
drivers/s390/char/Kconfig: def_bool y
...meaning that it currently is not being built as a module by anyone.
Lets remove the modular code that is essentially orphaned, so that
when reading the driver there is no doubt it is builtin-only.
Since module_init translates to device_initcall in the non-modular
case, the init ordering remains unchanged with this commit.
We don't replace module.h with init.h since the file already has that.
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux-s390@vger.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
drivers/s390/char/con3215.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
index 931d10e86837..1b8d825623bd 100644
--- a/drivers/s390/char/con3215.c
+++ b/drivers/s390/char/con3215.c
@@ -9,7 +9,6 @@
* Dan Morrison, IBM Corporation <dmorriso@cse.buffalo.edu>
*/
-#include <linux/module.h>
#include <linux/types.h>
#include <linux/kdev_t.h>
#include <linux/tty.h>
@@ -1215,13 +1214,4 @@ static int __init tty3215_init(void)
tty3215_driver = driver;
return 0;
}
-
-static void __exit tty3215_exit(void)
-{
- tty_unregister_driver(tty3215_driver);
- put_tty_driver(tty3215_driver);
- ccw_driver_unregister(&raw3215_ccw_driver);
-}
-
-module_init(tty3215_init);
-module_exit(tty3215_exit);
+device_initcall(tty3215_init);
--
2.10.1
next prev parent reply other threads:[~2016-10-30 20:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 20:37 [PATCH 0/9] s390: remove modular usage from non-modular code Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-30 20:37 ` [PATCH 1/9] s390: cio: make it explicitly non-modular Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-30 20:37 ` [PATCH 2/9] s390: char: make zcore " Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker [this message]
2016-10-30 20:37 ` [PATCH 3/9] s390: char: make con3215 " Paul Gortmaker
2016-10-30 20:37 ` [PATCH 4/9] s390: char: make sclp_tty " Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-30 20:37 ` [PATCH 5/9] s390: char: make slcp_quiesce " Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-30 20:37 ` [PATCH 6/9] s390: hotplug: make pci_hpc " Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-30 20:37 ` [PATCH 7/9] s390: hypfs: make inode " Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-30 20:37 ` [PATCH 8/9] s390: kernel: make lgr " Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-30 20:37 ` [PATCH 9/9] s390: virtio: make ccw " Paul Gortmaker
2016-10-30 20:37 ` Paul Gortmaker
2016-10-31 10:56 ` Cornelia Huck
2016-10-31 10:56 ` Cornelia Huck
2016-10-31 9:24 ` [PATCH 0/9] s390: remove modular usage from non-modular code Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161030203732.26405-4-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.