From: "Pali Rohár" <pali.rohar@gmail.com>
To: Matt Ranostay <matt@ranostay.consulting>
Cc: Matt Ranostay <mranostay@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>,
kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux OMAP List <linux-omap@vger.kernel.org>,
Tony Lindgren <tony@atomide.com>,
khilman@kernel.org, aaro.koskinen@iki.fi,
ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com,
serge@hallyn.com, abcloriens@gmail.com
Subject: Re: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query
Date: Mon, 31 Oct 2016 21:30:20 +0100 [thread overview]
Message-ID: <201610312130.20261@pali> (raw)
In-Reply-To: <CAJ_EiSRzmQHLP2PTfzsLF4uWgYgCiRGsSk=MHbtOC5rgXnnFpw@mail.gmail.com>
[-- Attachment #1: Type: Text/Plain, Size: 870 bytes --]
On Monday 31 October 2016 21:22:18 Matt Ranostay wrote:
> On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay <mranostay@gmail.com>
> wrote:
> > On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote:
> >>> Pavel + Sebastian this is the patchset that need I some input on
> >>> :)
> >>
> >> Better then previous one.
> >
> >> But my version of bq27xxx_battery.c already contains this:
> > This is for allowing udev rule to set the properties as well.
> > otherwise a kinda crude RUN = " echo value >
> > /sys/module/bq27xxx_battery/parameters/poll_interval" is required.
>
> Any thoughts on this?
Isn't sysfs /sys/module/bq27xxx_battery/parameters/poll_interval
attribute what should be used to change module parameters like
poll_interval?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query
Date: Mon, 31 Oct 2016 21:30:20 +0100 [thread overview]
Message-ID: <201610312130.20261@pali> (raw)
In-Reply-To: <CAJ_EiSRzmQHLP2PTfzsLF4uWgYgCiRGsSk=MHbtOC5rgXnnFpw@mail.gmail.com>
On Monday 31 October 2016 21:22:18 Matt Ranostay wrote:
> On Tue, Oct 25, 2016 at 11:47 AM, Matt Ranostay <mranostay@gmail.com>
> wrote:
> > On Mon, Oct 24, 2016 at 1:14 PM, Pavel Machek <pavel@ucw.cz> wrote:
> >> On Mon 2016-10-24 12:58:25, Matt Ranostay wrote:
> >>> Pavel + Sebastian this is the patchset that need I some input on
> >>> :)
> >>
> >> Better then previous one.
> >
> >> But my version of bq27xxx_battery.c already contains this:
> > This is for allowing udev rule to set the properties as well.
> > otherwise a kinda crude RUN = " echo value >
> > /sys/module/bq27xxx_battery/parameters/poll_interval" is required.
>
> Any thoughts on this?
Isn't sysfs /sys/module/bq27xxx_battery/parameters/poll_interval
attribute what should be used to change module parameters like
poll_interval?
--
Pali Roh?r
pali.rohar at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20161031/aa2d9abc/attachment.sig>
next prev parent reply other threads:[~2016-10-31 20:30 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 19:55 [PATCH v2 0/2] power_supply: add new POWER_SUPPLY_PROP_POLL_INTERVAL property Matt Ranostay
2016-09-28 19:55 ` [PATCH v2 1/2] power: power_supply: add new property POWER_SUPPLY_PROP_POLL_INTERVAL Matt Ranostay
2016-09-28 19:55 ` [PATCH v2 2/2] power: bq27xxx_battery: add poll interval property query Matt Ranostay
2016-10-24 19:58 ` Matt Ranostay
2016-10-24 20:14 ` Pavel Machek
2016-10-24 20:14 ` Pavel Machek
2016-10-25 18:47 ` Matt Ranostay
2016-10-25 18:47 ` Matt Ranostay
2016-10-31 20:22 ` Matt Ranostay
2016-10-31 20:22 ` Matt Ranostay
2016-10-31 20:30 ` Pali Rohár [this message]
2016-10-31 20:30 ` Pali Rohár
2016-10-31 21:38 ` Pavel Machek
2016-10-31 21:38 ` Pavel Machek
2016-11-01 19:58 ` Matt Ranostay
2016-11-01 19:58 ` Matt Ranostay
2016-11-02 8:22 ` Pavel Machek
2016-11-02 8:22 ` Pavel Machek
2016-11-04 5:00 ` Matt Ranostay
2016-11-04 5:00 ` Matt Ranostay
2016-11-04 7:09 ` Pavel Machek
2016-11-04 7:09 ` Pavel Machek
2016-11-04 14:58 ` Tony Lindgren
2016-11-04 14:58 ` Tony Lindgren
2016-11-04 20:29 ` Pavel Machek
2016-11-04 20:29 ` Pavel Machek
2016-11-04 20:39 ` Matt Ranostay
2016-11-04 20:39 ` Matt Ranostay
2016-11-04 21:43 ` Pavel Machek
2016-11-04 21:43 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201610312130.20261@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=matt@ranostay.consulting \
--cc=mranostay@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.