From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Wei Yongjun <weiyj.lk@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com,
linux-remoteproc@vger.kernel.org
Subject: Re: [PATCH -next] remoteproc: st: Fix error return code in st_rproc_probe()
Date: Mon, 31 Oct 2016 17:37:34 -0700 [thread overview]
Message-ID: <20161101003734.GA14397@tuxbot> (raw)
In-Reply-To: <1476721415-20224-1-git-send-email-weiyj.lk@gmail.com>
On Mon 17 Oct 09:23 PDT 2016, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the st_rproc_state() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, with added "Fixes". Thanks!
Regards,
Bjorn
> ---
> drivers/remoteproc/st_remoteproc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
> index ae8963f..da4e152 100644
> --- a/drivers/remoteproc/st_remoteproc.c
> +++ b/drivers/remoteproc/st_remoteproc.c
> @@ -245,8 +245,10 @@ static int st_rproc_probe(struct platform_device *pdev)
> goto free_rproc;
>
> enabled = st_rproc_state(pdev);
> - if (enabled < 0)
> + if (enabled < 0) {
> + ret = enabled;
> goto free_rproc;
> + }
>
> if (enabled) {
> atomic_inc(&rproc->power);
>
WARNING: multiple messages have this Message-ID (diff)
From: bjorn.andersson@linaro.org (Bjorn Andersson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH -next] remoteproc: st: Fix error return code in st_rproc_probe()
Date: Mon, 31 Oct 2016 17:37:34 -0700 [thread overview]
Message-ID: <20161101003734.GA14397@tuxbot> (raw)
In-Reply-To: <1476721415-20224-1-git-send-email-weiyj.lk@gmail.com>
On Mon 17 Oct 09:23 PDT 2016, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix to return a negative error code from the st_rproc_state() error
> handling case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied, with added "Fixes". Thanks!
Regards,
Bjorn
> ---
> drivers/remoteproc/st_remoteproc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
> index ae8963f..da4e152 100644
> --- a/drivers/remoteproc/st_remoteproc.c
> +++ b/drivers/remoteproc/st_remoteproc.c
> @@ -245,8 +245,10 @@ static int st_rproc_probe(struct platform_device *pdev)
> goto free_rproc;
>
> enabled = st_rproc_state(pdev);
> - if (enabled < 0)
> + if (enabled < 0) {
> + ret = enabled;
> goto free_rproc;
> + }
>
> if (enabled) {
> atomic_inc(&rproc->power);
>
next prev parent reply other threads:[~2016-11-01 0:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:23 [PATCH -next] remoteproc: st: Fix error return code in st_rproc_probe() Wei Yongjun
2016-10-17 16:23 ` Wei Yongjun
2016-11-01 0:37 ` Bjorn Andersson [this message]
2016-11-01 0:37 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101003734.GA14397@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=weiyj.lk@gmail.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.