From: Stephen Boyd <sboyd@codeaurora.org>
To: Akinobu Mita <akinobu.mita@gmail.com>
Cc: linux-clk@vger.kernel.org,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
Mike Looijmans <mike.looijmans@topic.nl>,
Michael Turquette <mturquette@linaro.org>
Subject: Re: [PATCH] clk: cdce925: add support for CDCE913, CDCE937, and CDCE949
Date: Tue, 1 Nov 2016 10:48:08 -0700 [thread overview]
Message-ID: <20161101174808.GU16026@codeaurora.org> (raw)
In-Reply-To: <CAC5umyiVcV_KEL+g=mRL-mGQfJrCU5XrEVNzX=CFFXWNuTMBGQ@mail.gmail.com>
On 11/01, Akinobu Mita wrote:
> 2016-11-01 3:15 GMT+09:00 Stephen Boyd <sboyd@codeaurora.org>:
> > On 10/31, Akinobu Mita wrote:
> >> @@ -728,13 +780,19 @@ static int cdce925_probe(struct i2c_client *client,
> >> }
> >>
> >> static const struct i2c_device_id cdce925_id[] = {
> >> - { "cdce925", 0 },
> >> + { "cdce913", CDCE913 },
> >> + { "cdce925", CDCE925 },
> >> + { "cdce937", CDCE937 },
> >> + { "cdce949", CDCE949 },
> >> { }
> >> };
> >> MODULE_DEVICE_TABLE(i2c, cdce925_id);
> >>
> >> static const struct of_device_id clk_cdce925_of_match[] = {
> >> + { .compatible = "ti,cdce913" },
> >> { .compatible = "ti,cdce925" },
> >> + { .compatible = "ti,cdce937" },
> >> + { .compatible = "ti,cdce949" },
> >
> > Doesn't this need to be updated to point to the correct enum
> > values?
>
> I think it isn't needed. Because the data field in struct of_device_id
> for this driver is not used even if the device is registered from
> device tree. But the driver_data in i2c_device_id is used instead.
Ok. Have you tested this driver with DT or platform data? Do you
prefix the compatible string with "ti," in the DT case?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Akinobu Mita <akinobu.mita-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"open list:OPEN FIRMWARE AND..."
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mike Looijmans <mike.looijmans-Oq418RWZeHk@public.gmane.org>,
Michael Turquette
<mturquette-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH] clk: cdce925: add support for CDCE913, CDCE937, and CDCE949
Date: Tue, 1 Nov 2016 10:48:08 -0700 [thread overview]
Message-ID: <20161101174808.GU16026@codeaurora.org> (raw)
In-Reply-To: <CAC5umyiVcV_KEL+g=mRL-mGQfJrCU5XrEVNzX=CFFXWNuTMBGQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 11/01, Akinobu Mita wrote:
> 2016-11-01 3:15 GMT+09:00 Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>:
> > On 10/31, Akinobu Mita wrote:
> >> @@ -728,13 +780,19 @@ static int cdce925_probe(struct i2c_client *client,
> >> }
> >>
> >> static const struct i2c_device_id cdce925_id[] = {
> >> - { "cdce925", 0 },
> >> + { "cdce913", CDCE913 },
> >> + { "cdce925", CDCE925 },
> >> + { "cdce937", CDCE937 },
> >> + { "cdce949", CDCE949 },
> >> { }
> >> };
> >> MODULE_DEVICE_TABLE(i2c, cdce925_id);
> >>
> >> static const struct of_device_id clk_cdce925_of_match[] = {
> >> + { .compatible = "ti,cdce913" },
> >> { .compatible = "ti,cdce925" },
> >> + { .compatible = "ti,cdce937" },
> >> + { .compatible = "ti,cdce949" },
> >
> > Doesn't this need to be updated to point to the correct enum
> > values?
>
> I think it isn't needed. Because the data field in struct of_device_id
> for this driver is not used even if the device is registered from
> device tree. But the driver_data in i2c_device_id is used instead.
Ok. Have you tested this driver with DT or platform data? Do you
prefix the compatible string with "ti," in the DT case?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-11-01 17:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-30 17:30 [PATCH] clk: cdce925: add support for CDCE913, CDCE937, and CDCE949 Akinobu Mita
2016-10-30 17:30 ` Akinobu Mita
2016-10-30 18:39 ` Mike Looijmans
2016-10-30 18:39 ` Mike Looijmans
2016-10-31 15:12 ` Akinobu Mita
2016-10-31 15:12 ` Akinobu Mita
2016-10-31 6:34 ` Rob Herring
2016-10-31 18:15 ` Stephen Boyd
2016-10-31 18:15 ` Stephen Boyd
2016-11-01 13:52 ` Akinobu Mita
2016-11-01 17:48 ` Stephen Boyd [this message]
2016-11-01 17:48 ` Stephen Boyd
2016-11-02 14:42 ` Akinobu Mita
2016-11-02 14:42 ` Akinobu Mita
2016-11-02 17:56 ` Stephen Boyd
2016-11-02 17:56 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161101174808.GU16026@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=akinobu.mita@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.