From: "Daniel P. Berrange" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] ui/gtk: Fix build with older versions of gtk
Date: Wed, 2 Nov 2016 10:18:48 +0000 [thread overview]
Message-ID: <20161102101848.GB2573@redhat.com> (raw)
In-Reply-To: <1478081328-25515-1-git-send-email-thuth@redhat.com>
On Wed, Nov 02, 2016 at 11:08:48AM +0100, Thomas Huth wrote:
> GDK_KEY_Delete is only defined with gtk version 2.22 and newer,
> on older versions this key was called GDK_Delete instead.
> Since this is the case for all GDK_KEY_* defines, change the
> already existing preprocessor check there to test for version 2.22,
> so we know that we can remove this code block in case we require
> that version as a minimum one day.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> ui/gtk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ui/gtk: Fix build with older versions of gtk
Date: Wed, 2 Nov 2016 10:18:48 +0000 [thread overview]
Message-ID: <20161102101848.GB2573@redhat.com> (raw)
In-Reply-To: <1478081328-25515-1-git-send-email-thuth@redhat.com>
On Wed, Nov 02, 2016 at 11:08:48AM +0100, Thomas Huth wrote:
> GDK_KEY_Delete is only defined with gtk version 2.22 and newer,
> on older versions this key was called GDK_Delete instead.
> Since this is the case for all GDK_KEY_* defines, change the
> already existing preprocessor check there to test for version 2.22,
> so we know that we can remove this code block in case we require
> that version as a minimum one day.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> ui/gtk.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
next prev parent reply other threads:[~2016-11-02 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 10:08 [Qemu-trivial] [PATCH] ui/gtk: Fix build with older versions of gtk Thomas Huth
2016-11-02 10:08 ` [Qemu-devel] " Thomas Huth
2016-11-02 10:18 ` Daniel P. Berrange [this message]
2016-11-02 10:18 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102101848.GB2573@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.