From: Christophe Fergeau <cfergeau@redhat.com>
To: spice-devel@lists.freedesktop.org
Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org
Subject: [drm/qxl v2 4/7] qxl: Call qxl_gem_{init,fini}
Date: Wed, 2 Nov 2016 18:00:33 +0100 [thread overview]
Message-ID: <20161102170036.1409-5-cfergeau@redhat.com> (raw)
In-Reply-To: <20161102170036.1409-1-cfergeau@redhat.com>
qdev->gem.objects was initialized directly in qxl_device_init() rather
than going through qxl_gem_init(), and qxl_gem_fini() was never called.
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
---
drivers/gpu/drm/qxl/qxl_kms.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/qxl/qxl_kms.c b/drivers/gpu/drm/qxl/qxl_kms.c
index e642242..af685f1 100644
--- a/drivers/gpu/drm/qxl/qxl_kms.c
+++ b/drivers/gpu/drm/qxl/qxl_kms.c
@@ -131,7 +131,7 @@ static int qxl_device_init(struct qxl_device *qdev,
mutex_init(&qdev->update_area_mutex);
mutex_init(&qdev->release_mutex);
mutex_init(&qdev->surf_evict_mutex);
- INIT_LIST_HEAD(&qdev->gem.objects);
+ qxl_gem_init(qdev);
qdev->rom_base = pci_resource_start(pdev, 2);
qdev->rom_size = pci_resource_len(pdev, 2);
@@ -273,6 +273,7 @@ static void qxl_device_fini(struct qxl_device *qdev)
qxl_ring_free(qdev->command_ring);
qxl_ring_free(qdev->cursor_ring);
qxl_ring_free(qdev->release_ring);
+ qxl_gem_fini(qdev);
qxl_bo_fini(qdev);
io_mapping_free(qdev->surface_mapping);
io_mapping_free(qdev->vram_mapping);
--
2.9.3
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-11-02 17:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 17:00 [drm/qxl v2 0/7] qxl: Various cleanups/fixes Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 1/7] qxl: Mark some internal functions as static Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 2/7] qxl: Remove unused prototype Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 3/7] qxl: Add missing '\n' to qxl_io_log() call Christophe Fergeau
2016-11-02 17:00 ` Christophe Fergeau [this message]
2016-11-02 17:00 ` [drm/qxl v2 5/7] qxl: Remove qxl_bo_init() return value Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 6/7] qxl: Don't notify userspace when monitors config is unchanged Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8 Christophe Fergeau
2016-11-03 8:53 ` Gerd Hoffmann
2016-11-03 11:41 ` Christophe Fergeau
2016-11-03 17:08 ` Gerd Hoffmann
2016-11-04 10:41 ` Christophe Fergeau
2016-11-07 7:22 ` Dave Airlie
2016-11-07 8:18 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161102170036.1409-5-cfergeau@redhat.com \
--to=cfergeau@redhat.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.