All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christophe Fergeau <cfergeau@redhat.com>
To: spice-devel@lists.freedesktop.org
Cc: airlied@redhat.com, dri-devel@lists.freedesktop.org
Subject: [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8
Date: Wed,  2 Nov 2016 18:00:36 +0100	[thread overview]
Message-ID: <20161102170036.1409-8-cfergeau@redhat.com> (raw)
In-Reply-To: <20161102170036.1409-1-cfergeau@redhat.com>

The use of drm_cvt_mode() in qxl_add_monitors_config_modes() means that
the resolutions we are going to present to user-space are going to be
rounded down to a multiple of 8. In the QXL arbitrary resolution case,
this is not useful.
This commit forces the actual width/height that was requested by the
client in the drm_display_mode structure rather than keeping the
rounded version.

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
---
 drivers/gpu/drm/qxl/qxl_display.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
index 2f1d738..2241954 100644
--- a/drivers/gpu/drm/qxl/qxl_display.c
+++ b/drivers/gpu/drm/qxl/qxl_display.c
@@ -200,6 +200,9 @@ static int qxl_add_monitors_config_modes(struct drm_connector *connector,
 	mode = drm_cvt_mode(dev, head->width, head->height, 60, false, false,
 			    false);
 	mode->type |= DRM_MODE_TYPE_PREFERRED;
+	mode->hdisplay = head->width;
+	mode->vdisplay = head->height;
+	drm_mode_set_name(mode);
 	*pwidth = head->width;
 	*pheight = head->height;
 	drm_mode_probed_add(connector, mode);
-- 
2.9.3

_______________________________________________
Spice-devel mailing list
Spice-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/spice-devel

  parent reply	other threads:[~2016-11-02 17:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-02 17:00 [drm/qxl v2 0/7] qxl: Various cleanups/fixes Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 1/7] qxl: Mark some internal functions as static Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 2/7] qxl: Remove unused prototype Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 3/7] qxl: Add missing '\n' to qxl_io_log() call Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 4/7] qxl: Call qxl_gem_{init,fini} Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 5/7] qxl: Remove qxl_bo_init() return value Christophe Fergeau
2016-11-02 17:00 ` [drm/qxl v2 6/7] qxl: Don't notify userspace when monitors config is unchanged Christophe Fergeau
2016-11-02 17:00 ` Christophe Fergeau [this message]
2016-11-03  8:53   ` [drm/qxl v2 7/7] qxl: Allow resolution which are not multiple of 8 Gerd Hoffmann
2016-11-03 11:41     ` Christophe Fergeau
2016-11-03 17:08       ` Gerd Hoffmann
2016-11-04 10:41         ` Christophe Fergeau
2016-11-07  7:22           ` Dave Airlie
2016-11-07  8:18             ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161102170036.1409-8-cfergeau@redhat.com \
    --to=cfergeau@redhat.com \
    --cc=airlied@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=spice-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.