All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] lttng-tools: do not install shared libraries in ptest package
@ 2016-11-02 17:09 Alexander Kanavin
  2016-11-02 17:09 ` [PATCH 2/2] populate_sdk_base.bbclass: add documentation packages to SDKs if api-documentation is in DISTRO_FEATURES Alexander Kanavin
  2016-11-02 19:43 ` [PATCH 1/2] lttng-tools: do not install shared libraries in ptest package Nathan Lynch
  0 siblings, 2 replies; 3+ messages in thread
From: Alexander Kanavin @ 2016-11-02 17:09 UTC (permalink / raw)
  To: openembedded-core

This was creating a race in runtime library dependency resolution
where sometimes the library was assumed to be provided by the ptest
package.

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
---
 meta/recipes-kernel/lttng/lttng-tools_git.bb | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-kernel/lttng/lttng-tools_git.bb b/meta/recipes-kernel/lttng/lttng-tools_git.bb
index 016346f..0d2bd00 100644
--- a/meta/recipes-kernel/lttng/lttng-tools_git.bb
+++ b/meta/recipes-kernel/lttng/lttng-tools_git.bb
@@ -113,4 +113,7 @@ do_install_ptest () {
 	# checkpatch.pl is unneeded on target and causes file-rdeps QA
 	# warnings.
 	rm -f ${D}${PTEST_PATH}/extras/checkpatch.pl
+
+        # Remove built libraries as they confuse the packages' runtime dependency resolution
+        rm -rf ${D}${PTEST_PATH}/src/lib/lttng-ctl/.libs/
 }
-- 
2.10.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] populate_sdk_base.bbclass: add documentation packages to SDKs if api-documentation is in DISTRO_FEATURES
  2016-11-02 17:09 [PATCH 1/2] lttng-tools: do not install shared libraries in ptest package Alexander Kanavin
@ 2016-11-02 17:09 ` Alexander Kanavin
  2016-11-02 19:43 ` [PATCH 1/2] lttng-tools: do not install shared libraries in ptest package Nathan Lynch
  1 sibling, 0 replies; 3+ messages in thread
From: Alexander Kanavin @ 2016-11-02 17:09 UTC (permalink / raw)
  To: openembedded-core

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
---
 meta/classes/populate_sdk_base.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/populate_sdk_base.bbclass b/meta/classes/populate_sdk_base.bbclass
index 4462b52..a0d3527 100644
--- a/meta/classes/populate_sdk_base.bbclass
+++ b/meta/classes/populate_sdk_base.bbclass
@@ -17,7 +17,7 @@ def complementary_globs(featurevar, d):
             globs.append(glob)
     return ' '.join(globs)
 
-SDKIMAGE_FEATURES ??= "dev-pkgs dbg-pkgs"
+SDKIMAGE_FEATURES ??= "dev-pkgs dbg-pkgs ${@bb.utils.contains('DISTRO_FEATURES', 'api-documentation', 'doc-pkgs', '', d)}"
 SDKIMAGE_INSTALL_COMPLEMENTARY = '${@complementary_globs("SDKIMAGE_FEATURES", d)}'
 
 inherit rootfs_${IMAGE_PKGTYPE}
-- 
2.10.1



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/2] lttng-tools: do not install shared libraries in ptest package
  2016-11-02 17:09 [PATCH 1/2] lttng-tools: do not install shared libraries in ptest package Alexander Kanavin
  2016-11-02 17:09 ` [PATCH 2/2] populate_sdk_base.bbclass: add documentation packages to SDKs if api-documentation is in DISTRO_FEATURES Alexander Kanavin
@ 2016-11-02 19:43 ` Nathan Lynch
  1 sibling, 0 replies; 3+ messages in thread
From: Nathan Lynch @ 2016-11-02 19:43 UTC (permalink / raw)
  To: Alexander Kanavin; +Cc: openembedded-core

On 11/02/2016 11:09 AM, Alexander Kanavin wrote:
> This was creating a race in runtime library dependency resolution
> where sometimes the library was assumed to be provided by the ptest
> package.
> 
> Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>

FWIW:

Acked-by: Nathan Lynch <nathan_lynch@mentor.com>

Can this be applied to the morty branch after it hits master?



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-11-02 19:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-02 17:09 [PATCH 1/2] lttng-tools: do not install shared libraries in ptest package Alexander Kanavin
2016-11-02 17:09 ` [PATCH 2/2] populate_sdk_base.bbclass: add documentation packages to SDKs if api-documentation is in DISTRO_FEATURES Alexander Kanavin
2016-11-02 19:43 ` [PATCH 1/2] lttng-tools: do not install shared libraries in ptest package Nathan Lynch

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.