* [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 10:19 ` Thomas Huth
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2016-11-02 10:19 UTC (permalink / raw)
To: qemu-devel, Stefano Stabellini, Anthony Perard
Cc: qemu-trivial, olaf, xen-devel, xuquan8, emilcondrea
Olaf Hering reported a build failure due to an undefined reference
to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
fix the issue.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/xen/xen_pvdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
index 405e154..5212bc6 100644
--- a/hw/xen/xen_pvdev.c
+++ b/hw/xen/xen_pvdev.c
@@ -18,7 +18,7 @@
*/
#include "qemu/osdep.h"
-
+#include "qemu/log.h"
#include "hw/xen/xen_backend.h"
#include "hw/xen/xen_pvdev.h"
--
1.8.3.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 10:19 ` Thomas Huth
0 siblings, 0 replies; 15+ messages in thread
From: Thomas Huth @ 2016-11-02 10:19 UTC (permalink / raw)
To: qemu-devel, Stefano Stabellini, Anthony Perard
Cc: qemu-trivial, xen-devel, olaf, xuquan8, emilcondrea
Olaf Hering reported a build failure due to an undefined reference
to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
fix the issue.
Signed-off-by: Thomas Huth <thuth@redhat.com>
---
hw/xen/xen_pvdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
index 405e154..5212bc6 100644
--- a/hw/xen/xen_pvdev.c
+++ b/hw/xen/xen_pvdev.c
@@ -18,7 +18,7 @@
*/
#include "qemu/osdep.h"
-
+#include "qemu/log.h"
#include "hw/xen/xen_backend.h"
#include "hw/xen/xen_pvdev.h"
--
1.8.3.1
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [Qemu-trivial] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
2016-11-02 10:19 ` [Qemu-devel] " Thomas Huth
(?)
@ 2016-11-02 17:34 ` Stefano Stabellini
-1 siblings, 0 replies; 15+ messages in thread
From: Stefano Stabellini @ 2016-11-02 17:34 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Stefano Stabellini, Anthony Perard, qemu-trivial,
xen-devel, olaf, xuquan8, emilcondrea
On Wed, 2 Nov 2016, Thomas Huth wrote:
> Olaf Hering reported a build failure due to an undefined reference
> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> fix the issue.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
The fix makes sense:
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
However I was unable to reproduce the build failure, so I would like a
confirmation from Olaf that the fix is working.
> hw/xen/xen_pvdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
> index 405e154..5212bc6 100644
> --- a/hw/xen/xen_pvdev.c
> +++ b/hw/xen/xen_pvdev.c
> @@ -18,7 +18,7 @@
> */
>
> #include "qemu/osdep.h"
> -
> +#include "qemu/log.h"
> #include "hw/xen/xen_backend.h"
> #include "hw/xen/xen_pvdev.h"
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 17:34 ` Stefano Stabellini
0 siblings, 0 replies; 15+ messages in thread
From: Stefano Stabellini @ 2016-11-02 17:34 UTC (permalink / raw)
To: Thomas Huth
Cc: olaf, Stefano Stabellini, qemu-trivial, qemu-devel, xuquan8,
xen-devel, Anthony Perard, emilcondrea
On Wed, 2 Nov 2016, Thomas Huth wrote:
> Olaf Hering reported a build failure due to an undefined reference
> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> fix the issue.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
The fix makes sense:
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
However I was unable to reproduce the build failure, so I would like a
confirmation from Olaf that the fix is working.
> hw/xen/xen_pvdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
> index 405e154..5212bc6 100644
> --- a/hw/xen/xen_pvdev.c
> +++ b/hw/xen/xen_pvdev.c
> @@ -18,7 +18,7 @@
> */
>
> #include "qemu/osdep.h"
> -
> +#include "qemu/log.h"
> #include "hw/xen/xen_backend.h"
> #include "hw/xen/xen_pvdev.h"
>
> --
> 1.8.3.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 17:34 ` Stefano Stabellini
0 siblings, 0 replies; 15+ messages in thread
From: Stefano Stabellini @ 2016-11-02 17:34 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Stefano Stabellini, Anthony Perard, qemu-trivial,
xen-devel, olaf, xuquan8, emilcondrea
On Wed, 2 Nov 2016, Thomas Huth wrote:
> Olaf Hering reported a build failure due to an undefined reference
> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> fix the issue.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
The fix makes sense:
Acked-by: Stefano Stabellini <sstabellini@kernel.org>
However I was unable to reproduce the build failure, so I would like a
confirmation from Olaf that the fix is working.
> hw/xen/xen_pvdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/xen/xen_pvdev.c b/hw/xen/xen_pvdev.c
> index 405e154..5212bc6 100644
> --- a/hw/xen/xen_pvdev.c
> +++ b/hw/xen/xen_pvdev.c
> @@ -18,7 +18,7 @@
> */
>
> #include "qemu/osdep.h"
> -
> +#include "qemu/log.h"
> #include "hw/xen/xen_backend.h"
> #include "hw/xen/xen_pvdev.h"
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
2016-11-02 17:34 ` [Qemu-devel] " Stefano Stabellini
(?)
@ 2016-11-02 20:42 ` Peter Maydell
-1 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2016-11-02 20:42 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Thomas Huth, Olaf Hering, QEMU Trivial, QEMU Developers, xuquan8,
xen-devel@lists.xensource.com Devel, Anthony Perard, Emil Condrea,
Stefan Hajnoczi
On 2 November 2016 at 17:34, Stefano Stabellini <sstabellini@kernel.org> wrote:
> On Wed, 2 Nov 2016, Thomas Huth wrote:
>> Olaf Hering reported a build failure due to an undefined reference
>> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
>> fix the issue.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> The fix makes sense:
>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>
> However I was unable to reproduce the build failure, so I would like a
> confirmation from Olaf that the fix is working.
If you configure with the (default) simple trace
backend then trace.h will pull in qemu/log.h
(and in this case trace.h comes in via xen_common.h).
But if you're using a different backend then it won't
bring in that header, and you'll get the build failure.
This is a fairly common "breaks but only with
some trace backends" compile failure, but I'm
not sure how best to try to make it more robust
(or at least into a 'fails-everywhere' bug).
thanks
-- PMM
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 20:42 ` Peter Maydell
0 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2016-11-02 20:42 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Thomas Huth, xen-devel@lists.xensource.com Devel, QEMU Trivial,
Olaf Hering, QEMU Developers, xuquan8, Stefan Hajnoczi,
Anthony Perard, Emil Condrea
On 2 November 2016 at 17:34, Stefano Stabellini <sstabellini@kernel.org> wrote:
> On Wed, 2 Nov 2016, Thomas Huth wrote:
>> Olaf Hering reported a build failure due to an undefined reference
>> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
>> fix the issue.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> The fix makes sense:
>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>
> However I was unable to reproduce the build failure, so I would like a
> confirmation from Olaf that the fix is working.
If you configure with the (default) simple trace
backend then trace.h will pull in qemu/log.h
(and in this case trace.h comes in via xen_common.h).
But if you're using a different backend then it won't
bring in that header, and you'll get the build failure.
This is a fairly common "breaks but only with
some trace backends" compile failure, but I'm
not sure how best to try to make it more robust
(or at least into a 'fails-everywhere' bug).
thanks
-- PMM
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 20:42 ` Peter Maydell
0 siblings, 0 replies; 15+ messages in thread
From: Peter Maydell @ 2016-11-02 20:42 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Thomas Huth, Olaf Hering, QEMU Trivial, QEMU Developers, xuquan8,
xen-devel@lists.xensource.com Devel, Anthony Perard, Emil Condrea,
Stefan Hajnoczi
On 2 November 2016 at 17:34, Stefano Stabellini <sstabellini@kernel.org> wrote:
> On Wed, 2 Nov 2016, Thomas Huth wrote:
>> Olaf Hering reported a build failure due to an undefined reference
>> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
>> fix the issue.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
>
> The fix makes sense:
>
> Acked-by: Stefano Stabellini <sstabellini@kernel.org>
>
> However I was unable to reproduce the build failure, so I would like a
> confirmation from Olaf that the fix is working.
If you configure with the (default) simple trace
backend then trace.h will pull in qemu/log.h
(and in this case trace.h comes in via xen_common.h).
But if you're using a different backend then it won't
bring in that header, and you'll get the build failure.
This is a fairly common "breaks but only with
some trace backends" compile failure, but I'm
not sure how best to try to make it more robust
(or at least into a 'fails-everywhere' bug).
thanks
-- PMM
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
2016-11-02 20:42 ` Peter Maydell
(?)
@ 2016-11-02 20:53 ` Stefano Stabellini
-1 siblings, 0 replies; 15+ messages in thread
From: Stefano Stabellini @ 2016-11-02 20:53 UTC (permalink / raw)
To: Peter Maydell
Cc: Stefano Stabellini, Thomas Huth, Olaf Hering, QEMU Trivial,
QEMU Developers, xuquan8, xen-devel@lists.xensource.com Devel,
Anthony Perard, Emil Condrea, Stefan Hajnoczi
On Wed, 2 Nov 2016, Peter Maydell wrote:
> On 2 November 2016 at 17:34, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > On Wed, 2 Nov 2016, Thomas Huth wrote:
> >> Olaf Hering reported a build failure due to an undefined reference
> >> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> >> fix the issue.
> >>
> >> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >
> > The fix makes sense:
> >
> > Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> > However I was unable to reproduce the build failure, so I would like a
> > confirmation from Olaf that the fix is working.
>
> If you configure with the (default) simple trace
> backend then trace.h will pull in qemu/log.h
> (and in this case trace.h comes in via xen_common.h).
> But if you're using a different backend then it won't
> bring in that header, and you'll get the build failure.
>
> This is a fairly common "breaks but only with
> some trace backends" compile failure, but I'm
> not sure how best to try to make it more robust
> (or at least into a 'fails-everywhere' bug).
Personally what I can do is adding
--enable-trace-backends=syslog
to my test scripts. That is enough to repro the issue. Thanks for the
explanation.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 20:53 ` Stefano Stabellini
0 siblings, 0 replies; 15+ messages in thread
From: Stefano Stabellini @ 2016-11-02 20:53 UTC (permalink / raw)
To: Peter Maydell
Cc: Thomas Huth, Stefano Stabellini, QEMU Trivial, Olaf Hering,
QEMU Developers, xuquan8, xen-devel@lists.xensource.com Devel,
Stefan Hajnoczi, Anthony Perard, Emil Condrea
On Wed, 2 Nov 2016, Peter Maydell wrote:
> On 2 November 2016 at 17:34, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > On Wed, 2 Nov 2016, Thomas Huth wrote:
> >> Olaf Hering reported a build failure due to an undefined reference
> >> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> >> fix the issue.
> >>
> >> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >
> > The fix makes sense:
> >
> > Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> > However I was unable to reproduce the build failure, so I would like a
> > confirmation from Olaf that the fix is working.
>
> If you configure with the (default) simple trace
> backend then trace.h will pull in qemu/log.h
> (and in this case trace.h comes in via xen_common.h).
> But if you're using a different backend then it won't
> bring in that header, and you'll get the build failure.
>
> This is a fairly common "breaks but only with
> some trace backends" compile failure, but I'm
> not sure how best to try to make it more robust
> (or at least into a 'fails-everywhere' bug).
Personally what I can do is adding
--enable-trace-backends=syslog
to my test scripts. That is enough to repro the issue. Thanks for the
explanation.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 20:53 ` Stefano Stabellini
0 siblings, 0 replies; 15+ messages in thread
From: Stefano Stabellini @ 2016-11-02 20:53 UTC (permalink / raw)
To: Peter Maydell
Cc: Stefano Stabellini, Thomas Huth, Olaf Hering, QEMU Trivial,
QEMU Developers, xuquan8, xen-devel@lists.xensource.com Devel,
Anthony Perard, Emil Condrea, Stefan Hajnoczi
On Wed, 2 Nov 2016, Peter Maydell wrote:
> On 2 November 2016 at 17:34, Stefano Stabellini <sstabellini@kernel.org> wrote:
> > On Wed, 2 Nov 2016, Thomas Huth wrote:
> >> Olaf Hering reported a build failure due to an undefined reference
> >> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> >> fix the issue.
> >>
> >> Signed-off-by: Thomas Huth <thuth@redhat.com>
> >
> > The fix makes sense:
> >
> > Acked-by: Stefano Stabellini <sstabellini@kernel.org>
> >
> > However I was unable to reproduce the build failure, so I would like a
> > confirmation from Olaf that the fix is working.
>
> If you configure with the (default) simple trace
> backend then trace.h will pull in qemu/log.h
> (and in this case trace.h comes in via xen_common.h).
> But if you're using a different backend then it won't
> bring in that header, and you'll get the build failure.
>
> This is a fairly common "breaks but only with
> some trace backends" compile failure, but I'm
> not sure how best to try to make it more robust
> (or at least into a 'fails-everywhere' bug).
Personally what I can do is adding
--enable-trace-backends=syslog
to my test scripts. That is enough to repro the issue. Thanks for the
explanation.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-trivial] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
2016-11-02 10:19 ` [Qemu-devel] " Thomas Huth
(?)
@ 2016-11-02 18:39 ` Olaf Hering
-1 siblings, 0 replies; 15+ messages in thread
From: Olaf Hering @ 2016-11-02 18:39 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Stefano Stabellini, Anthony Perard, qemu-trivial,
xen-devel, xuquan8, emilcondrea
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Wed, Nov 02, Thomas Huth wrote:
> Olaf Hering reported a build failure due to an undefined reference
> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> fix the issue.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Tested-by: Olaf Hering <olaf@aepfle.de>
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 18:39 ` Olaf Hering
0 siblings, 0 replies; 15+ messages in thread
From: Olaf Hering @ 2016-11-02 18:39 UTC (permalink / raw)
To: Thomas Huth
Cc: xuquan8, Stefano Stabellini, qemu-trivial, qemu-devel, xen-devel,
Anthony Perard, emilcondrea
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Wed, Nov 02, Thomas Huth wrote:
> Olaf Hering reported a build failure due to an undefined reference
> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> fix the issue.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Tested-by: Olaf Hering <olaf@aepfle.de>
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/xen/xen_pvdev: Include qemu/log.h for qemu_log_vprintf()
@ 2016-11-02 18:39 ` Olaf Hering
0 siblings, 0 replies; 15+ messages in thread
From: Olaf Hering @ 2016-11-02 18:39 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Stefano Stabellini, Anthony Perard, qemu-trivial,
xen-devel, xuquan8, emilcondrea
[-- Attachment #1: Type: text/plain, Size: 300 bytes --]
On Wed, Nov 02, Thomas Huth wrote:
> Olaf Hering reported a build failure due to an undefined reference
> to 'qemu_log_vprintf'. Explicitely including qemu/log.h seems to
> fix the issue.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Tested-by: Olaf Hering <olaf@aepfle.de>
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
^ permalink raw reply [flat|nested] 15+ messages in thread